Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3442799imu; Sun, 11 Nov 2018 15:12:14 -0800 (PST) X-Google-Smtp-Source: AJdET5cBgXKPfvJHotSjs9LYIwcBmDaKagSds2NH51TE5hTdUGsn5TAHV6hr9DJAidQIApybyBAU X-Received: by 2002:a62:ae06:: with SMTP id q6-v6mr17901670pff.126.1541977934855; Sun, 11 Nov 2018 15:12:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541977934; cv=none; d=google.com; s=arc-20160816; b=AjKzeduDgABxXXfwxOrwBE4DOSw4PPlbtM29qVzi2u1Z6lGQYqyDYMuSur2y2EHZdq 3KGC1ob9iYwKaEH3JAkdaJ13CJbOSzJSMoYXMQT5PPOw6IsMLpcAE6vrdLIiHs1ljM5q 8v74IsGwX/o1+T5JwN4Nr329eBk60iLau9SvmWCa7q/o8Nn9+tPSSqxAo8Ts0rxxLELp xgGMJUIwUp+r32BGYUik+H0angSymsudxepSpZRCc2SDiEyKVV4jl2qyixhgPWYhLsZo bSl/hPrGpKrJ6hIIQrzXxCcX7BiSMWDkCJs3hoLaAQC+Xxna/4kIAlGrOwduYQhOW4JR 5RxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=q6nvU55nEdOcjGDFnvcn5hgd1+feWMlZWrnKioYZaGk=; b=CxjUMqMfoUmPVBW0OKKi6AUrqFB3DEKFpEXnzgsiUNN01JHWwwhYya/iBe+HSRt5uT kiZ0FiwxolKeEXKVnXs8jfH9Kxyn60kl65tEYrT5JVDz5XWRBmkxhpz484mlMaOXN7mP TGa+VaHJXYIpDMQR2gMSOkLgjdzLrm6SzlV/Jy7qGViGbztWm6Z5z1QR5EiBhUB1vedt EwVYTUTvPWugvVDXVie+Qetv6/CkfVLcmRyNYJoO3AlQGMfwB20P5BDMQWcfTz+jQ4ot h9WWUIthhr6TFP5UASlWkTx+0kj2Du9Q2fQKUdJRgiCpBz1WD62KWC6egB1Tr3RCWP2i KArA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CPZEicaP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i20-v6si13001986pgk.562.2018.11.11.15.11.59; Sun, 11 Nov 2018 15:12:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CPZEicaP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390163AbeKLJAg (ORCPT + 99 others); Mon, 12 Nov 2018 04:00:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:50552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390159AbeKLIWA (ORCPT ); Mon, 12 Nov 2018 03:22:00 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6228A21780; Sun, 11 Nov 2018 22:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975523; bh=PozC+MAJHzWB+Hn2JYhU/RL2aUeRJ1GtYVmD3viK/Pc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CPZEicaPhoh1VMf8BgXrbyJ7FmyJRmVuknpvm00GLyhSMI6Xy6R05sLKSjcvJdlJi VKssIjbzCh7t8e34I9MjEwdXTsOC1lcOQ526p+I3O10dQ+yS++qlqdICFaThkoKwj4 RkBu7xI0AHwrU/8/yOqK04Cw67AC0r6lJG2WUfb4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Stanoev , Takashi Iwai Subject: [PATCH 4.14 018/222] ALSA: ca0106: Disable IZD on SB0570 DAC to fix audio pops Date: Sun, 11 Nov 2018 14:21:55 -0800 Message-Id: <20181111221649.755749173@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221647.665769131@linuxfoundation.org> References: <20181111221647.665769131@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Stanoev commit ac237c28d5ac1b241d58b1b7b4b9fa10efb22fb5 upstream. The Creative Audigy SE (SB0570) card currently exhibits an audible pop whenever playback is stopped or resumed, or during silent periods of an audio stream. Initialise the IZD bit to the 0 to eliminate these pops. The Infinite Zero Detection (IZD) feature on the DAC causes the output to be shunted to Vcap after 2048 samples of silence. This discharges the AC coupling capacitor through the output and causes the aforementioned pop/click noise. The behaviour of the IZD bit is described on page 15 of the WM8768GEDS datasheet: "With IZD=1, applying MUTE for 1024 consecutive input samples will cause all outputs to be connected directly to VCAP. This also happens if 2048 consecutive zero input samples are applied to all 6 channels, and IZD=0. It will be removed as soon as any channel receives a non-zero input". I believe the second sentence might be referring to IZD=1 instead of IZD=0 given the observed behaviour of the card. This change should make the DAC initialisation consistent with Creative's Windows driver, as this popping persists when initialising the card in Linux and soft rebooting into Windows, but is not present on a cold boot to Windows. Signed-off-by: Alex Stanoev Cc: Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/ca0106/ca0106.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/ca0106/ca0106.h +++ b/sound/pci/ca0106/ca0106.h @@ -582,7 +582,7 @@ #define SPI_PL_BIT_R_R (2<<7) /* right channel = right */ #define SPI_PL_BIT_R_C (3<<7) /* right channel = (L+R)/2 */ #define SPI_IZD_REG 2 -#define SPI_IZD_BIT (1<<4) /* infinite zero detect */ +#define SPI_IZD_BIT (0<<4) /* infinite zero detect */ #define SPI_FMT_REG 3 #define SPI_FMT_BIT_RJ (0<<0) /* right justified mode */