Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3467987imu; Sun, 11 Nov 2018 15:47:40 -0800 (PST) X-Google-Smtp-Source: AJdET5dE0DI3JPxxwctphTkFed6DZ3ZLoT+QnSShU3VJ0Xk1R+BWY/F8IQYvvMk8U0u2AhJh7h2b X-Received: by 2002:a17:902:c01:: with SMTP id 1-v6mr17839386pls.15.1541980060519; Sun, 11 Nov 2018 15:47:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541980060; cv=none; d=google.com; s=arc-20160816; b=wy7G3Ht6/ONGgOQ/W9XhBQcJonf/2Lag9C6F2cX4QVU7+vR8FeXOkc6FMBITjxEgbX GVE4YIZzWRnS/48/UAIqWazzsQJA4hoxO5iODgthkDcbv65Ca8Sy2RkZA5LJ8a798yyh 8XPF8T8Y/6gqBKKJquChRYvWKd86HTUZbh7lUb9SeZgfnHSGD7+VT3/FSQP5M752nsVq dnANcF0hDkRGdzwLlCijT0U7IsQr2F//JHnXPf428gj/w1PHa6dq8A5446vIegH4ICKz ZpZVRdULwTO7NfbOLzvYkGw/a7OR+DYDeQ9VmTpn+0G3SjTZqcIud0b4cALbRQDBespp S0fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oqp0znQGO5IRex+Xwwj2MB/DzRac18uE56gRTqY2br4=; b=WiO/Pr3OdbButw4qyxl8qS3maDx8q1TDjr/jQru6yGBwi+lnwzSBHzkhqUdkZTmirJ qU2wEmxhhGfcheOPphjquSFvknm5iqcuY+XFftrKZ5vAirOmoG1z53q1zfLC4Mybj77X e9apvMhNf3MDOD0iOtDmQw9ain0+KL8wzcBHecmGXV9vwejU9vmTWp07y5Umdmy4G2vu u5Ix8TcqNAd+QVV64JPbgJRCZf7rTjjvlgEdPgEBGbNF7g5HK8mgJAOUbMv2dHNpls1Q Vyu1ShyYWGEg5FKCgCB5k6Bo3rJF2ETqCd+kqTBZYOA3T1GsyWEyz/Mho0guDRsKgzHz BW6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dF6o8gl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si9119746pgb.343.2018.11.11.15.47.25; Sun, 11 Nov 2018 15:47:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dF6o8gl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387410AbeKLITF (ORCPT + 99 others); Mon, 12 Nov 2018 03:19:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:39860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731062AbeKLITE (ORCPT ); Mon, 12 Nov 2018 03:19:04 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E1BB21104; Sun, 11 Nov 2018 22:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975348; bh=E2GsH9iqi6ZkW5ki9lsnmQ6tle8fmacNnHGaUQqcwrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2dF6o8gli6RLNHlsVfYspxYrNcqpBING0vsj1GcFjY/ndPmenAK2M4FDiaoGNku1V wZqnbuZwhqKuwax0kX9pWsOZLkfxfG1cSCvsNKE2AAQ2PQ0ObOq5KP3qcUga70vXFJ 3SOLslE0hX2xCDq+Ax+7NrAjSBRsg64K51580By4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mikulas Patocka , Nicolas Pitre Subject: [PATCH 4.19 358/361] vt: fix broken display when running aptitude Date: Sun, 11 Nov 2018 14:21:45 -0800 Message-Id: <20181111221702.092206116@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221619.915519183@linuxfoundation.org> References: <20181111221619.915519183@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mikulas Patocka commit 943210ba807ec50aafa2fa7b13bd6d36a478969b upstream. If you run aptitude on framebuffer console, the display is corrupted. The corruption is caused by the commit d8ae7242. The patch adds "offset" to "start" when calling scr_memsetw, but it forgets to do the same addition on a subsequent call to do_update_region. Signed-off-by: Mikulas Patocka Fixes: d8ae72427187 ("vt: preserve unicode values corresponding to screen characters") Reviewed-by: Nicolas Pitre Cc: stable@vger.kernel.org # 4.19 Signed-off-by: Greg Kroah-Hartman --- drivers/tty/vt/vt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -1551,7 +1551,7 @@ static void csi_K(struct vc_data *vc, in scr_memsetw(start + offset, vc->vc_video_erase_char, 2 * count); vc->vc_need_wrap = 0; if (con_should_update(vc)) - do_update_region(vc, (unsigned long) start, count); + do_update_region(vc, (unsigned long)(start + offset), count); } static void csi_X(struct vc_data *vc, int vpar) /* erase the following vpar positions */