Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3471541imu; Sun, 11 Nov 2018 15:52:49 -0800 (PST) X-Google-Smtp-Source: AJdET5cjIdL9v4tIiooLiR9qjDWzXaERYvzOpGQeOnjE65+u7d4LwgwEzu7Y5U0xq6eIsh0njplr X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr15536382pgd.422.1541980369429; Sun, 11 Nov 2018 15:52:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541980369; cv=none; d=google.com; s=arc-20160816; b=FQ7A1jymQp5VgJp05dFZNjq5YQwwW9UIfU5cxUqIXBGb6nyBRvj4kp95nmBjsu72D6 KVhOknu/CV9k7KqivgpxFliWmwvWV0QbKvOjZ67wBlwd+EUDd30zVtwbgkWEq/a8Y88+ QyiEUQoFtcc27YrDPilM3UqM8qeCYef+KgvsYPpYkVGqBP29cCfsdgJjTUKwIQ58rxz7 A3Gi0nhGO0eDlV8SVAtobLRgJyWJo5/L9E4QPzjva2Q/YB7B23X4mcTBMgFugjPzuOD0 NxSe83cok39m/FO2kiRRhGfELGb9iYEKtjUI1kxn7Ah7QIg94w6aIkUDwEbd7GCWcZBe TAvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QnJVty7kPjqOxtYhrL0jxEWqxjkT6l0xofZTbGVu3u0=; b=jSi0tzr7cKsUCVLra0wKMPEsITa7Uu2Eba7s6GYIZtMWghukf3vPI6cFpWMr+PwXkv c9AbVwT163Gwj+mOnqGxieybGmPWdE2/30unA+AGWtxATmKgcgI/BhJN/cMSTxw4XNSb +rul/X1Dt49HzGp6yTnZcXMuqlIrdDI0QDYkA/CbLujsJ4xboaCM3VyNU6eOhd4exFwt yo9rOYr1WYyQfFcCNvqRKb4Uq5f8/rMsvyNj54x0FAvIRbQ5SY9UiiWufbgMdn8O48z7 kUtirVp53rzx25QoyiJ3K2XzOrq0i78L07e+fraVQXySk0O/DP6pKWB5fheFUdgdBWyR QljA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzQb+SN9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si17741066pfh.233.2018.11.11.15.52.34; Sun, 11 Nov 2018 15:52:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TzQb+SN9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733033AbeKLJmf (ORCPT + 99 others); Mon, 12 Nov 2018 04:42:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:37238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732647AbeKLIS3 (ORCPT ); Mon, 12 Nov 2018 03:18:29 -0500 Received: from localhost (unknown [206.108.79.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E87472154B; Sun, 11 Nov 2018 22:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541975313; bh=J96VVGLQjMXD9T/phyAh4y6CgvOgCmptSGnOLTZJdr8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TzQb+SN98QxV465eZx6UJWZxoQZUfeoqf+B4qUMwkHtAtjDGCn8GF/wRHqJ78iats fRBIjAh9l35/XkjruXN6VnAOmMQ+BAEvZkGcm7tTlscp7i5jmNt255ic7izFTM6py/ rQMZpEYLnr3nDDedkoLenWaJjXE+8C9J23zGL8Z8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sibi Sankar , Bjorn Andersson Subject: [PATCH 4.19 296/361] remoteproc: qcom: q6v5: Propagate EPROBE_DEFER Date: Sun, 11 Nov 2018 14:20:43 -0800 Message-Id: <20181111221657.100871905@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181111221619.915519183@linuxfoundation.org> References: <20181111221619.915519183@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bjorn Andersson commit d5269c4553a64b6882f2c019ae21b783a0984a83 upstream. In the case that the interrupts fail to result because of the interrupt-controller not yet being registered the platform_get_irq_byname() call will fail with -EPROBE_DEFER, but passing this into devm_request_threaded_irq() will result in -EINVAL being returned, the driver is therefor not reprobed later. Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource handling") Cc: stable@vger.kernel.org Reviewed-by: Sibi Sankar Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/qcom_q6v5.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -198,6 +198,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v } q6v5->fatal_irq = platform_get_irq_byname(pdev, "fatal"); + if (q6v5->fatal_irq == -EPROBE_DEFER) + return -EPROBE_DEFER; + ret = devm_request_threaded_irq(&pdev->dev, q6v5->fatal_irq, NULL, q6v5_fatal_interrupt, IRQF_TRIGGER_RISING | IRQF_ONESHOT, @@ -208,6 +211,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v } q6v5->ready_irq = platform_get_irq_byname(pdev, "ready"); + if (q6v5->ready_irq == -EPROBE_DEFER) + return -EPROBE_DEFER; + ret = devm_request_threaded_irq(&pdev->dev, q6v5->ready_irq, NULL, q6v5_ready_interrupt, IRQF_TRIGGER_RISING | IRQF_ONESHOT, @@ -218,6 +224,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v } q6v5->handover_irq = platform_get_irq_byname(pdev, "handover"); + if (q6v5->handover_irq == -EPROBE_DEFER) + return -EPROBE_DEFER; + ret = devm_request_threaded_irq(&pdev->dev, q6v5->handover_irq, NULL, q6v5_handover_interrupt, IRQF_TRIGGER_RISING | IRQF_ONESHOT, @@ -229,6 +238,9 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v disable_irq(q6v5->handover_irq); q6v5->stop_irq = platform_get_irq_byname(pdev, "stop-ack"); + if (q6v5->stop_irq == -EPROBE_DEFER) + return -EPROBE_DEFER; + ret = devm_request_threaded_irq(&pdev->dev, q6v5->stop_irq, NULL, q6v5_stop_interrupt, IRQF_TRIGGER_RISING | IRQF_ONESHOT,