Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266416AbUAICiE (ORCPT ); Thu, 8 Jan 2004 21:38:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266417AbUAICiD (ORCPT ); Thu, 8 Jan 2004 21:38:03 -0500 Received: from pentafluge.infradead.org ([213.86.99.235]:7837 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S266416AbUAICiC (ORCPT ); Thu, 8 Jan 2004 21:38:02 -0500 Subject: Re: [PATCH] 2.6.1-rc2 ide barrier support From: Benjamin Herrenschmidt To: Jens Axboe Cc: Linux Kernel list , Andrew Morton , Bartlomiej Zolnierkiewicz In-Reply-To: <20040107134323.GB16720@suse.de> References: <20040107134323.GB16720@suse.de> Content-Type: text/plain Message-Id: <1073615696.784.181.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Fri, 09 Jan 2004 13:34:57 +1100 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 490 Lines: 15 > + char special_buf[8]; /* private command buffer */ Why not put that in struct drive instead ? You must be a bit more careful on the lifetime, but it's less bloat, there are much less instances of struct drive than struct request :) Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/