Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3712404imu; Sun, 11 Nov 2018 22:08:47 -0800 (PST) X-Google-Smtp-Source: AJdET5f7a4vM2yQyYKcobTgDLOWDhYAxPMv7EWoDdfGK21pG8M5mWeApkDbly2+R4bkdKKMYHiwT X-Received: by 2002:a62:be18:: with SMTP id l24-v6mr18353648pff.51.1542002927536; Sun, 11 Nov 2018 22:08:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542002927; cv=none; d=google.com; s=arc-20160816; b=VmaFGZDcs+QNdrui41eaTvNGukwxF4qZGhPHYmHUtm4qzMvKTC5+aVEyzpO/iRcOhl dQ2J7DLDC24Ek36+FBHMxHaZ2IJSlQW8Ke1ZOpBKAX/CmLHoaGSBZ5UeLOLBQRbYr4Ep 7zKfVURMkJ2Yzg00AdKG7D9lkf0NJb0LSJftvnvjSz6JjgW1wqqcANGQjrKPGJWNk4hz fRvMH5zHqKEz3TxcuNhKIsr5ZnwGpZQ2i/tt/GJf/ncs+zqFshBjoWN8+fZ4HIreVzJw xrCr/RC8oWCJ0Okd4RdZ0AwHS70dPdyY45ST3XZgQwM2ujFKitZKDo5/BD3pqH90yoKR SZbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:message-id:date:subject:cc:from; bh=X5M/WiJJcJTDkhIQb6TmcE+NTpK3wHdsMS4YzuZ8Tn4=; b=HmMml9d72702btpcregrAtlsxTUwGxyK1q4DkeIenxJjOUlHfXyjqS55sBIbAh7qp5 eQIsnGYSAo+jxHHwMxbx8ERNzTqSKtg/oc3SnM4MbjLKy6m4xAzmvvT0Ojm/Lw8yJU/4 9tpJihHBrgjPfYWclfdwFKTly7y20Zlu0reUj9lC+XyS0jICNhUTBBlkJXEM6EmQZIE/ VMte4pVkll5ioCQ2jcfNonzf496EyKrlVcb3o2lRykOsL1br+kVu4feTyv1cce54GraR ctwh+xw0jxHG0kXRYP503aC6htt9+rkirU0q2OUri/5R8uKGvzbr5oynWSs8kVsWc2TG +M9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h69si14327392pge.121.2018.11.11.22.08.31; Sun, 11 Nov 2018 22:08:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731690AbeKLP7x (ORCPT + 99 others); Mon, 12 Nov 2018 10:59:53 -0500 Received: from alexa-out-blr-01.qualcomm.com ([103.229.18.197]:17745 "EHLO alexa-out-blr-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731226AbeKLP7x (ORCPT ); Mon, 12 Nov 2018 10:59:53 -0500 X-IronPort-AV: E=Sophos;i="5.54,494,1534789800"; d="scan'208";a="282833" Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 12 Nov 2018 11:38:06 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9074"; a="5747613" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg01-blr.qualcomm.com with ESMTP; 12 Nov 2018 11:38:04 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 92E1224B7; Mon, 12 Nov 2018 11:38:04 +0530 (IST) From: Arun KS Cc: keescook@chromium.org, khlebnikov@yandex-team.ru, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vatsa@codeaurora.org, Arun KS Subject: [PATCH v4 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Date: Mon, 12 Nov 2018 11:37:45 +0530 Message-Id: <1542002869-16704-1-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on 4.20-rc2. And memory hotplug tested on arm64, but on an older version of kernel. totalram_pages, zone->managed_pages and totalhigh_pages updates are protected by managed_page_count_lock, but readers never care about it. Convert these variables to atomic to avoid readers potentially seeing a store tear. Main motivation was that managed_page_count_lock handling was complicating things. It was discussed in length here, https://lore.kernel.org/patchwork/patch/995739/#1181785 It seemes better to remove the lock and convert variables to atomic. With the change, preventing poteintial store-to-read tearing comes as a bonus. Changes in v4: - Fixed kbuild test robot error. - Modified changelog. - Rebased to 4.20.-rc2 Changes in v3: - Fixed kbuild test robot errors. - Modified changelogs to be more clear. - EXPORT_SYMBOL for _totalram_pages and _totalhigh_pages. Arun KS (4): mm: reference totalram_pages and managed_pages once per function mm: convert zone->managed_pages to atomic variable mm: convert totalram_pages and totalhigh_pages variables to atomic mm: Remove managed_page_count spinlock arch/csky/mm/init.c | 4 +- arch/powerpc/platforms/pseries/cmm.c | 10 ++-- arch/s390/mm/init.c | 2 +- arch/um/kernel/mem.c | 3 +- arch/x86/kernel/cpu/microcode/core.c | 5 +- drivers/char/agp/backend.c | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- drivers/hv/hv_balloon.c | 19 +++---- drivers/md/dm-bufio.c | 2 +- drivers/md/dm-crypt.c | 2 +- drivers/md/dm-integrity.c | 2 +- drivers/md/dm-stats.c | 2 +- drivers/media/platform/mtk-vpu/mtk_vpu.c | 2 +- drivers/misc/vmw_balloon.c | 2 +- drivers/parisc/ccio-dma.c | 4 +- drivers/parisc/sba_iommu.c | 4 +- drivers/staging/android/ion/ion_system_heap.c | 2 +- drivers/xen/xen-selfballoon.c | 6 +-- fs/ceph/super.h | 2 +- fs/file_table.c | 7 +-- fs/fuse/inode.c | 2 +- fs/nfs/write.c | 2 +- fs/nfsd/nfscache.c | 2 +- fs/ntfs/malloc.h | 2 +- fs/proc/base.c | 2 +- include/linux/highmem.h | 28 ++++++++++- include/linux/mm.h | 27 +++++++++- include/linux/mmzone.h | 15 +++--- include/linux/swap.h | 1 - kernel/fork.c | 5 +- kernel/kexec_core.c | 5 +- kernel/power/snapshot.c | 2 +- lib/show_mem.c | 2 +- mm/highmem.c | 5 +- mm/huge_memory.c | 2 +- mm/kasan/quarantine.c | 2 +- mm/memblock.c | 6 +-- mm/mm_init.c | 2 +- mm/oom_kill.c | 2 +- mm/page_alloc.c | 72 +++++++++++++-------------- mm/shmem.c | 7 +-- mm/slab.c | 2 +- mm/swap.c | 2 +- mm/util.c | 2 +- mm/vmalloc.c | 4 +- mm/vmstat.c | 4 +- mm/workingset.c | 2 +- mm/zswap.c | 4 +- net/dccp/proto.c | 7 +-- net/decnet/dn_route.c | 2 +- net/ipv4/tcp_metrics.c | 2 +- net/netfilter/nf_conntrack_core.c | 7 +-- net/netfilter/xt_hashlimit.c | 5 +- net/sctp/protocol.c | 7 +-- security/integrity/ima/ima_kexec.c | 2 +- 57 files changed, 195 insertions(+), 142 deletions(-) -- 1.9.1