Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <5be59bf8.1c69fb81.a231.dcd6@mx.google.com> <CAFqt6zY5PUB-=1PeNKHiWmgbrR=3EfqcYsWOVH5TLeJnQf0JBg@mail.gmail.com>
In-Reply-To: <CAFqt6zY5PUB-=1PeNKHiWmgbrR=3EfqcYsWOVH5TLeJnQf0JBg@mail.gmail.com>
From:   Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Date:   Mon, 12 Nov 2018 17:34:42 +0530
Message-ID: <CAJr6mf1Eeu8n+E37aEjw6NZh3dMgDQbxXi=gOrvmaf7qjxHqLA@mail.gmail.com>
Subject: Re: [PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc_coherent
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     oulijun@huawei.com, xavier.huwei@huawei.com, dledford@redhat.com,
        jgg@ziepe.ca, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Brajeswar Ghosh <brajeswar.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 10, 2018 at 11:57 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Fri, Nov 9, 2018 at 8:08 PM Sabyasachi Gupta
> <sabyasachi.linux@gmail.com> wrote:
> >
> > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> There are few other places in this file where same is applicable.
> Can we get those changes in same patch ?
> >
as all the changes are now in linux-next I am going to drop this patch

> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > ---
> >  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > index a4c62ae..c9966ec 100644
> > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> > @@ -4972,13 +4972,12 @@ static int hns_roce_mhop_alloc_eq(struct hns_roce_dev *hr_dev,
> >                                 eqe_alloc = i * (buf_chk_sz / eq->eqe_size);
> >                                 size = (eq->entries - eqe_alloc) * eq->eqe_size;
> >                         }
> > -                       eq->buf[i] = dma_alloc_coherent(dev, size,
> > +                       eq->buf[i] = dma_zalloc_coherent(dev, size,
> >                                                         &(eq->buf_dma[i]),
> >                                                         GFP_KERNEL);
> >                         if (!eq->buf[i])
> >                                 goto err_dma_alloc_buf;
> >
> > -                       memset(eq->buf[i], 0, size);
> >                         *(eq->bt_l0 + i) = eq->buf_dma[i];
> >
> >                         eq_buf_cnt++;
> > --
> > 2.7.4
> >