Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 12 Nov 2018 14:37:32 +0100
From:   "joro@8bytes.org" <joro@8bytes.org>
To:     "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
        Wei Wang <wawei@amazon.de>,
        Amadeusz Juskowiak <ajusk@amazon.de>,
        Julian Stecklina <jsteckli@amazon.de>
Subject: Re: [PATCH] svm: Add mutex_lock to protect apic_access_page_done on
 AMD systems
Message-ID: <20181112133731.lwje2hzibd64cvc3@8bytes.org>
References: <20181112122255.128953-1-Suravee.Suthikulpanit@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181112122255.128953-1-Suravee.Suthikulpanit@amd.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 12, 2018 at 12:23:14PM +0000, Suthikulpanit, Suravee wrote:
> From: Wei Wang <wawei@amazon.de>
> 
> There is a race condition when accessing kvm->arch.apic_access_page_done.
> Due to it, x86_set_memory_region will fail when creating the second vcpu
> for a svm guest.
> 
> Add a mutex_lock to serialize the accesses to apic_access_page_done.
> This lock is also used by vmx for the same purpose.
> 
> Signed-off-by: Wei Wang <wawei@amazon.de>
> Signed-off-by: Amadeusz Juskowiak <ajusk@amazon.de>
> Signed-off-by: Julian Stecklina <jsteckli@amazon.de>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

Reviewed-by: Joerg Roedel <jroedel@suse.de>