Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 12 Nov 2018 08:28:54 -0800
From:   "Paul E. McKenney" <paulmck@linux.ibm.com>
To:     Corey Minyard <minyard@acm.org>
Cc:     linux-kernel@vger.kernel.org, mingo@kernel.org,
        jiangshanlai@gmail.com, dipankar@in.ibm.com,
        akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
        josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
        rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
        fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        openipmi-developer@lists.sourceforge.net
Subject: Re: [PATCH tip/core/rcu 10/41] drivers/ipmi: Replace
 synchronize_sched() with synchronize_rcu()
Reply-To: paulmck@linux.ibm.com
References: <20181111194104.GA4787@linux.ibm.com>
 <20181111194410.6368-10-paulmck@linux.ibm.com>
 <16c19493-44b0-18e3-d3cb-4d6c2f9f9f53@acm.org>
 <20181112160425.GJ4170@linux.ibm.com>
 <465ebdbb-188c-c4b8-935b-58205b9f98e5@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <465ebdbb-188c-c4b8-935b-58205b9f98e5@acm.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-Id: <20181112162854.GK4170@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 12, 2018 at 10:15:41AM -0600, Corey Minyard wrote:
> On 11/12/18 10:04 AM, Paul E. McKenney wrote:
> >On Mon, Nov 12, 2018 at 09:38:55AM -0600, Corey Minyard wrote:
> >>On 11/11/18 1:43 PM, Paul E. McKenney wrote:
> >>>Now that synchronize_rcu() waits for preempt-disable regions of code
> >>>as well as RCU read-side critical sections, synchronize_sched() can be
> >>>replaced by synchronize_rcu().  This commit therefore makes this change.
> >>Assuming the above is true, this looks fine to me.
> >>
> >>Acked-by: Corey MInyard <cminyard@mvista.com>
> 
> Dang, that's
> 
> Acked-by: Corey Minyard <cminyard@mvista.com>

Just in time, applied, thank you!  ;-)

> >Thank you!
> >
> >>Or I can take it in my tree, either way.
> >I will carry it unless/until I send it upstream (this coming merge
> >window) or I see it already upstream.
> >
> >So your choice.  ;-)
> 
> Ok, if you don't mind, you can carry it.

Sounds good!

							Thanx, Paul

> Thanks,
> 
> -corey
> 
> 
> >							Thanx, Paul
> >
> >>-corey
> >>
> >>
> >>>Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
> >>>Cc: Corey Minyard <minyard@acm.org>
> >>>Cc: Arnd Bergmann <arnd@arndb.de>
> >>>Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>Cc: <openipmi-developer@lists.sourceforge.net>
> >>>---
> >>>  drivers/char/ipmi/ipmi_si_intf.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>>diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> >>>index 677618e6f1f7..dc8603d34320 100644
> >>>--- a/drivers/char/ipmi/ipmi_si_intf.c
> >>>+++ b/drivers/char/ipmi/ipmi_si_intf.c
> >>>@@ -2187,7 +2187,7 @@ static void shutdown_smi(void *send_info)
> >>>  	 * handlers might have been running before we freed the
> >>>  	 * interrupt.
> >>>  	 */
> >>>-	synchronize_sched();
> >>>+	synchronize_rcu();
> >>>  	/*
> >>>  	 * Timeouts are stopped, now make sure the interrupts are off
> >>
>