Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4304650imu; Mon, 12 Nov 2018 08:53:44 -0800 (PST) X-Google-Smtp-Source: AJdET5c7xuKv49creGyJiAklaWSO/lrhf14xD81mg0HJqSsQDdm3x+Hj/gn6BQDDhOyEJ5fY4+Yl X-Received: by 2002:a63:ba48:: with SMTP id l8mr1460171pgu.72.1542041624454; Mon, 12 Nov 2018 08:53:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542041624; cv=none; d=google.com; s=arc-20160816; b=B9RZMZWt0cnVIXUedsRzFEMLmC27Ooi0nnQWsmqtgqSrEPD0cY9VKul+hzihdeejGO dVHHpcU1/VyYXWul3ocRQiwQak+FyrHaKcQEol7kZBosOU3uMuAx46uli7490UWbrcnc vtpf+2DnViIUVnpji5WFTQTxLh/VEJWk7b+6aWbhe4AX/DXB5oQjzOAzD2SLGqfWaSEv H978dhTaleBgxwPqDLCb01bgZAxG9WXmoje5GoV371rY8Tr8HCNnPlnfNRMUut6lVYYq 9dPo0bKqvcEvsAwuBvk72XWiIhPBh9kQAVt9gm8k8Fs3dEw+x6lIOKIDx479fZ5z+eZC WgIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=PmBUc7TNBRrkSwwluEPm0fffkulB28VdIdp31zvJC/E=; b=OTR3BOcO3d6H0Uy/kxhDUk+aNOCH93H/98xcFAVNBLsPjK6DuV/IyHfZmu7zLGN624 RIpMlTkewOv4DD1QKiOhsyFN9MdQeMLTjOzq+HBuhSILPCq3n9fad7ebCvGaL3a5WHdS relHwOeHPm2vpsre0baEl+zdI1aeG+UQCPH6qxRYhxDjnSvqMTp6nFBN0lB6JHAw8Sp+ +JhP6F4dkaWv1rkJPeetLRwXddhwu+gFQyYY8qoiSiy4uhbbKmKQIX0vRRX5PAVDMpGb OaCEgOAWXOAHCZ0ZS56VXDKK29AauGRA7YRI3k4rD4BpAVW8NhIIvYqK5rV1qbMw/Hm/ owww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12-v6si7405298plb.324.2018.11.12.08.53.29; Mon, 12 Nov 2018 08:53:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730241AbeKMCqg (ORCPT + 99 others); Mon, 12 Nov 2018 21:46:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:41094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbeKMCqf (ORCPT ); Mon, 12 Nov 2018 21:46:35 -0500 Received: from vmware.local.home (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1E1A22419; Mon, 12 Nov 2018 16:52:31 +0000 (UTC) Date: Mon, 12 Nov 2018 11:52:28 -0500 From: Steven Rostedt To: Mathieu Desnoyers Cc: Masami Hiramatsu , Alexander Popov , kernel-hardening , Kees Cook , Jann Horn , Ingo Molnar , Andy Lutomirski , Joerg Roedel , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Zijlstra , Jan Kara , Dan Williams , Masahiro Yamada , x86 , linux-kernel Subject: Re: [PATCH 1/1] stackleak: Disable ftrace for stackleak.c Message-ID: <20181112115228.1c747426@vmware.local.home> In-Reply-To: <97842534.3842.1542034409326.JavaMail.zimbra@efficios.com> References: <1541887530-16610-1-git-send-email-alex.popov@linux.com> <20181110183011.2290fc20@gandalf.local.home> <20181111205351.1874bb1e@vmware.local.home> <20181112115058.39e98750750c91eeb349cfdf@kernel.org> <97842534.3842.1542034409326.JavaMail.zimbra@efficios.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Nov 2018 09:53:29 -0500 (EST) Mathieu Desnoyers wrote: > Just to clarify: AFAIU you guys are recommending to add _both_ a "notrace" > annotation to stackleak_erase() _and_ a NOKPROBE_SYMBOL(stackleak_erase), > so neither function tracing nor kprobes can hook on that function. Correct. -- Steve