Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4623842imu; Mon, 12 Nov 2018 14:15:18 -0800 (PST) X-Google-Smtp-Source: AJdET5dcH+0CPeOlcqH3fgLE6kOlLWXIl3mbUo3BMkhEy3Uq/vtA7O2sAVkA0z3shGCR5W7wApol X-Received: by 2002:a17:902:6b01:: with SMTP id o1-v6mr2603847plk.333.1542060918906; Mon, 12 Nov 2018 14:15:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542060918; cv=none; d=google.com; s=arc-20160816; b=M5GyEVXpVBqfJ1PGLvQYm2s12u53Vmfg9QfDJOfsnCkY2yJCiCiGIeH4bXI+SaXVQX w5T4pkArjnafhId0l8jjJNeEH3pwTN5SWoc2Su+bGLt/wleY3Zholw4x5sY3ngMjJpmF UhRSCH1emvjv3BIdIT9GWHItNgSwaZLrFcH5EUb6FhkT7CEAdeMQeN0VzJw+dHk9IDXx yTYT9HRSIazrnqpeb5DMntxWoOvV4j9S5eGRLRL0I7UZA+f2uslewcuisSaXDAQGockq qPuoAU5QJT/V3vcWK4jSTsx3z+toYvAT9PhD/CNGe0I3A4yIbZ8gN3ZZMVNan+U67luf v5EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=LDfgfP9Q8uMgf1da3eypEdujEmso5JVMI4gfPBHSe5M=; b=Wunb9rkSDpqa+pj5snlugNGxc34BT5XY4IneTiTTNbl8FXzBgOwMc2K3F1/U5R1qk2 NQBD1wk4JaeGxTKgUo+3jAYPosGjSaFJtSTBwX0Ek/iYNQr5L35h91XU4iPkUkEgXsfD bQlrZAQ3Pz+1LaFSB1ER618OiiGCTTxcGB3WkOswCTt67TvUqsVRN7vDczQnavv6DRx5 BQ9upUaaCJu57CpguSBMsYg5Es6UqA/arOmQ3I4BcOC60Jbnb1aIS3fio/W2eHqGxNFs 4dgFeCpb+JWnIQPPRzcgZzyKsEEBI+DFEn/9G6Fpy2S/lkE4+ihBOtn4HyNIQf4key31 oPIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="h0g/saL3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19-v6si19314007pfn.26.2018.11.12.14.15.03; Mon, 12 Nov 2018 14:15:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b="h0g/saL3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730660AbeKMIJ0 (ORCPT + 99 others); Tue, 13 Nov 2018 03:09:26 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:42515 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbeKMIJ0 (ORCPT ); Tue, 13 Nov 2018 03:09:26 -0500 Received: by mail-qk1-f194.google.com with SMTP id m5so16191693qka.9 for ; Mon, 12 Nov 2018 14:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=LDfgfP9Q8uMgf1da3eypEdujEmso5JVMI4gfPBHSe5M=; b=h0g/saL3EdbQX40dLYMJwQndT5XiScXk4zl4S95kuhBSCFGpr1gyOk3/hO4UNban43 WrR7LieE7KYXkzeT/eee4GO69Pv7r/OFj5eMi+q4lXm6ovMlD1bun41olGwH67xrVy9N YmEUluD+H8TngEifAmDIDebyupCfBVtI6CQVKHugoxjuUR6viAPPCOrSNKTbdEMwvfD7 gvz8GnvIJfSmqbU8VIKbhBoey/3My9hHJVDakKGfMoDZ1FMpIgtvBoALySKG+Fh4XQZ5 e8zIGMjQkJ4KMHxItxl+uVUQrHmdY0wOYmGi6yx+u45KONHEOPXaedRCUdiMHb+Ffn5R Qwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=LDfgfP9Q8uMgf1da3eypEdujEmso5JVMI4gfPBHSe5M=; b=ZHw6jnwy50fwk1AG2QZMdRGWcAaEgkGBQPsYg2dTVyBkWrwzH5WFfgvyM8PR03Ox+J wm3FgGca3NduZx1+aPbb/6+8gVBMniB+z6s+1ravT9JbEJyD6zLLMNhNvM815qjM5Nuo zEKsBgPjqHp8ZYGWngnf9HH2xho23KZyIe6mDMkZw8acV8+w6bZI2sl2AdwuHe0xjvld FcTASzHjdYJjTcni9c8stZcX4tQufV9uhAoRXHGT2zpXYuvPLDtiBnQmjLQG08klJw4D KAshsOCCeGNoA8Ir86d2sgp3d6b/gwEXpVRznV8F5NEhZ4/aI4AUSKU6pHACu8HrBAxc d4fw== X-Gm-Message-State: AGRZ1gL5IBZQpCsLfrhTNqYvV5TrSI4ss+YWQBotykDG8V6RS0uTzuqG K5l38lFWWpJ44peWcp5y9DXa+g== X-Received: by 2002:ac8:5314:: with SMTP id t20mr2606646qtn.328.1542060858747; Mon, 12 Nov 2018 14:14:18 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id k38sm10592278qkh.72.2018.11.12.14.14.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Nov 2018 14:14:18 -0800 (PST) Date: Mon, 12 Nov 2018 14:14:14 -0800 From: Jakub Kicinski To: Nathan Chancellor Cc: Alexei Starovoitov , Daniel Borkmann , Quentin Monnet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bpf: Remove unused variable in nsim_bpf Message-ID: <20181112141414.4dacb194@cakuba.netronome.com> In-Reply-To: <20181112221042.11160-1-natechancellor@gmail.com> References: <20181112221042.11160-1-natechancellor@gmail.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Nov 2018 15:10:42 -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/netdevsim/bpf.c:557:30: error: unused variable 'state' > [-Werror,-Wunused-variable] > struct nsim_bpf_bound_prog *state; > ^ > 1 error generated. > > The declaration should have been removed in commit b07ade27e933 ("bpf: > pass translate() as a callback and remove its ndo_bpf subcommand"). > > Signed-off-by: Nathan Chancellor Acked-by: Jakub Kicinski