Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4744334imu; Mon, 12 Nov 2018 16:41:09 -0800 (PST) X-Google-Smtp-Source: AJdET5cuedizWl9cphmCI2qhoZQxQl5ubjMjhUksrLKDZmaxmw9zKjTZxE5fn0Cx/Jr2AfrkfZYL X-Received: by 2002:a62:4251:: with SMTP id p78-v6mr3001336pfa.72.1542069669473; Mon, 12 Nov 2018 16:41:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542069669; cv=none; d=google.com; s=arc-20160816; b=MQx992CvRK4Qw8mqKJ7KaiQdmsvzBNIjzIdeo2KPqTAtgPbr70BLBHaAEccIOHDAuJ g/6F/sg5B+sVZs1eC8vsnD0isxe4TikSxvbsa3tKDTbOpgALejkQMBrH9Bo6l5xfJ9qi swSfpYW2KOwiFToDwAHNhQq72RvEBgs7Qjew8ByBXpVwNNYgbkwPtSuXLYG7QIWkXo7n umdtrhsc2DXDFM2hVvRvswr/zs7b93bH0fyF8233cfTHAO/5uDt9vN4/LPPjC6h7JIoi QWnTKbp9RR0jb0o8Ngaf3jA1IGYr7UzzvYZg/3OFSP7X20QQwFpGcLVVr4M84dnOOQH6 8s9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=pumKUuyvnWVyOwlk9Ec9y1nH507cO7nNGsr4eIT4Dgc=; b=hgNNdmyP7ODQ6nEaWucDfOswMgHVMpyz2skHip2PX4UBdF+peevH/FtZz4drqY4YnQ ETXZolPTsHjqtIYryGFsuQ0sH8izi0BeHWWp5jNAwOP650Q0KCrpUgiPFPbYQcwgJNkp zSkX4CGeF1lbrFC/FcTszNN4s8fmzkybyrRrU+bD99B8Iah63ZVI8zJ0un8iPYz6Z4M1 5brQ9Vgy2gWbNDMWqU+3wbP+xI7xymuERHi5vtXFxUf+gmEW5ftghOWgskcEXJx9oXfi lOwhF+oy2rz8Z/eNfJMRw1AQuxbz+Q4TeGKKpi5BcClhgfoIs43k0U6yumV39HENHI8j +6nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=SWhOKvPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62-v6si20165404plc.282.2018.11.12.16.40.53; Mon, 12 Nov 2018 16:41:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=SWhOKvPO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730532AbeKMKfq (ORCPT + 99 others); Tue, 13 Nov 2018 05:35:46 -0500 Received: from smtprelay2.synopsys.com ([198.182.60.111]:37356 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725991AbeKMKfq (ORCPT ); Tue, 13 Nov 2018 05:35:46 -0500 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 88F3010C0811; Mon, 12 Nov 2018 16:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1542069611; bh=q5BH5bbMEAmmOtG3URRnuehrRFvuNoP6LbnP4lk8AFQ=; h=From:To:CC:Subject:Date:References:From; b=SWhOKvPOV5l6Wsc5WmqLsslw9aE6qjCrBMCChvbBnSDN2vFJnd1H9lQrU1psrllu7 tpPGIrc7HZJkYh+VESjspfzn7OPZnFA9OLNxyNUwbtbTVyZhI/FTJeRNLsZs5FqGxq MUV+IOctvbEGCEjO5QKpMwK4+0UbJVMMIRH4nc3hP2cAJxtxEfZM08IwQtV3ib4Jwb 6cwJ9fZh6ZHRjXrYAGa1Vtza1iF5p7CliioU+7iIAsP3trhtfJFY55+sTKHiHWLvbz kFxzjiLO62yU/KFttCBjtd0g3gCA2rXT0w+hdPB0bEAZB5kR+exeG0oRhQ3grybeeV vxaNQj2zA3fLw== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) by mailhost.synopsys.com (Postfix) with ESMTP id 698A13A78; Mon, 12 Nov 2018 16:40:09 -0800 (PST) Received: from us01wembx1.internal.synopsys.com ([169.254.1.228]) by us01wehtc1.internal.synopsys.com ([::1]) with mapi id 14.03.0415.000; Mon, 12 Nov 2018 16:40:09 -0800 From: Vineet Gupta To: Florian Fainelli , Vineet Gupta , "linux-kernel@vger.kernel.org" CC: Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Andrew Morton , "Marc Zyngier" , Russell King , Andrey Ryabinin , Andrey Konovalov , Masahiro Yamada , Robin Murphy , Laura Abbott , Stefan Agner , Johannes Weiner , "Greg Hackmann" , Kristina Martsenko , CHANDAN VN , "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" , "rppt@linux.ibm.com" , "linux@armlinux.org.uk" , "green.hu@gmail.com" , "deanbo422@gmail.com" , "gxt@pku.edu.cn" , "ard.biesheuvel@linaro.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH v4 6/6] arch: Move initrd= parsing into do_mounts_initrd.c Thread-Topic: [PATCH v4 6/6] arch: Move initrd= parsing into do_mounts_initrd.c Thread-Index: AQHUdVsG6LD9rqw+mkiEXoDtFpj/vg== Date: Tue, 13 Nov 2018 00:40:08 +0000 Message-ID: References: <20181105225431.24485-1-f.fainelli@gmail.com> <20181105225431.24485-7-f.fainelli@gmail.com> <05f56763-1530-933d-2ce3-3653ad4c685f@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/18 4:38 PM, Florian Fainelli wrote:=0A= >>> #ifdef CONFIG_BLK_DEV_INITRD=0A= >>> - if (initrd_start)=0A= >>> - memblock_reserve(__pa(initrd_start), initrd_end - initrd_start);=0A= >>> + if (phys_initrd_size) {=0A= >>> + memblock_reserve(phys_initrd_start, phys_initrd_size);=0A= >>> + initrd_start =3D (unsigned long)__va(phys_initrd_start);=0A= >>> + initrd_end =3D initrd_start + phys_initrd_size;=0A= >>> + }=0A= >>> #endif=0A= >> The common code now uses phys_initrd*, and you also use the same in ARC = code, do=0A= >> we still need the initrd_* setting here ?=0A= >> ARC semantics was using them as PA anyways.=0A= > Yes, the generic initrd code expects initrd_start/end to be virtual=0A= > addresses, which we now directly derive from phys_initrd_start, that=0A= > should really be equivalent.=0A= =0A= So we can skip this explicit setting above - ARC arch code doesn't access t= he virt=0A= initrd_start=0A=