Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4798193imu; Mon, 12 Nov 2018 17:49:56 -0800 (PST) X-Google-Smtp-Source: AJdET5fr7BDDtTsjq8dYgn9L88RUVk14tuWXWAbZl9wdtBMXHzyExjtlI7MTOL6WHuM4SXzVucrZ X-Received: by 2002:a62:8c93:: with SMTP id m141-v6mr3130616pfd.239.1542073796529; Mon, 12 Nov 2018 17:49:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542073796; cv=none; d=google.com; s=arc-20160816; b=r4Jh2RErQjg+iyTGw9wdRv/r//ct1Doy1XWASbSSZrriJjVlvtt9oohUx8LeAO2mY4 CJI+KY56wxw7jIkGoala6xXOHNdT74l5kfClGLG8woRYLTSJgEJogu9eWmueYG9j2ubl sNIxa7oHfP4LgADCH81A6S7rYWPzkRWrVq1IgZ04j4yYqfsIOJ5l9FzNY6rxA5CYfPQj ZKbQ+0foeVdmqJwHAt+TuE3F1j7UoddJ9PG/kzp1XczQbzV2K63I7xLVsT6YkoKF4PJE zl82IHBzAPCAkw87S7yCXTzhT8d22DlLC+39tBAVbbQjK3UpDB+xCrylgTkCDzVOwr6R dmOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=1iI6TsrT2IcsF07PAqNVwK5tKOkzbhs6TWXEP+NvCII=; b=nSr+1Uw6YRPBUbQ0JwOakpSKsQpj3c+SgfiEnv3aWESXvgvz1oKZ+l/PIAh5JGdD0X 0KMtNxKuDxQo/YpEzmR+tQ4KamH5geDKv7SrMXurKBNDr3FU2q44K6Z4rI2+ckkBc70e ONM2+Q8FZ6xGyERw/yj5kqVVT/c33oGI6Q8B2YfrV81JwM/5C9B+yCYFHYusAKM8NfS6 jmNG5yOB/IFjpyJ5aOYpTCcbHPTEpZ+IF2JsYklK5vvfJkvj3iiETL2OuAo+LQmgm2IH 70p19bRaLVAeAYCLNq+PdpZucW2H569xG3xN9zQHzXe/FTkPqvzUob2FdcErcARSUzLa O1Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d8si9831341pgh.505.2018.11.12.17.49.41; Mon, 12 Nov 2018 17:49:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728207AbeKMLpJ (ORCPT + 99 others); Tue, 13 Nov 2018 06:45:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:45796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbeKMLpJ (ORCPT ); Tue, 13 Nov 2018 06:45:09 -0500 Received: from vmware.local.home (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99182223C8; Tue, 13 Nov 2018 01:49:20 +0000 (UTC) Date: Mon, 12 Nov 2018 20:49:18 -0500 From: Steven Rostedt To: Alexander Popov Cc: kernel-hardening@lists.openwall.com, Kees Cook , Jann Horn , Ingo Molnar , Andy Lutomirski , Joerg Roedel , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Zijlstra , Jan Kara , Mathieu Desnoyers , Dan Williams , Masahiro Yamada , Masami Hiramatsu , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] stackleak: Disable function tracing and kprobes for stackleak_erase() Message-ID: <20181112204918.2ba39252@vmware.local.home> In-Reply-To: <1542056928-10917-1-git-send-email-alex.popov@linux.com> References: <1542056928-10917-1-git-send-email-alex.popov@linux.com> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Nov 2018 00:08:48 +0300 Alexander Popov wrote: > The stackleak_erase() function is called on the trampoline stack at the end > of syscall. This stack is not big enough for ftrace and kprobes operations, > e.g. it can be exhausted if we use kprobe_events for stackleak_erase(). > > So let's disable function tracing and kprobes for stackleak_erase(). > > Reported-by: kernel test robot > Signed-off-by: Alexander Popov > Reviewed-by: Steven Rostedt (VMware) -- Steve