Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V5 1/6] blk-mq: make __blk_mq_issue_directly be able to
 accept NULL cookie pointer
To:     Jens Axboe <axboe@kernel.dk>
Cc:     ming.lei@redhat.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1542014609-1769-1-git-send-email-jianchao.w.wang@oracle.com>
 <1542014609-1769-2-git-send-email-jianchao.w.wang@oracle.com>
 <01bd2f70-cc78-9bfd-aa30-b73c44eaa9bb@kernel.dk>
From:   "jianchao.wang" <jianchao.w.wang@oracle.com>
Message-ID: <87aa2951-54ce-e979-790f-8f1c18d78f14@oracle.com>
Date:   Tue, 13 Nov 2018 10:41:40 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <01bd2f70-cc78-9bfd-aa30-b73c44eaa9bb@kernel.dk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jens

On 11/13/18 1:10 AM, Jens Axboe wrote:
> On 11/12/18 2:23 AM, Jianchao Wang wrote:
>> Make __blk_mq_issue_directly be able to accept a NULL cookie pointer
>> and remove the dummy unused_cookie in blk_mq_request_issue_directly.
> 
> What's the reasoning behind this? Seems faster to store the cookie
> always, instead of introducing a branch to the hot path.
> 

It is to make the interface more usable then we needn't input a dummy cookie
pointer but just a NULL if we don't use the return cookie.

If the introduced branch in hot path is concerned, I could drop this one.

Thanks
Jianchao