Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4930590imu; Mon, 12 Nov 2018 21:05:08 -0800 (PST) X-Google-Smtp-Source: AJdET5etlIKp/UOVfSG5KBusuPMjRfjW62KsoWFktzPuZOuqc4xMwmmjbsdup5m7jjXHqUKjIDTg X-Received: by 2002:a63:fb0b:: with SMTP id o11mr3403626pgh.211.1542085508147; Mon, 12 Nov 2018 21:05:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542085508; cv=none; d=google.com; s=arc-20160816; b=REuL0Zzcd5WmnI/ej29aQ7S1e5IFohF0H+Nb66w4RTLFQ89eH25jQSuLgpr//nDzVf T/Z5Je9feOgY23SgjtBoZYpdDVToBnHgul9Ae4kN67oGjx2HJ5wacxIHWjHcapUZJ4ge Z8dQfO7qEz75TDohP9LGsgUJTnbI+XDAjU7bGtX95iXirrT7JXO73RW4B3F9wjn0LSxt BbnAQZA5NVY6s/BVYPzrF9mPY9jz0jP2uehs8wKvlaly5n0kSAgeJ2o0YGziHn+mdYZb q9H02/qlFWR4fMyJ+CKm7BZkTN1+c2tUM8Kg36exlQx/qW5GSbU0WqTsWnoOyrh250OS tImQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=r4tG9JzDF2ShA70v9mVY8EwkDIIck5L6X9o/quZcwEQ=; b=W01fm/d4a6v1Mm0mRXSLDltZmdiH/GBWpl+Mc2dTEZdCKs+DQELohilVIGGDyjOga2 P7e2B4o6m7A1fSX7qmNA3uRYsUUrpA+m0gj+65liOkI4Wz9llkT7p/1/RzNNNWevpGXy TGEqdIfr1TrO7quzA3N3BxPAZTFTn3VAleo17AO/qfVMjPBYYVY40hB6nR6/T8mlo6oX 5uoP0zals1z6y+SrROTgUNXOikFMPSyjV9ozO7Ypad+a6ocOs2WuTYt1F0qgjhovqt6s M54+XhTfWYunnGYOyKFAZoS/cUPYeglnP9NiV3XArHn+naEgOQt6KgMFoz8ZjxxjcUEE CcWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uCbCeWPr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m38si18933123pgl.125.2018.11.12.21.04.52; Mon, 12 Nov 2018 21:05:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uCbCeWPr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730800AbeKMO7C (ORCPT + 99 others); Tue, 13 Nov 2018 09:59:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:45436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726111AbeKMO7B (ORCPT ); Tue, 13 Nov 2018 09:59:01 -0500 Received: from localhost (unknown [64.114.255.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F224920817; Tue, 13 Nov 2018 05:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1542085361; bh=kfgSEg80hSw6L+6zKKxwF+SG2m0X6DrimMnxrBJP9K8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uCbCeWPrUbMg2INXAk36+TLO0/VxfMj8lv9cwwnV1gIdVGuv/gRDeL9NwaVoctlI3 mBmqZyTyBlh3jRxkSYWKlkPGhR4ofrEDekQKLN/iBVIbwbpfXXzMu257pGB6nxkJYq H+QGRvlSsb0yRISggPyOg9tGi3g2ZHRkLUsIE1O0= Date: Mon, 12 Nov 2018 23:02:40 -0600 From: Bjorn Helgaas To: Alex_Gagniuc@Dellteam.com Cc: oohall@gmail.com, gregkh@linuxfoundation.org, keith.busch@intel.com, mr.nuke.me@gmail.com, linux-pci@vger.kernel.org, Austin.Bolen@dell.com, Shyam.Iyer@dell.com, linux-kernel@vger.kernel.org, jonathan.derrick@intel.com, lukas@wunner.de, ruscur@russell.cc, sbobroff@linux.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Message-ID: <20181113050240.GA182139@google.com> References: <20181107234257.GC41183@google.com> <20181108200855.GE41183@google.com> <20181108220117.GA11466@kroah.com> <20181108223258.GD2932@localhost.localdomain> <20181108224255.GA20619@kroah.com> <20d68e586fff4dcca5616d5056f6fc21@ausx13mps321.AMER.DELL.COM> <20181108225109.GA3023@kroah.com> <16bf9d14bc5f4a90b2b88dd2eb165186@ausx13mps321.AMER.DELL.COM> <5da8d8aa9f3818af649b1ac547bc4e6062626ddf.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+cc Jon, for related VMD firmware-first error enable issue] On Mon, Nov 12, 2018 at 08:05:41PM +0000, Alex_Gagniuc@Dellteam.com wrote: > On 11/11/2018 11:50 PM, Oliver O'Halloran wrote: > > On Thu, 2018-11-08 at 23:06 +0000, Alex_Gagniuc@Dellteam.com wrote: > >> But it's not the firmware that crashes. It's linux as a result of a > >> fatal error message from the firmware. And we can't fix that because FFS > >> handling requires that the system reboots [1]. > > > > Do we know the exact circumsances that result in firmware requesting a > > reboot? If it happen on any PCIe error I don't see what we can do to > > prevent that beyond masking UEs entirely (are we even allowed to do > > that on FFS systems?). > > Pull a drive out at an angle, push two drives in at the same time, pull > out a drive really slow. If an error is even reported to the OS depends > on PD state, and proprietary mechanisms and logic in the HW and FW. OS > is not supposed to mask errors (touch AER bits) on FFS. PD? Do you think Linux observes the rule about not touching AER bits on FFS? I'm not sure it does. I'm not even sure what section of the spec is relevant. The whole issue of firmware-first, the mechanism by which firmware gets control, the System Error enables in Root Port Root Control registers, etc., is very murky to me. Jon has a sort of similar issue with VMD where he needs to leave System Errors enabled instead of disabling them as we currently do. Bjorn [1] https://lore.kernel.org/linux-pci/20181029210651.GB13681@bhelgaas-glaptop.roam.corp.google.com