Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262126AbUAIQ3y (ORCPT ); Fri, 9 Jan 2004 11:29:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261953AbUAIQ3y (ORCPT ); Fri, 9 Jan 2004 11:29:54 -0500 Received: from nat-pool-bos.redhat.com ([66.187.230.200]:14461 "EHLO thoron.boston.redhat.com") by vger.kernel.org with ESMTP id S261889AbUAIQ3w (ORCPT ); Fri, 9 Jan 2004 11:29:52 -0500 Date: Fri, 9 Jan 2004 11:29:50 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Raj cc: Joilnen Leite , , , Subject: Re: about ipmr In-Reply-To: <3FFE4D23.5030400@toughguy.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 488 Lines: 22 On Fri, 9 Jan 2004, Raj wrote: > I would prefer this way of checking the NULL > > That would be more consistent with ip_gre.c and ipip.c > > any suggestions ? Yes, this is much better form. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/