Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 13 Nov 2018 11:15:26 +0100
From:   Cornelia Huck <cohuck@redhat.com>
To:     Paolo Cretaro <paolocretaro@gmail.com>
Cc:     kwankhede@nvidia.com, alex.williamson@redhat.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio/mdev: add static modifier to
 add_mdev_supported_type
Message-ID: <20181113111526.73e8c65a.cohuck@redhat.com>
In-Reply-To: <20181113084543.9543-1-paolocretaro@gmail.com>
References: <20181113084543.9543-1-paolocretaro@gmail.com>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 13 Nov 2018 09:45:43 +0100
Paolo Cretaro <paolocretaro@gmail.com> wrote:

> Set add_mdev_supported_type as static since it is only used within
> mdev_sysfs.c.
> This fixes -Wmissing-prototypes gcc warning.
> 
> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> ---
>  drivers/vfio/mdev/mdev_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index 249472f05509..ce5dd219f2c8 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -92,8 +92,8 @@ static struct kobj_type mdev_type_ktype = {
>  	.release = mdev_type_release,
>  };
>  
> -struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> -					  struct attribute_group *group)
> +static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent,
> +						 struct attribute_group *group)
>  {
>  	struct mdev_type *type;
>  	int ret;

Reviewed-by: Cornelia Huck <cohuck@redhat.com>