Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] fork: Fix two -Wmissing-prototypes warnings
To:     Yi Wang <wang.yi59@zte.com.cn>, tglx@linutronix.de
Cc:     mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
        keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
        konrad.wilk@oracle.com, dhowells@redhat.com,
        linux-kernel@vger.kernel.org, riel@redhat.com,
        viro@ZenIV.linux.org.uk, zhong.weidong@zte.com.cn
References: <1542093988-42041-1-git-send-email-wang.yi59@zte.com.cn>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
Message-ID: <cba61508-3e50-f8df-d75a-37d2e41a17c4@rasmusvillemoes.dk>
Date:   Tue, 13 Nov 2018 11:26:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <1542093988-42041-1-git-send-email-wang.yi59@zte.com.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 13/11/2018 08.26, Yi Wang wrote:
> We get two warning when building kernel with W=1:
> kernel/fork.c:167:13: warning: no previous prototype for ‘arch_release_thread_stack’ [-Wmissing-prototypes]
> kernel/fork.c:779:13: warning: no previous prototype for ‘fork_init’ [-Wmissing-prototypes]

I think you should also remove the "manual" declarations from the .c
files that call the function, in this case fork_init() in  init/main.c;
otherwise there's no guarantee that those translation units actually
include the header that contain the proper declaration.

arch_release_thread_stack can probably just be removed completely after
the recent arch cleanup, since bb9d81264 (arch: remove tile port) no
arch seems to implement it.

Rasmus