Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5425023imu; Tue, 13 Nov 2018 06:27:33 -0800 (PST) X-Google-Smtp-Source: AJdET5c5xsWQBj29QiLyyySzmM9rXrDwe9t1yLA9gmDIo9Ko1sz7zk6TT8r7oFARrx70bcnQGiod X-Received: by 2002:a63:5357:: with SMTP id t23-v6mr5049809pgl.40.1542119253175; Tue, 13 Nov 2018 06:27:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542119253; cv=none; d=google.com; s=arc-20160816; b=HNgQOxLx/9MNbK36ItfVF7m9XST6xSHO5WHNZ0ycA4hJiwiwgH2wOGnVgDaRZnJGzP zBJuyG9I9OqfYzRfdcmapbM9v0tuOdzSJYnjX6lGoA2js8YPyvZ8IXlJp00hFTcy7suO aPGvGEbZOAa8GVuZumAITED+xjFeesS4dyxzYP89UL7KkBGMXkyjO91i5RtwCsA+BCTu 5gXYy+R5b8nKuhngl0iBxF7LQx96FEUTBno6e6I8s9K9unbbatPEA/CY7ZssYKj6Yqmq 45xGpyuYMcyVA6sCJKliWL0Oqou6gh2EJ1FVseNb70b3yFtyRcUkxc9sGO7AF2/SF7lM FVNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:user-agent:in-reply-to:references:cc:to:subject:from :date; bh=TDDLkLhLi4W/U+Rx6NT4E5GkgYNpigF6uOPE5MWbjhY=; b=jV95kI1V8vqo5TO+EvJWnbg6MydgdyDxYiFrPO4iC9Zk2n50FP0h/oTXQ82e3Hzx59 8T+HVzEODQMKd38x7NAXUPbMGq8MmFTg1ei6HJ7Io+g3gaGcX31oAnoQGej6Qky7sNqj Y2tGVQK5Q3G/gOc118u11P3bA/bc8LS+SmpGeOleLyNXfuTjBK47cQ4hZ0pHyRxfNneM EqGkY+aFxb6bOdFEgTZ+szfM/ybwm0iGniG9kJMJ3QaF9wH5jAF5uew+2Ol+cR7BtVH7 GFxc+3GmR+ZRS995Bz7y3aej9xdZ7GqpG+ezy++5M1hCbvyoQ9Jp7f6+wwdRw9nWdsCV iBqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si20947885plu.228.2018.11.13.06.27.15; Tue, 13 Nov 2018 06:27:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387402AbeKNAYk convert rfc822-to-8bit (ORCPT + 99 others); Tue, 13 Nov 2018 19:24:40 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60538 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731109AbeKNAYk (ORCPT ); Tue, 13 Nov 2018 19:24:40 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wADEJBbd114862 for ; Tue, 13 Nov 2018 09:26:16 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2nr01ws1kg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 13 Nov 2018 09:26:15 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Nov 2018 14:26:14 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 13 Nov 2018 14:26:10 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wADEQ95f55378174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Nov 2018 14:26:09 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2CA67A4051; Tue, 13 Nov 2018 14:26:09 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BE69A4040; Tue, 13 Nov 2018 14:26:08 +0000 (GMT) Received: from localhost (unknown [9.124.215.178]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 13 Nov 2018 14:26:08 +0000 (GMT) Date: Tue, 13 Nov 2018 19:56:07 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH -next] powerpc64/ftrace: Drop pointless static qualifier in is_b_op() To: Benjamin Herrenschmidt , Greg Kroah-Hartman , Kate Stewart , Michael Ellerman , Nicholas Piggin , Paul Mackerras , "Steven Rostedt (VMware)" , YueHaibing Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <1542117416-52357-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1542117416-52357-1-git-send-email-yuehaibing@huawei.com> User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 18111314-0008-0000-0000-000002922D03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18111314-0009-0000-0000-000021FC3E09 Message-Id: <1542119044.hos5gz4vi8.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-13_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811130132 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing wrote: > There is no need to have the 'intoffset' variable static since new value > always be assigned before use it. > > Signed-off-by: YueHaibing > --- > arch/powerpc/kernel/trace/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/trace/ftrace.c b/arch/powerpc/kernel/trace/ftrace.c > index 4bf051d..65248d4 100644 > --- a/arch/powerpc/kernel/trace/ftrace.c > +++ b/arch/powerpc/kernel/trace/ftrace.c > @@ -107,7 +107,7 @@ static int is_b_op(unsigned int op) > > static unsigned long find_bl_target(unsigned long ip, unsigned int op) > { > - static int offset; > + int offset; That seems to go all the way back to the original commit by Steven. Good catch. Reviewed-by: Naveen N. Rao - Naveen