Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Denis V. Lunev" <den@openvz.org>
To:     linux-kernel@vger.kernel.org
Cc:     "Denis V. Lunev" <den@openvz.org>,
        Christine Caulfield <ccaulfie@redhat.com>,
        David Teigland <teigland@redhat.com>,
        Konstantin Khorenko <khorenko@virtuozzo.com>,
        cluster-devel@redhat.com
Subject: [PATCH 1/1] dlm: fix possible call to kfree() for non-initialized pointer
Date:   Tue, 13 Nov 2018 20:39:50 +0300
Message-Id: <20181113173950.7165-1-den@openvz.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Technically dlm_config_nodes() could return error and keep nodes
uninitialized. After that on the fail path of we'll call kfree()
for that uninitialized value.

The patch is simple - we should just initialize nodes with NULL.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Christine Caulfield <ccaulfie@redhat.com>
CC: David Teigland <teigland@redhat.com>
CC: Konstantin Khorenko <khorenko@virtuozzo.com>
CC: cluster-devel@redhat.com
---
 fs/dlm/member.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dlm/member.c b/fs/dlm/member.c
index 3fda3832cf6a..2ce33088f8bb 100644
--- a/fs/dlm/member.c
+++ b/fs/dlm/member.c
@@ -671,7 +671,7 @@ int dlm_ls_stop(struct dlm_ls *ls)
 int dlm_ls_start(struct dlm_ls *ls)
 {
 	struct dlm_recover *rv, *rv_old;
-	struct dlm_config_node *nodes;
+	struct dlm_config_node *nodes = NULL;
 	int error, count;
 
 	rv = kzalloc(sizeof(*rv), GFP_NOFS);
-- 
2.17.1