Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6398280imu; Wed, 14 Nov 2018 00:25:43 -0800 (PST) X-Google-Smtp-Source: AJdET5fT4vzaa1oTRHvbetMvB0+CWkXkDlrs/6WBiUronomn2vpbTfbQkuJIJ79khHmWML64u42f X-Received: by 2002:a62:47d9:: with SMTP id p86mr523853pfi.95.1542183943424; Wed, 14 Nov 2018 00:25:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542183943; cv=none; d=google.com; s=arc-20160816; b=BBlziXlBfk1NDZo2LF6USp4iVVLu0wW4s+BNjUgHAW2LFiPbgyCabM/YqTYwnXRMPD Ukrf9VXsYpnSkcaCT3qkYIS20DVrIcFnyfBMsefs7MC6vw0DONGzbpVsQmXwI3vAUEtm uaPGwsssBKJOsmTP0KvetFFA2h2Q/WjO5k9tTfl3FRPhBfCIXPgOp/TkAYdsrTWXvzUQ xO8DZ43imxb6DsEXfPskGhl9HcZQg1VmcSPB/fiLcFAxo0G189p4EiurVnRsnl6XHIhM F34KobcNxkISznvNeO+hAfC0nAy8PXDQkx97aHhUVvfCIXYWzZSP/oI92rf4AXbhCsUk xeFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k2PN9Oa8YSIvjJVRt3mNzWxL4HQYVzsgYlk0h0MWqTE=; b=F4fFAd6R/D9FODui7HpsaEj1Ho/VVIqRhFZV88wKbtuTTnFdgZ95DpN6ijKlF4JQ2U wmrrZ/TqWrHIp65rU+O0H8Kdm9eIKWKlEnopAgO6cL4zjTZSPZCIV2yfGzpQgCWZRngk AXvGkdwjTDfSxPFsqMWbBm4EmXIbB3nfNVzQFi79DfdA4fYP0FjCIlKqaMWk5O5PnKBA kyLkMZHNH76vuN3imt0g2Vud9XNlhVUAzrGlhj9j/sqpWjyJl6kjYFDYnMomBAYYF+5I e4BnB4P99FSP3U2n5An7/Kzi4VH611Ns7ESmy9uXOlJttfMBFlPRdo9TU+kC98z7JwKI 8Cdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pOLfihGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x74si410871pfe.23.2018.11.14.00.25.28; Wed, 14 Nov 2018 00:25:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pOLfihGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732929AbeKNS0p (ORCPT + 99 others); Wed, 14 Nov 2018 13:26:45 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:49880 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732891AbeKNS0o (ORCPT ); Wed, 14 Nov 2018 13:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=k2PN9Oa8YSIvjJVRt3mNzWxL4HQYVzsgYlk0h0MWqTE=; b=pOLfihGiHCs6K+Lok6Fb6Er5Vq ZGkVaVy4A23W0HzSF+rfRnDt3vNd+f8arpEEN5rKsUm1xPugb/ju1c/nE/XmoVi2P/tdeOFSV/e40 Xc5n/3R0c1ozaCtVqWS+ZEgKQFB8yZfuwO+A1t5jBslTD/94pkbNh7BuoHNi6aiZFSaeEzcObxGBl +ezwjHJ1zGQCPGX1cx/UJ6eJpDUSaKZZwdXP3f/h6HpcKwQV8fMg/lSbLLMi+hIXF5HQsNgwGbpPU JCGAmPHk66BWsgAlj++QBK/KcugEmX8ZTfxCkewt7Dwjru2mXCMDpmVzeYt3To7sje3VKuZFGhAT1 Jj2zJBzw==; Received: from 089144211136.atnat0020.highway.a1.net ([89.144.211.136] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMqT2-0004yA-Jz; Wed, 14 Nov 2018 08:24:09 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 19/34] cxl: drop the dma_set_mask callback from vphb Date: Wed, 14 Nov 2018 09:22:59 +0100 Message-Id: <20181114082314.8965-20-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114082314.8965-1-hch@lst.de> References: <20181114082314.8965-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CXL code never even looks at the dma mask, so there is no good reason for this sanity check. Remove it because it gets in the way of the dma ops refactoring. Signed-off-by: Christoph Hellwig --- drivers/misc/cxl/vphb.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index 7908633d9204..49da2f744bbf 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -11,17 +11,6 @@ #include #include "cxl.h" -static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask) -{ - if (dma_mask < DMA_BIT_MASK(64)) { - pr_info("%s only 64bit DMA supported on CXL", __func__); - return -EIO; - } - - *(pdev->dev.dma_mask) = dma_mask; - return 0; -} - static int cxl_pci_probe_mode(struct pci_bus *bus) { return PCI_PROBE_NORMAL; @@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops = .reset_secondary_bus = cxl_pci_reset_secondary_bus, .setup_msi_irqs = cxl_setup_msi_irqs, .teardown_msi_irqs = cxl_teardown_msi_irqs, - .dma_set_mask = cxl_dma_set_mask, }; int cxl_pci_vphb_add(struct cxl_afu *afu) -- 2.19.1