Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6398967imu; Wed, 14 Nov 2018 00:26:41 -0800 (PST) X-Google-Smtp-Source: AJdET5fpxa2OY1RM1IMMyFZQ7+LWmQuna11zbEgKPjJ8s5yUh6uOWWgNJmYhu2OwzpGc3JJUFeWE X-Received: by 2002:a62:2803:: with SMTP id o3-v6mr997881pfo.57.1542184001016; Wed, 14 Nov 2018 00:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542184000; cv=none; d=google.com; s=arc-20160816; b=dm/uWsoVa/6efbdgqPpyw56WDisyt7JgXnuzlBcsxSgo2Q46Ua+qqxzqorKLJ69WiD jsv1GDi+QHrnJIEiyTaJ1kQ/pJXjC1fyOAJ8c88mFJtxPLdNyworov/EQqa94ywaa4/a vcYsZtz6Qzy/5shUtNm/rd66vbv6U5Wn3zodEhVJ5OACtoxGaWup0mwyDHBYu2GhKQ2Z 9BkuKjG4Xuj9Ln1GJYczj9Q5F/pPK5O2iMkgZ5UL1idl8CSJvCTZl4veA/XdtXenq022 xFWw9rWuLVy7xSQw4QDGEqsHC8mIH87MZ7wGMaRVhaWmTH99YXfqtJSA+IvRJSapitKb 6UVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=viEKh4BP6N6rz2lADj2u/mOfweh0bRNAdHsJIfS2hmY=; b=C+fJBTM3hLRdnuBrLd8sjjhf+NmXSMzI8d/MwXMUpdHx5EvV3gDZeeiVR4ezoWYkDz iJGZNmVodW69CexoiAgAOS24gr00CbYIJXL71IzMImD3iJ+te8Ar6UQPv3MXFW9T264/ IKNOLBCtAam5oXsFWpUHxOKqggymBPbJ+Rol4xGnTmOawGl6rc2qJ6r50SjXvPLj31x0 y25RVT221UZK9mGufH05SfJ/39wXxbor2Da5fdtp2XWCVSrFP7b8koWiNyKbXzoOMOLL +cRoPLQxRCRrRPP7aAfQ23X7Hor+qNXWR87ZC5SJM4JPMGr2nSoe6OKq8VYDMdzBru4C xepQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cQ9GYtD3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17-v6si24275791pfn.176.2018.11.14.00.26.26; Wed, 14 Nov 2018 00:26:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cQ9GYtD3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733079AbeKNS1J (ORCPT + 99 others); Wed, 14 Nov 2018 13:27:09 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:50146 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733063AbeKNS1I (ORCPT ); Wed, 14 Nov 2018 13:27:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=viEKh4BP6N6rz2lADj2u/mOfweh0bRNAdHsJIfS2hmY=; b=cQ9GYtD3RVVBHD8f/Wxz4OhAT5 rVGlSKVVdgFMJJulJOvhqgBawoY541vvTthVTpDDgeYkDPlZAf2O3HydL9jtIz0RtQjyIClMG/s8I 3BajA/KnfPZXPZ5sQTY7SCYvCur+NFCoDGN4gSfUVvD0ZCcfRa091LGJaGHPQmu65X4fcez5ilDxv 78n9XAnOUJGjlsCieOJz8nRSdKvSuCE+ucQ2MjC+SDlH36nmbKhRrCLjkr+yO5Eq3US9u+5KFIAR2 2plIBS6g4Zf0vcZ4pL2WmnLEEHWgwWBB2oFIQlWmfhCkuJa2WaQcyzDjEu4zc/58TPwdhIGkO6MYk QpBDb/Xw==; Received: from 089144211136.atnat0020.highway.a1.net ([89.144.211.136] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMqTR-00055a-Db; Wed, 14 Nov 2018 08:24:33 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 28/34] dma-mapping, powerpc: simplify the arch dma_set_mask override Date: Wed, 14 Nov 2018 09:23:08 +0100 Message-Id: <20181114082314.8965-29-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114082314.8965-1-hch@lst.de> References: <20181114082314.8965-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of letting the architecture supply all of dma_set_mask just give it an additional hook selected by Kconfig. Signed-off-by: Christoph Hellwig --- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/dma-mapping.h | 3 --- arch/powerpc/kernel/dma-swiotlb.c | 8 ++++++++ arch/powerpc/kernel/dma.c | 12 ------------ arch/powerpc/sysdev/fsl_pci.c | 4 ---- include/linux/dma-mapping.h | 11 ++++++++--- kernel/dma/Kconfig | 3 +++ 7 files changed, 20 insertions(+), 22 deletions(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 2d4a19bc8023..4f03997ad54a 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -126,6 +126,7 @@ config PPC # Please keep this list sorted alphabetically. # select ARCH_HAS_DEVMEM_IS_ALLOWED + select ARCH_HAS_DMA_SET_MASK if SWIOTLB select ARCH_HAS_ELF_RANDOMIZE select ARCH_HAS_FORTIFY_SOURCE select ARCH_HAS_GCOV_PROFILE_ALL diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h index e5ee4ac97c14..16d45518d9bb 100644 --- a/arch/powerpc/include/asm/dma-mapping.h +++ b/arch/powerpc/include/asm/dma-mapping.h @@ -110,8 +110,5 @@ static inline void set_dma_offset(struct device *dev, dma_addr_t off) dev->archdata.dma_offset = off; } -#define HAVE_ARCH_DMA_SET_MASK 1 -extern int dma_set_mask(struct device *dev, u64 dma_mask); - #endif /* __KERNEL__ */ #endif /* _ASM_DMA_MAPPING_H */ diff --git a/arch/powerpc/kernel/dma-swiotlb.c b/arch/powerpc/kernel/dma-swiotlb.c index 62caa16b91a9..b3266f7a6915 100644 --- a/arch/powerpc/kernel/dma-swiotlb.c +++ b/arch/powerpc/kernel/dma-swiotlb.c @@ -22,6 +22,14 @@ #include #include +bool arch_dma_set_mask(struct device *dev, u64 dma_mask) +{ + if (!ppc_md.dma_set_mask) + return 0; + return ppc_md.dma_set_mask(dev, dma_mask); +} +EXPORT_SYMBOL(arch_dma_set_mask); + unsigned int ppc_swiotlb_enable; /* diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c index 59f38ca3975c..cf0ae0b3fb24 100644 --- a/arch/powerpc/kernel/dma.c +++ b/arch/powerpc/kernel/dma.c @@ -209,18 +209,6 @@ const struct dma_map_ops dma_nommu_ops = { }; EXPORT_SYMBOL(dma_nommu_ops); -int dma_set_mask(struct device *dev, u64 dma_mask) -{ - if (ppc_md.dma_set_mask) - return ppc_md.dma_set_mask(dev, dma_mask); - - if (!dev->dma_mask || !dma_supported(dev, dma_mask)) - return -EIO; - *dev->dma_mask = dma_mask; - return 0; -} -EXPORT_SYMBOL(dma_set_mask); - static int __init dma_init(void) { #ifdef CONFIG_IBMVIO diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c index 296ffabc9386..cb91a3d113d1 100644 --- a/arch/powerpc/sysdev/fsl_pci.c +++ b/arch/powerpc/sysdev/fsl_pci.c @@ -135,9 +135,6 @@ static inline void setup_swiotlb_ops(struct pci_controller *hose) {} static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask) { - if (!dev->dma_mask || !dma_supported(dev, dma_mask)) - return -EIO; - /* * Fix up PCI devices that are able to DMA to the large inbound * mapping that allows addressing any RAM address from across PCI. @@ -147,7 +144,6 @@ static int fsl_pci_dma_set_mask(struct device *dev, u64 dma_mask) set_dma_offset(dev, pci64_dma_offset); } - *dev->dma_mask = dma_mask; return 0; } diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 15bd41447025..8dd19e66c0e5 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -598,18 +598,23 @@ static inline int dma_supported(struct device *dev, u64 mask) return ops->dma_supported(dev, mask); } -#ifndef HAVE_ARCH_DMA_SET_MASK +#ifdef CONFIG_ARCH_HAS_DMA_SET_MASK +bool arch_dma_set_mask(struct device *dev, u64 mask); +#else +#define arch_dma_set_mask(dev, mask) true +#endif + static inline int dma_set_mask(struct device *dev, u64 mask) { if (!dev->dma_mask || !dma_supported(dev, mask)) return -EIO; - + if (!arch_dma_set_mask(dev, mask)) + return -EIO; dma_check_mask(dev, mask); *dev->dma_mask = mask; return 0; } -#endif static inline u64 dma_get_mask(struct device *dev) { diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index 645c7a2ecde8..951045c90c2c 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -16,6 +16,9 @@ config ARCH_DMA_ADDR_T_64BIT config ARCH_HAS_DMA_COHERENCE_H bool +config ARCH_HAS_DMA_SET_MASK + bool + config HAVE_GENERIC_DMA_COHERENT bool -- 2.19.1