Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6399857imu; Wed, 14 Nov 2018 00:27:59 -0800 (PST) X-Google-Smtp-Source: AJdET5cVTUTAeVrELFONLFYxfdgIkaTszHfummVG86kbEwvwZ9ld4W8wWs4aPXSz75RK5SCVULla X-Received: by 2002:a17:902:b943:: with SMTP id h3-v6mr944328pls.124.1542184078971; Wed, 14 Nov 2018 00:27:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542184078; cv=none; d=google.com; s=arc-20160816; b=sIbMC2ZpNf4/DBC59YnxQQ4/Yyrnkwpg2ljdNyQoc++ZiXnHraO+hioV20Ep5kUhVc YSmkjyWcq5nqYijKpXUa4bUWQgd0XdOr9iNbneQz+rY+GaLxwEmIAZwYu5u6h8oN1HD9 NXqYRR++UAia+dPhY7RmWB/+Szbamh/hkwWMtwzFlEUHFuJ884Yt/vcXDcajxwy87gdN BFVYD8IDdoWW/78aCZWh5VUG/A/UIs3n4sk9qdqGIAX8eFemQ4iddusyK1CMbrad8U5H uAFf+yApDbJWQn53fomnCwTpvoCzJlpzBNzde1CpM8R8KcWDp8JP8G3I+9+LlRGqLKvZ nxVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=86DBsBIMmIhEBTOakHAGIbjLaXZ370gqa5k2c+NEa2M=; b=ERHA4ChE8KqXjzgG5rOvrKA7r+QlVlo5Vw18Bzq/Pwy0A7RDV86kTTVPacv0NEHAXh fR0orlPlfZ+pYTvMCyUngGc8aP0rCqn0O7VD6gCwf1gACuahxUi8FKEPaEyLVBDSw3BD oHPm9VKVbZddpfezsMlRwB5NuoerKMtENeTmKxcf5XHf80oOK46JkbleandG0uNLjqc4 WRjgb9A7Pd/2QOZ0lrwpAYrPM7U+6KgqHNbHF1t0e9o27YZTOUpb82S7fdLfDLU7YsGl +BjLZufKUE4QdrETnA2CeASyhOs/WbVcjDOM/3qDer4G1kS5FFTqARuqmmkI9ZGoAApd W8Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pf9XkHGx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca18-v6si25528224plb.261.2018.11.14.00.27.44; Wed, 14 Nov 2018 00:27:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=pf9XkHGx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732450AbeKNS1q (ORCPT + 99 others); Wed, 14 Nov 2018 13:27:46 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:49980 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732965AbeKNS0v (ORCPT ); Wed, 14 Nov 2018 13:26:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=86DBsBIMmIhEBTOakHAGIbjLaXZ370gqa5k2c+NEa2M=; b=pf9XkHGx0G+Yt49BZ8HaetquH6 xCzsmiWUWokmww8rosEuIi+B8DvjqWCnoJkRoSFbbBfMycJiJ8Wn7Bpi1XFPSw4baiL38sLlwEOgv 6HWhYtNUF0TYTGH/p+tnU65juWdf/VB+VP86ooFfW0kyUgSH1vRyY2V87ZjfSk1XAeqFXEU3NRJlf hKtTAVNr3uIcAZ1a9Shsv2SEyPIg6nA5JVefiZj0si2NeyXcrR9Gbj8AxbHMTmR+TTsp7yaP7N/tt fj8w2UTffKlK20MfzGYk0uoSsapT+FdvE3hx45oYCFAy8dLG05OJ1obFrdktfXqEgVJL1Xdxx6dlz nrTnfeQg==; Received: from 089144211136.atnat0020.highway.a1.net ([89.144.211.136] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMqTL-00054A-Nu; Wed, 14 Nov 2018 08:24:28 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 26/34] powerpc/dma: fix an off-by-one in dma_capable Date: Wed, 14 Nov 2018 09:23:06 +0100 Message-Id: <20181114082314.8965-27-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114082314.8965-1-hch@lst.de> References: <20181114082314.8965-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We need to compare the last byte in the dma range and not the one after it for the bus_dma_mask, just like we do for the regular dma_mask. Fix this cleanly by merging the two comparisms into one. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/dma-direct.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/include/asm/dma-direct.h b/arch/powerpc/include/asm/dma-direct.h index e00ab5d0612d..92d8aed86422 100644 --- a/arch/powerpc/include/asm/dma-direct.h +++ b/arch/powerpc/include/asm/dma-direct.h @@ -4,15 +4,11 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size) { -#ifdef CONFIG_SWIOTLB - if (dev->bus_dma_mask && addr + size > dev->bus_dma_mask) - return false; -#endif - if (!dev->dma_mask) return false; - return addr + size - 1 <= *dev->dma_mask; + return addr + size - 1 <= + min_not_zero(*dev->dma_mask, dev->bus_dma_mask); } static inline dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr) -- 2.19.1