Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6473111imu; Wed, 14 Nov 2018 01:58:24 -0800 (PST) X-Google-Smtp-Source: AJdET5e1c9ctwMKoOREydw5dwg1eAomkqLZI8L1fxB3gqaJgLg16zNu2b09YVYlIU1LpplJ/wXP0 X-Received: by 2002:a17:902:b592:: with SMTP id a18mr1272067pls.182.1542189504418; Wed, 14 Nov 2018 01:58:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542189504; cv=none; d=google.com; s=arc-20160816; b=CIdVLhF5jpS3kxQNybhnVOXRMb/SETFUkeBkwp6Zg+Vi9fuETI5Eriku+Er1Oym/og UeqFS50Qc5IFaMqDcgTYVqBYZSSLUpckcmP3hvVal2UrLFoJMoH95M3ybwd04HRVy3Jo 8GLVcuy2kblrFpzodec45eOwI752/zA4tcXDmlnuQlIeoOErVBlpSUOh2NWGO9f1f2Au fC4sGs5mDuoMCUF9q1Ur/xegDLoECgAzN3Sex6Nmjqa5U/jJ0My76OfZfkmEdVukVYKJ nWnBFd57KQuineSKGGR2+C8xbg89sTzEhArOEhEsaHNsUHPg+bK/R0ZIVWzKTAQNIITh jP7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jShVApfWkYD4S1+Rm0PA2CYWotI2+CWZqXh3OsoGhxA=; b=BykizYp7ph3Bym2UQwZlZ/Xh+tgAvaQimgxKSZFBFyNXpvUVDPNpryenElBFCyOhN6 8rwIEjWz4gsztlNVtsWmdenjglPLLY0qX4KQTSNjIFbBVlPd+UTrdLxjB9B/yjBPgh7y Bf0JcxvawS6yc/saGdl6I7eDalrxy+G3fKltYCCIFy+8jAVp1RWTZJoPKr3UtrtxRP6z jJXqphKbIMYKWOAQ8+1xNqghR3MNUgFY5Ho9mCa7Yt1GY5Fk27jB5f0rBIif+tAtgkYI dw88+RYw7hrnhIva/BL1lSy8g8lLiAWv0BOjujqFbrClrKuer7jW041UKYiVHmdRGtKh 7/OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h13si227436pgk.179.2018.11.14.01.58.08; Wed, 14 Nov 2018 01:58:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732174AbeKNUAW (ORCPT + 99 others); Wed, 14 Nov 2018 15:00:22 -0500 Received: from mail.bootlin.com ([62.4.15.54]:58528 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727558AbeKNUAW (ORCPT ); Wed, 14 Nov 2018 15:00:22 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 39E1920D92; Wed, 14 Nov 2018 10:57:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost (242.171.71.37.rev.sfr.net [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id 0808220D7C; Wed, 14 Nov 2018 10:57:38 +0100 (CET) Date: Wed, 14 Nov 2018 10:57:37 +0100 From: Alexandre Belloni To: "Maciej W. Rozycki" Cc: Alessandro Zummo , Matt Turner , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: m41t80: Complete error propagation from SMBus calls Message-ID: <20181114095737.GV29768@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2018 02:39:51+0000, Maciej W. Rozycki wrote: > Complement commit 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate > error value from smbus functions") and correct the remaining places that > fail to propagate the error code from SMBus calls. > > Signed-off-by: Maciej W. Rozycki > References: 85d77047c4ea ("drivers/rtc/rtc-m41t80.c: propagate error value from smbus functions") > --- > Hi, > > I think this does not qualify for backporting, but please feel free to > decide otherwise. > > This change I did verify at run time to the extent I was able to, but I > didn't try to trigger artificial errors. Also the M41T81, which is the > device I've been using this driver with, does not have battery failure > indication implemented, so I could not execute the procfs handling path > (again without making some artificial changes). These changes should be > obvious regardless. > > I'll be posting further patches over the coming weeks, based on my > original effort as archived here: , > > However I have just realised they'll need another iteration before I post > them. So for now just these two obvious fixes. > Regarding the persistent part, do you really need more than what is provided? As far as I know, the timekeeping core is already taking care of using the best source to get the suspended time. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com