Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6650775imu; Wed, 14 Nov 2018 05:03:50 -0800 (PST) X-Google-Smtp-Source: AJdET5dhxp7RDmJh9WTVYhGppHXcPS9umQxZOfD3/28+DT8hSf5J6qKDIDWnz1rrZKvABCo9U78P X-Received: by 2002:a63:200e:: with SMTP id g14mr1656234pgg.235.1542200630078; Wed, 14 Nov 2018 05:03:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542200630; cv=none; d=google.com; s=arc-20160816; b=S0EPW9EeOtWX3iTd7a7OnfK25TTsdjpg9ZExuooxvSL+2KgsqkeClKMxFkuP1Bw5jE ueyKevlR8k3y3RmOpuQ0Z3rmUoZpVeJ7PU9gVkoVUebVQfrMeYO0mVNtOuG3ZVOiHlmo 733/th7QsoITgTgPYQ7whb4IlJ/Z6sJSI8bTWkW6bBXe6eg8dN4RN4yHJPL4ufOg19XW LOjvsurtX2D6sqiWYcLTc/CPZpJa40reglv8AY1m08/9borMEjvGdJsTY1UJ5UxB7HJK KDOMsqrXpiQ86Gv36JQWPl4E4EY2BwpSTYjEEK6i9H20yzwt3wuy5tY8TAayNS09dWWT eJ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6+tYmLNsznf4K1U8H6p8DxxOxR11sgzODxzzcyrvNyA=; b=zVscP/ZvLgGh6MCXEwssBfkFuRdWgW76xc0gBMWkJre/llCo6jnEV8VJH2R0/W8DIU FcKhcY4zV5qW/mUBsy4VZigE5n6VKqqbb2vgLP7IC9y5+613I9Spw62asfnLUXqpjbpi sRae0Dl8j6E0ns4cp4tWLallj3OHzzhOdaPad2c23JI7UmHLOttW2SrNGCl+N0WfpOA4 ja56Fu38HJnC4pamt1HDRg08vLfVZqoOoC1KlflBHDcf3QWjAUEgqwj7k/HvtFyWpFAL k7o8p6O8nBmzZLfwXT1q0VRtsQYwJxrhV91tJBFEIqEz5qsnkkUDrrScY5Ntk8YEHklG 1x6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l91-v6si25425858plb.315.2018.11.14.05.03.34; Wed, 14 Nov 2018 05:03:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732874AbeKNXDc (ORCPT + 99 others); Wed, 14 Nov 2018 18:03:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:44554 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732837AbeKNXDb (ORCPT ); Wed, 14 Nov 2018 18:03:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7EC3DB0EC; Wed, 14 Nov 2018 13:00:21 +0000 (UTC) From: Nicolas Saenz Julienne To: stefan.wahren@i2se.com, eric@anholt.net, dave.stevenson@raspberrypi.org Cc: linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne Subject: [PATCH 10/16] staging: vchiq_core: don't add a wmb() before remote_event_signal() Date: Wed, 14 Nov 2018 13:59:36 +0100 Message-Id: <20181114125942.25163-11-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114125942.25163-1-nsaenzjulienne@suse.de> References: <20181114125942.25163-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's the first thing remote_event_signal() does. Signed-off-by: Nicolas Saenz Julienne --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 8b23ea5322e8..5791c2b670fa 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1137,9 +1137,6 @@ queue_message_sync(VCHIQ_STATE_T *state, VCHIQ_SERVICE_T *service, size); } - /* Make sure the new header is visible to the peer. */ - wmb(); - remote_event_signal(&state->remote->sync_trigger); if (VCHIQ_MSG_TYPE(msgid) != VCHIQ_MSG_PAUSE) @@ -3269,7 +3266,6 @@ static void release_message_sync(VCHIQ_STATE_T *state, VCHIQ_HEADER_T *header) { header->msgid = VCHIQ_MSGID_PADDING; - wmb(); remote_event_signal(&state->remote->sync_release); } -- 2.19.1