Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6654001imu; Wed, 14 Nov 2018 05:06:14 -0800 (PST) X-Google-Smtp-Source: AJdET5f1hqNLHuyc5RdgQp/9pbfW1qxrsp+dN89z682Yqeit8rt/A63EyQA6I2FTL5SjMTO0d8WC X-Received: by 2002:a62:2bd4:: with SMTP id r203-v6mr1886656pfr.105.1542200774466; Wed, 14 Nov 2018 05:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542200774; cv=none; d=google.com; s=arc-20160816; b=sCFJO3752EYiQULNBNzjZH5R+AiNaF4kplF76LWa5qXDAviE/867NBkOByrOyvdGDR 1Qi4mpATBFpEOUD7Zz5bcN7eGF97TlN3WtPCIP0qL/AFs2///ofrFvj8bI0a4SBS2AL8 Hbq1ZXq7LigrzupklmF+lbHaBKLWshr6xofmTWksNnayjAHxIcMrAXAcssbW1uB5xQWy xbZpLFqSG0nTMxrStjElPxz694LCpWpD90JlTb4qrLS+/4wNKNTnvi1pecSsd96tH+Yj etosvBkDdszSlOdDzxTes9jmjg/ld2NPgNEqB2Wv5TMpP2hVx8Uzt60j03Uf8amYC418 +Wbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=KD76rgWd80+aLSVPQC0oQ9BKj0BU48MSwkSVs39alfs=; b=zDYE1DdBod7WvcLdvdAXyhtjQ/ka0n9fCZQh/DDGamhExXG4kK5Ey4olWh28xgE4qa OYmXinNRtXtTi4IcgIpbEz5XxYEZJX7E1ZzUGHD6ypklB7ugO7JKyZnOIpvXaye3ZC7V ZOgpFuIUS1xtIZIfdWNPDe5DwaGUstvANiuBTbqrERgSicnqcB6APQXc0Usks8bKHJ50 xgXop/Lr8O5MWozXfMZZfABRapUVJVRum/uLT3BWwcCxQ98zaNCChPMvz1KKOGxd/Fdp 9KkYvDJqofY9NsHCtVfCSk8JMQw7lzwBgU4nXMHHyYYEVk75RW5h7tUOAddmdgRaRzP/ VIqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e20si6822821pgv.486.2018.11.14.05.05.58; Wed, 14 Nov 2018 05:06:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732353AbeKNXD0 (ORCPT + 99 others); Wed, 14 Nov 2018 18:03:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:44472 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728343AbeKNXD0 (ORCPT ); Wed, 14 Nov 2018 18:03:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BA10BB082; Wed, 14 Nov 2018 13:00:15 +0000 (UTC) From: Nicolas Saenz Julienne To: stefan.wahren@i2se.com, eric@anholt.net, dave.stevenson@raspberrypi.org Cc: linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne Subject: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes Date: Wed, 14 Nov 2018 13:59:26 +0100 Message-Id: <20181114125942.25163-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, This series was written in parallel with reading and understanding the vchiq code. So excuse me for the lack of logic in the sequence of patches. The main focus was to delete as much code as possible, I've counted around 550 lines, which is not bad. Apart from that there are some patches enforcing proper kernel APIs usage. The only patch that really changes code is the vchiq_ioc_copy_element_data() rewrite. The last commit updates the TODO list with some of my observations, I realise some of the might be a little opinionated. If anything it's going to force a discussion on the topic, which is nice. It was developed on top of the latest linux-next, and was tested on a RPIv3B+ with audio, video and running vchiq_test. Regards, Nicolas === Nicolas Saenz Julienne (16): staging: vchiq_core: rework vchiq_get_config staging: vchiq_arm: rework close/remove_service IOCTLS staging: vchiq_shim: delete vchi_service_create staging: vchiq_arm: use list_for_each_entry when accessing bulk_waiter_list staging: vchiq_arm: get rid of vchi_mh.h staging: vchiq_arm: rework vchiq_ioc_copy_element_data staging: vchiq-core: get rid of is_master distinction staging: vchiq_core: remove unnecessary safety checks in vchiq_init_state staging: vchiq_core: do not initialize semaphores twice staging: vchiq_core: don't add a wmb() before remote_event_signal() staging: vchiq: use completions instead of semaphores staging: vchiq_util: get rid of unneeded memory barriers staging: vchiq_core: fix logic redundancy in parse_open staging: vchiq_arm: rework probe and init functions staging: vchiq_arm: fix open/release cdev functions staging: vchiq: add more tasks to the TODO list .../staging/vc04_services/interface/vchi/TODO | 42 ++ .../vc04_services/interface/vchi/vchi.h | 8 - .../vc04_services/interface/vchi/vchi_mh.h | 42 -- .../interface/vchiq_arm/vchiq_2835_arm.c | 18 +- .../interface/vchiq_arm/vchiq_arm.c | 598 ++++++++---------- .../interface/vchiq_arm/vchiq_core.c | 523 ++++----------- .../interface/vchiq_arm/vchiq_core.h | 47 +- .../interface/vchiq_arm/vchiq_if.h | 11 +- .../interface/vchiq_arm/vchiq_shim.c | 32 - .../interface/vchiq_arm/vchiq_util.c | 48 +- .../interface/vchiq_arm/vchiq_util.h | 6 +- 11 files changed, 435 insertions(+), 940 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchi/vchi_mh.h -- 2.19.1