Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6845260imu; Wed, 14 Nov 2018 07:49:39 -0800 (PST) X-Google-Smtp-Source: AJdET5ft1J5RH1Q/e8YFsLyDdz9Co1S9fZuQAhf5I6enMTXBneeV1V13hu9SBhw4+1+TfcEvs1+c X-Received: by 2002:a63:790e:: with SMTP id u14mr2215545pgc.452.1542210579363; Wed, 14 Nov 2018 07:49:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542210579; cv=none; d=google.com; s=arc-20160816; b=HjNL3Ta7lT74pI2aSGLvcL1fHldSP6ipFjPJQ6pNs6DL2pcbEtuzQUkiSEgIPOl+Wg S4Oe5SJCp/g1zk1ucBpWu7cCLXiGHTjjeQEmhfHS36DwuRQaQMGZ43cT4KCdYMNpkx2R dbZM0g1FkqjkiBjat3eY5yqYVEvPPADMy9QennnAu4jrVCHj8JgZYBfO5mKwz7vArvBn VKoG23JgWztKG7rqh6Idb0Z5MB/umX2TY0G7IFWhwgVWJ5Luw0lAWswOZiF0UTAd2fsF aMXjleO+oJkjDrHksR1c+sO+GudjbOBmXWlDoyhYpIC8XKIby4jeWk9JaDby/eJiaDXo 7t4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hjPoKOmZ9FPsntA63KDFdzu2tYm4MGO1McGgC1BSbjk=; b=G50ZlQKHjnEnNzMlYYucHMBgphiPW/jlB3tx/KrJ3M07ajr0LtkhfzXoRCj3EcT9B/ L20BMYAoEVWeZSta/dS7nwZQMdHpKAfPmS/GU5PXEMMEqHNlpwZD7hzfNNczKCD/CjW0 nEcoNv48wTjRkBwn/0e9udESIYxzHoAn4SNDQgSoMXq0u5k96Pe5TOtPby3fllzgJ7E/ i+3YrnuVp+XFntY0s9l8eQuQunVCVCdgCzD8mVQkOl9DnLmgSoptwUnlZuiqp5OV3YFt Xi/CV4AsFJNWM7I06yQANfPYa2bJV4olVI3o0ZkCErFbaiKoR5lv4htNo6P1btZOaoI3 p5iA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w8-v6si25236337plz.213.2018.11.14.07.49.23; Wed, 14 Nov 2018 07:49:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387470AbeKOBwq (ORCPT + 99 others); Wed, 14 Nov 2018 20:52:46 -0500 Received: from verein.lst.de ([213.95.11.211]:35778 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732950AbeKOBwq (ORCPT ); Wed, 14 Nov 2018 20:52:46 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id A318868CF7; Wed, 14 Nov 2018 16:48:57 +0100 (CET) Date: Wed, 14 Nov 2018 16:48:57 +0100 From: Christoph Hellwig To: Benjamin Block Cc: Christoph Hellwig , axboe@kernel.dk, martin.petersen@oracle.com, ooo@electrozaur.com, Johannes Thumshirn , Benjamin Block , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] bsg-lib: handle bidi requests without block layer help Message-ID: <20181114154857.GA28985@lst.de> References: <20181111133211.13926-1-hch@lst.de> <20181111133211.13926-7-hch@lst.de> <20181113143520.GB7222@w530-pk1mzal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181113143520.GB7222@w530-pk1mzal> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 13, 2018 at 03:35:20PM +0100, Benjamin Block wrote: > This seems like a non-obvious user-breakage. So apart from removing the > in-kernel stuff that uses bidirectional commands you also forbid > userspace from every using them? That seems wrong to me. > > There is other SCSI Command Sets than OSD that provide bidirectional > commands, even SBC has some (i.e. X*WRITE*, COMPARE AND WRITE). Yes, there are a few. But the only driver that even supports them right now is iscsi_tcp to start with, and we have to drag a significant amount of code around just to support this corner case.