Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7100608imu; Wed, 14 Nov 2018 11:43:08 -0800 (PST) X-Google-Smtp-Source: AJdET5coGcH1Qvfc5BkVpPgqO4YR6CTz5Wsl7A4WqD5m/zA8BKO8LZhjWZ5liWOrw0hLl6L3Ikd4 X-Received: by 2002:a62:3406:: with SMTP id b6-v6mr3344013pfa.50.1542224587956; Wed, 14 Nov 2018 11:43:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542224587; cv=none; d=google.com; s=arc-20160816; b=l6U6X3SFqS8OKAC/PeddxQvYUMVWKNNYr1t+zUerQloO72MUBLLSgvQOfAmtPL7g0u dFslsa8dvjBgXFCNPP0AJ5aFhvaiVG4SY4CWKUFnnl8LK6ouwpEnWRiHbUli6QcJgXr/ WkVtCOS7ozVTIeGV4g68uESEIFqP1iJvrPfg6gNFQXJgPmKlkBq+2Uo7HNz8bdkrLPZT Bjo1zuwjtlTxcZgWDd3hcWvO/XLBgfOf4NbPwYCN516TlP1EN3xjYRDUlyzifZTZXgDw emUK6x9Y2uWB881r9wGxh/Qc4SqVrhDMTv0fn82KlqNEC6fwTng/FP4n1aYL13MSsw2g An2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=w8bku6AIq6D9Viea+onIPm6Ljwh1UCgMI96Y8GAI1QU=; b=A2QVU0BdQqBLeDNtc7zOsKVNqtlOwmYn206vT+mwDqR6cNJMlGvUski0RFIq+amlf4 P8r5coD+9a9z4oPSQg0TBskgZH4ac3AtFWxiyBt7sdHq6tF3aqLO1CUnwzG66MQYa7/s GeioJLGuo1rG/eS+j44fuZtngpSq0BoEY2mlv4aFpid2p799dcDCMwKLy/btsaP9ypaa OzurjWuSxGQ/jz7/eND+yXFbGdZKTzSUt/fqhEoDZJ5uCreiDMm4OI72JKUeZE9ElPl9 pn/EwoD0tJ4N/J9nLrNmTteviBgGijMOOCW6yoNP8lINAwpedalGIcvGNmO41lz/kw/t hTNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q66si224078pfb.231.2018.11.14.11.42.52; Wed, 14 Nov 2018 11:43:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbeKOFpr (ORCPT + 99 others); Thu, 15 Nov 2018 00:45:47 -0500 Received: from mga11.intel.com ([192.55.52.93]:39733 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOFpq (ORCPT ); Thu, 15 Nov 2018 00:45:46 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 11:41:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,233,1539673200"; d="p7s'?scan'208";a="85839986" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga007.fm.intel.com with ESMTP; 14 Nov 2018 11:41:13 -0800 Received: from orsmsx101.amr.corp.intel.com ([169.254.8.195]) by ORSMSX109.amr.corp.intel.com ([169.254.11.127]) with mapi id 14.03.0415.000; Wed, 14 Nov 2018 11:41:13 -0800 From: "Derrick, Jonathan" To: "Alex_Gagniuc@Dellteam.com" , "helgaas@kernel.org" CC: "Austin.Bolen@dell.com" , "linux-kernel@vger.kernel.org" , "Shyam.Iyer@dell.com" , "sbobroff@linux.ibm.com" , "linuxppc-dev@lists.ozlabs.org" , "ruscur@russell.cc" , "oohall@gmail.com" , "mr.nuke.me@gmail.com" , "lukas@wunner.de" , "gregkh@linuxfoundation.org" , "linux-pci@vger.kernel.org" , "Busch, Keith" Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Thread-Topic: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Thread-Index: AQHUT50UGu8tYuYbD0+KJZJsxJImXKVQit4A Date: Wed, 14 Nov 2018 19:41:12 +0000 Message-ID: <1542224470.22756.6.camel@intel.com> References: <20181108220117.GA11466@kroah.com> <20181108223258.GD2932@localhost.localdomain> <20181108224255.GA20619@kroah.com> <20d68e586fff4dcca5616d5056f6fc21@ausx13mps321.AMER.DELL.COM> <20181108225109.GA3023@kroah.com> <16bf9d14bc5f4a90b2b88dd2eb165186@ausx13mps321.AMER.DELL.COM> <5da8d8aa9f3818af649b1ac547bc4e6062626ddf.camel@gmail.com> <20181113050240.GA182139@google.com> <19136f44cd5c45e79bbef7e78a6bf332@ausx13mps321.AMER.DELL.COM> <20181114055956.GA144931@google.com> <1eb0fa27924f426992715684f5e63346@ausx13mps321.AMER.DELL.COM> In-Reply-To: <1eb0fa27924f426992715684f5e63346@ausx13mps321.AMER.DELL.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.232.115.167] Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-lpB01QR67hbuIT54IqVb" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-lpB01QR67hbuIT54IqVb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2018-11-14 at 19:22 +0000, Alex_Gagniuc@Dellteam.com wrote: [snip] > The whole issue of firmware-first, the mechanism by which > > > > firmware > > > > gets control, the System Error enables in Root Port Root > > > > Control > > > > registers, etc., is very murky to me. Jon has a sort of > > > > similar issue > > > > with VMD where he needs to leave System Errors enabled instead > > > > of > > > > disabling them as we currently do. > > >=20 > > > Well, OS gets control via _OSC method, and based on that it > > > should > > > touch/not touch the AER bits. > >=20 > > I agree so far. > >=20 > > > The bits that get set/cleared come from _HPX method, > >=20 > > _HPX tells us about some AER registers, Device Control, Link > > Control, > > and some bridge registers. It doesn't say anything about the Root > > Control register that Jon is concerned with. >=20 > _HPX type 3 (yay!!!) got approved recently, and that will have more=20 > fine-grained control. It will be able to handle root control reg. >=20 > > For firmware-first to work, firmware has to get control. How does > > it > > get control? How does OSPM know to either set up that mechanism or > > keep its mitts off something firmware set up before handoff? >=20 > My understanding is that, if FW keeps control of AER in _OSC, then > it=20 > will have set things up to get notified instead of the OS. OSPM not=20 > touching AER bits is to make sure it doesn't mess up FW's setup. I > think=20 > there are some proprietary bits in the root port to route interrupts > to=20 > SMIs instead of the AER vectors. >=20 > > In Jon's > > VMD case, I think firmware-first relies on the System Error > > controlled > > by the Root Control register. Linux thinks it owns that, and I > > don't > > know how to learn otherwise. >=20 > Didn't Keith say the root port is not visible to the OS? >=20 > Alex That's correct. OS visibility wrt ACPI is limited to the VMD endpoint/host bridge device which exposes the root ports. The root ports aren't described by ACPI. VMD is the unusual case. In VMD case, we might or might not need to pass back control to AER for further error handling post FFS. I can see that's normally done by GHES but will probably need some shimming to support the VMD case. I can't rely on AER, because if any other devices use APEI, then the AER module won't be initialized (aer_service_init::aer_acpi_firmware_first) --=-lpB01QR67hbuIT54IqVb Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKeTCCBOsw ggPToAMCAQICEFLpAsoR6ESdlGU4L6MaMLswDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzAzMTkwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA 4LDMgJ3YSVX6A9sE+jjH3b+F3Xa86z3LLKu/6WvjIdvUbxnoz2qnvl9UKQI3sE1zURQxrfgvtP0b Pgt1uDwAfLc6H5eqnyi+7FrPsTGCR4gwDmq1WkTQgNDNXUgb71e9/6sfq+WfCDpi8ScaglyLCRp7 ph/V60cbitBvnZFelKCDBh332S6KG3bAdnNGB/vk86bwDlY6omDs6/RsfNwzQVwo/M3oPrux6y6z yIoRulfkVENbM0/9RrzQOlyK4W5Vk4EEsfW2jlCV4W83QKqRccAKIUxw2q/HoHVPbbETrrLmE6RR Z/+eWlkGWl+mtx42HOgOmX0BRdTRo9vH7yeBowIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFB5pKrTcKP5HGE4hCz+8rBEv8Jj1MA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAKcLNo/2So1Jnoi8G7W5Q6FSPq1fmyKW3 sSDf1amvyHkjEgd25n7MKRHGEmRxxoziPKpcmbfXYU+J0g560nCo5gPF78Wd7ZmzcmCcm1UFFfIx fw6QA19bRpTC8bMMaSSEl8y39Pgwa+HENmoPZsM63DdZ6ziDnPqcSbcfYs8qd/m5d22rpXq5IGVU tX6LX7R/hSSw/3sfATnBLgiJtilVyY7OGGmYKCAS2I04itvSS1WtecXTt9OZDyNbl7LtObBrgMLh ZkpJW+pOR9f3h5VG2S5uKkA7Th9NC9EoScdwQCAIw+UWKbSQ0Isj2UFL7fHKvmqWKVTL98sRzvI3 seNC4DCCBYYwggRuoAMCAQICEzMAAMamAkocC+WQNPgAAAAAxqYwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEEwHhcNMTgxMDE3MTgxODQzWhcNMTkxMDEyMTgxODQzWjBHMRowGAYDVQQDExFEZXJyaWNr LCBKb25hdGhhbjEpMCcGCSqGSIb3DQEJARYaam9uYXRoYW4uZGVycmlja0BpbnRlbC5jb20wggEi MA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCjUTRFAcK/fny1Eh3T7Q0iD+MSCPo7ZnIoW/hI /jifxPTtccOjZgp1NsXP5uPvpZERSz/VK5pyHJ5H0YZhkP17F4Ccdap2yL3cmfBwBNUeyNUsQ9AL 1kBq1JfsUb+VDAEYwXLAY7Yuame4VsqAU24ZqQ1FOee+a1sPRPnJwfdtbJDP6qtS2sLMlahOlMrz s64sbhqEEXyCKujbQdpMupaSkBIqBsOXpqKgFZJrD1A/ZC5jE4SF27Y98C6FOfrA7VGDdX5lxwH0 PNauajAtxgRKfqfSMb+IcL/VXiPtVZOxVq+CTZeDJkaEmn/79vg8OYxpR+YhFF+tGlKf/Zc4id1P AgMBAAGjggI3MIICMzAdBgNVHQ4EFgQU4oawcWXM1cPGdwGcIszDfjORVZAwHwYDVR0jBBgwFoAU HmkqtNwo/kcYTiELP7ysES/wmPUwZQYDVR0fBF4wXDBaoFigVoZUaHR0cDovL3d3dy5pbnRlbC5j b20vcmVwb3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENB JTIwNEEuY3JsMIGfBggrBgEFBQcBAQSBkjCBjzBpBggrBgEFBQcwAoZdaHR0cDovL3d3dy5pbnRl bC5jb20vcmVwb3NpdG9yeS9jZXJ0aWZpY2F0ZXMvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIw SXNzdWluZyUyMENBJTIwNEEuY3J0MCIGCCsGAQUFBzABhhZodHRwOi8vb2NzcC5pbnRlbC5jb20v MAsGA1UdDwQEAwIHgDA8BgkrBgEEAYI3FQcELzAtBiUrBgEEAYI3FQiGw4x1hJnlUYP9gSiFjp9T gpHACWeB3r05lfBDAgFkAgEJMB8GA1UdJQQYMBYGCCsGAQUFBwMEBgorBgEEAYI3CgMMMCkGCSsG AQQBgjcVCgQcMBowCgYIKwYBBQUHAwQwDAYKKwYBBAGCNwoDDDBRBgNVHREESjBIoCoGCisGAQQB gjcUAgOgHAwaam9uYXRoYW4uZGVycmlja0BpbnRlbC5jb22BGmpvbmF0aGFuLmRlcnJpY2tAaW50 ZWwuY29tMA0GCSqGSIb3DQEBBQUAA4IBAQBxGkHe05DNpYel4b9WbbyQqD1G6y6YA6C93TjKULZi p8+gO1LL096ixD44+frVm3jtXMikoadRHQJmBJdzsCywNE1KgtrYF0k4zRWr7a28nyfGgQe4UHHD 7ARyZFeGd7AKSQ1y4/LU57I2Aw2HKx9/PXavv1JXjjO2/bqTfnZDJTQmOQ0nvlO3/gvbbABxZHqz NtfHZsQWS7s+Elk2xGUQ0Po2pMCQoaPo9R96mm+84UP9q3OvSqMoaZwfzoUeAx2wGJYl0h3S+ABr CPVfCgq9qnmVCn5DyHWE3V/BRjJCoILLBLxAxnmSdH4pF6wJ6pYRLEw9qoyNhpzGUIJU/Lk1MYIC FzCCAhMCAQEwgZAweTELMAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBD bGFyYTEaMBgGA1UEChMRSW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFs IEJhc2ljIElzc3VpbmcgQ0EgNEECEzMAAMamAkocC+WQNPgAAAAAxqYwCQYFKw4DAhoFAKBdMBgG CSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE4MTExNDE5NDExMFowIwYJ KoZIhvcNAQkEMRYEFHni90O5DHeZQC73IwuLy7GfyN4yMA0GCSqGSIb3DQEBAQUABIIBAC+5yM9O b3MSbIlXfB0Ebee0VQ+3CJ1x3cxOfnR2+atMo+L0jsqflxjWrGs2BN2EsPA6fDkjQ/wv17/0tAix ydb+BkoPS6I4G0NkR1peqMSrmZ/LFGDrtOMlZpPTO7pYpYFEW/untmT6OVhOVSNf6wdEyTveehMg arkdHmVT2kJ1tFOUu1OcuJNSrH3/iVNMcGWTcuv/uwQN4KlbZTeFbHNv/l+VrdG3qIdqeVysSuhc 9XLZE7L0Yv9vTWWop1Spzx5PjPAK/+VM6BCYUvPAQLs7Pg4nUiG9UV4g1uUbWmo2HIsLejgNieJa PQ7CPrYUvd0gvSl8xpThtozfCj1nB48AAAAAAAA= --=-lpB01QR67hbuIT54IqVb--