Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7148119imu; Wed, 14 Nov 2018 12:28:49 -0800 (PST) X-Google-Smtp-Source: AJdET5e5mQGRT+UEJRo/W3b7oXclXexsyQOEMVnZTL3MiwoVYVbgDzQ4P32annCGqmmbM+bmA/Vb X-Received: by 2002:a17:902:c01:: with SMTP id 1-v6mr3389756pls.15.1542227328960; Wed, 14 Nov 2018 12:28:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542227328; cv=none; d=google.com; s=arc-20160816; b=xge0r7EREcbj19PZFAA91x9oxmOJQKalx9pFm7TV4M9mBH8Dt86d+MpVbRV69jkc8e xsyseb3ehO+O3tzvUyF4omqyQK3xrhVnZNf9VFsD5d4FHcAqRdzVLdWMG7KO6SV57pQs vHBohSYGZudMFu/KRJotQSVsODU0h0MdF9sOpBCzHH/N0CFEcncwgr/cDWyiSKbGb5Fw cyNFJGiYEPkGMTp4blLk3UjEfmD5pe0sUr6zlvGAa0xsVgSno64stp50JX/83/w2+Ma2 27m5OGKPmRUNnYho0IofYWsFXUkftBD4q344ssSLHz0DhwKwr3kZNhFuwLG1+AskX+aC E8ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RDN9XlEV4vLBKMgG54Pc6G5lH3YnDFvbgeAoL4ID8LI=; b=ZGyqOuiImIzKvWppiGcDFEeJKKhBaBg0yLyjrBhAVw35iLSq/1awCC0AkIgKwm6/pa jMsCLPk58B+C0Fbd5pqeBeV8PegXImnfrC5Q4kRtTI8mjNNssaD4kD1vEWfNDYjShbML cX6ROptGWZP8X3z/4yidzvpF3MQGi6Y1pSTWrXcGOyKDO7qaTQx0hxcerHQ6enO+FVGn s340jxcTMufXPCKPOl327wgP6GKiQRTeLOis3kdM91VMHC1Y3d1Gvl7cJz8SPg93sjyK 71AAtgqpT0HnNv+dSo32r1hm7bt0RFJYcoMxdHPCSYkF7fp+Vy98EiYgqXDVxa3dpvKj EJIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si17560987pgj.358.2018.11.14.12.28.32; Wed, 14 Nov 2018 12:28:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728099AbeKOGcw (ORCPT + 99 others); Thu, 15 Nov 2018 01:32:52 -0500 Received: from mail.skyhub.de ([5.9.137.197]:47752 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOGcv (ORCPT ); Thu, 15 Nov 2018 01:32:51 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HJ__9E3sZXwE; Wed, 14 Nov 2018 21:28:06 +0100 (CET) Received: from zn.tnic (p200300EC2BD0D200D5714500C00E26FD.dip0.t-ipconnect.de [IPv6:2003:ec:2bd0:d200:d571:4500:c00e:26fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 946A91EC037D; Wed, 14 Nov 2018 21:28:06 +0100 (CET) Date: Wed, 14 Nov 2018 21:28:02 +0100 From: Borislav Petkov To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [PATCH v5 06/27] x86/cet: Control protection exception handler Message-ID: <20181114202802.GN13926@zn.tnic> References: <20181011151523.27101-1-yu-cheng.yu@intel.com> <20181011151523.27101-7-yu-cheng.yu@intel.com> <20181114184436.GK13926@zn.tnic> <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <307b6162b0270871e664ca88a96b4ea0d1b3f65b.camel@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 14, 2018 at 12:19:42PM -0800, Yu-cheng Yu wrote: > Yes, I was not sure if the addition should follow the existing style (which does > not have identifier names). What do you think is right? Yeah, we've converted them all now to named params: https://git.kernel.org/tip/8e1599fcac2efda8b7d433ef69d2492f0b351e3f It probably would be easier if you redo your patchset ontop of current tip/master. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.