Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7155486imu; Wed, 14 Nov 2018 12:36:28 -0800 (PST) X-Google-Smtp-Source: AJdET5cBcXiOcp6d7fN35lJ0Y1/tFockM2qBjiLfALniqNiZbBrpGSczmHf4BFm8JuNb4pgP4knE X-Received: by 2002:a63:df13:: with SMTP id u19mr3169129pgg.294.1542227788681; Wed, 14 Nov 2018 12:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542227788; cv=none; d=google.com; s=arc-20160816; b=dNhbTgTTcsLE4A43+zHvO3kFsMX3JCNZW/jVYPGzs6NhwcEVSKCopXcIYQDoPEfxh+ au6KAc7C8DseOHQLzdoUPxBjr3ErlwmauUsLY7kKMnCsKmVMGzR4V39npPPQa7ddMtIO xjisIVdqyWjJOWe6aOIWVAlGnau63iWPxRzBiTqy12P1tcohMmHWlf5Evj1LH2aBvpmA GJ/1SKH3Xs6JGFJW+ghG9dFp4TnVreK9VMS4q7JIwx87HTNWJZkMORPmAD3kUtaGSYRC vY/WBeQR2mZvt522UHWv26d/eAeVJLkmH5CsvZuEVnMhydj0pdTWSYEgk6eTz/yszcF4 oSSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=mes+CNGbUVHQQkrTZdwm2594oolg7hiq5RHcS/cU3JY=; b=b1j3UQsFx5HQfBNSKjGeMcCH/tPh5LXaZnwvzKm8b+Z0ZCSMjYxGBGDHF2oXVuOhwl 8jqvwGSQXFwUHV79N8ptx3F418xJvZyFpQUJYjOGPVnXsPna7WQABwFAnfsy6AuCbh3g rAyhUOanjDQzaev67Wsk32usw8HH5aY0NQWlfAdz9plMGKiLp61rq0hc1uDQC1Ra2fi6 Ov2jAni1lHt3v8uD5PRgGOCZH4TWTZjfQqX5hamMwu7Eme7VxK1jL3F15bCtsaAisM34 nOkj0VcKemEnJOdDJm+LtqkVXhoJU75PtbrMhDy4jqrYirIlJmYNQT5UopPkfK1oS+HJ 4row== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12si23923989pgl.106.2018.11.14.12.36.10; Wed, 14 Nov 2018 12:36:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbeKOGka (ORCPT + 99 others); Thu, 15 Nov 2018 01:40:30 -0500 Received: from mout.gmx.net ([212.227.15.19]:42501 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOGka (ORCPT ); Thu, 15 Nov 2018 01:40:30 -0500 Received: from dhcp-41-57.bos.redhat.com ([66.187.233.206]) by mail.gmx.com (mrgmx003 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M3j17-1fWRGI3a9R-00rD6X; Wed, 14 Nov 2018 21:35:28 +0100 Message-ID: <1542227722.12945.39.camel@gmx.us> Subject: Re: WARNING: CPU: 26 PID: 64391 at lib/vsprintf.c:2193 set_precision+0x84/0x90 From: Qian Cai To: Steven Rostedt Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, Petr Mladek , "Tobin C. Harding" , Geert Uytterhoeven , Rasmus Villemoes Date: Wed, 14 Nov 2018 15:35:22 -0500 In-Reply-To: <20181113142317.379dbaf7@vmware.local.home> References: <1542128132.12945.19.camel@gmx.us> <20181113172920.GI10650@smile.fi.intel.com> <1542135498.12945.20.camel@gmx.us> <20181113142317.379dbaf7@vmware.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:UbqCwO1j2USZq3zil76Xg5dhkrJIAmE5el9Cn59Oi7wkiWLJ9Or c52xJhmJdN72XmIOJDfc4UmJ/QSrsd5/duJJ4fHtssi+fKYIw66CCWeJWKeb+389qoJFHYa i9XMoVqeYhg3W+JuMhYg3HYzpqmvsOVn/0lXkr9YShQmOTrDqYe1Ke0U6Vjui4BqH3Jg92d /QTrGsfSwVeKplDCXWDrA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:UgQgye/yRI0=:25ItMZjWjQeZp/OQJuCpri X3puWRxxyJCZZ65AkbztopJYR9oF4I3M8S9EmuF8tWh1eVge8QA/qZyxlQ/m9QzKEkcVfeAfQ bhuFqcw6VZ9RUCEhs5dHZ6KDwMhqUUTuHbbMddPaR/ECoVRy6V3+BDy0kcN1RsdhBgKEPRg5p 7d+EjpbLd2ijUtG/jznbnOozJ6C10EZN2Q+6wTaoeqF6IfLstvN0u4zWffmwbyZs5kGfr0dbW Z94N0K19A1qLrOnHFRXrPfAkADbAONn1FCxY7vwCppiBosfhonFfh7sDk+ugyJXU9R/VtBMB0 0RJ4YnKpXYx+WY/Iu+y6eAX/mIT1Iddg1uiwreeRSkfTwAgoHZDTW4clMGMaHDOlBUbOCi4LR jeKzdbN7da9Kj8gnsSyvmu3veaj5HN8ybYYpV+z1ViTnm7xD9whAQ/LbxhVUy2vtY8fKUh9zZ X+G4UiMyIdv+pzbTmFSi+IS/u0Fzqiozehabd+ENZknBGp8JO7pjM1C9YgCsMEk9kwK+t/QyL DmvyPdJtSKHbzq3TWap9EV10IgdScyWtjHGrRuCKSWBz1MUSTcb4ALVOTfkYC3XkpQrTNneAI KDojz1iZuOCsml27PobsO6dtfizf2E+Dlwb9J0xhE1jHFLl//8weyKEklgXusUlyKfKAUIVpE Qq9Mv0n7TbyiioXholviD4lt9D3el2hq4/ZFtpaE991z/UgbIZaPzyKneA2yE6Gue1Cyvu+3S rXDR9glZfalFQvnOwDkvtSv+aYjcP5PZKIvzwZf7DeFtF05Wya56GgARok3OLmICAs6zGzAOw mXjkniwxcjt+oPnT3SHT/AAjzBGWIQo+9kSE6sZbTCDHzhpcUASM1b6IFtSPivF/jrwJszVF8 eeqwL+kOTcY57gThyG9ZR/D0Q6TIRDYCaETspCtSrd9cKDRBEBJyDgSkGGibC/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-11-13 at 14:23 -0500, Steven Rostedt wrote: > On Tue, 13 Nov 2018 13:58:18 -0500 > Qian Cai wrote: > > > > Care to print the len and name parameters before this line?   > > > > len = 60612; name = > > How big are pages on arm64? Because we shouldn't get to this path if # getconf PAGESIZE 65536 > the string is bigger than PAGE_SIZE. But I know that on PPC64, > PAGE_SIZE can be 64K, and 60612 is less than that. Thus, if we get > there, the test is against signed int:16 (16 bit signed integer) that > can go up to most 32768. If the string size is bigger than that, you > would get this error. > > I would just say to ignore it. The only thing that can happen if > someone does this is to trigger the warning. Unless if it is considered > a form of DOS, where userspace just bombards the console by triggering > this waring. But I don't see a problem with the actual design. There's > no reason we should be processing string variables bigger than 32768 in > vsprintf. > > -- Steve > > > > %d%d%d%d%d%d%s%s%s%d%s%d%d%d%s%s%s%s%s%d%s%d%s%s%s%d%s%d%d%s%s%d%s%s%d%d%s%s > > %s%s > > %s%d%s%d%d%s%s%s%d%d%d%d%d%s%s%s%s%d%s%s%s%s%d%d%d%d%d%d%d%s%s%s%s%d%s%d%s%d > > %s%d > > %s%s%d%s%d%s%s%s%s%d%s%d%s%s%d%d%s%s%d%s%d%s%s%d%s%d%d%s%s%s%s%d%s%s%s%s%d%d > > %s%s > > %s%d%s%d%s%s%d%d%d%d%d%s%s%s%s%s%s%s%d%d%d%s%d%s%d%d%s%d%d%d%s%s%d%d%d%s%s%d > > %s%d > > %s%s%s%d%d%d%s%d%s%s%d%s%d%s%s%d%s%d%d%s%d%s%s%d%s%s%s%s%s%d%s%d%d%d%s%d%d%d > > %d%s > > %d%s%d%d%d%s%s%s%s%s%d%s%s%s%s%d%d%d%s%d%s%d%d%s%d%s%s%d%d%d%s%d%s%d%d%s%s%s > > %d%s > > %s%d%d%d%d%d%d%d%d%d%d%s%d%s%d%s%d%d%s%d%d%s%d%s%s%s%d%d%d%d%s%s%d%d%s%d%d%d > > %s%d > > %d%s%d%d%d%d%s%s%d%s%s%d%d%d%s%s%s%s%s%s%s%s%s%d%s%d%d%s%d%s%s%d%s%s%s%s%d%d > > %d%d > > %s%d%s%s%d%d%d%s%d%d%d%s%s%s%s%d%d%d%s%d%s%d%s%d%d%d%d%d%d%d%d%d%d%s%s%d%d%d > > %s%d > > %d%d%s%s%s%s%s%s%s%d%d%d%d%s%s%d%s%s%d%s%s%s%s%d%d%s%d%d%s%d%d%s%d%d%d%s%s%s > > %s%d > > %s%s%d%s%d%s%d%s%d%d%d%d%s%d%d%d%s%d%d%d%d%s%s%d%s%s%d%d%d%s%d%s%d%d%d%d%d%d > > %s%d > > %s%s%d%d%s%d%d%d%s%s%d%s%d%s%d%s%d%d%s%d%s%s%s%s%s%d%s%s%d%d%d%s%s%d%d%s%s%d > > %s%d > > %s%d%s%s%s% > > [  833.044728] ------------[ cut here ]------------ > > [  833.137184] precision 60612 too large > > >