Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7179189imu; Wed, 14 Nov 2018 13:03:03 -0800 (PST) X-Google-Smtp-Source: AJdET5c9cKKbDiI58I+q1jiYajCc4LjP6guRJVYbGnoEzIV204iNPDLWqd5H7d49TlROrYXyzWIe X-Received: by 2002:a63:dd55:: with SMTP id g21mr3155299pgj.86.1542229383467; Wed, 14 Nov 2018 13:03:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542229383; cv=none; d=google.com; s=arc-20160816; b=DMDA6PSRFGVQ4P2k+DL20YwI9fKnnr9rGMwy5xGAMOdrhelq5cvBcL57U66ZVsVvul BSnSywc9onKNj0S4ROz/5CJ1K/tMXxUEfoP4Qnis0iYbYD86O77KGiTLk8n89uDHHVjv AaEKyPOijkoKhkndgfNMnEoQgSSsZaFpL7wbYYSkvPHMLHbGUoBXQFueyPuHxQlFlO/M GKQeeiTshL9RgjSV7evMVWne5qSkM9rvzsTIHspEIdlbj1WgDFmAl2o638UBrWKSlngi SLCUI3f/5fm34GCBGOW+X9Uw4ZauTqEP5gRrm4UM5cDpC71sRkMUWTn0Q5e07DKmw02b UIfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gMDJMxcSVeCSfl0yWED9XXLqAuhEDPvaYjWR5T5eBRI=; b=UE0SLrfxAIDmHy0p2Z4Dn7g+nffmHamAudV7xxPMdmTeq0VDZkolq3c15i0maJ3kf4 58k+Hgffrme79ZYgepsHErADXMOXsQ82VQLrnGwJwhlSYpeS1kl/0+VbYn1KMcQNOvVD BwetRanw74wT0CyZd1Brudq0KGa/TiQa0JqYkUcon2wyazUd+qP1lhi6U18m+rKWAwg5 db7S5ZjjRlsMCwLDsLhhKUtKQSj23NkJIbGbY4mmdMatYbiyZJDGk8dUuKydEsIElCVM gtUWZ+hCYSAcQBf8LZrZzBwGDsw+B4tFVKKUZp4A0NjRsJGvtm2Z/SY+ra6Z6Z9JJSiz sr9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7si10849159plz.118.2018.11.14.13.02.44; Wed, 14 Nov 2018 13:03:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727763AbeKOHHL (ORCPT + 99 others); Thu, 15 Nov 2018 02:07:11 -0500 Received: from mga12.intel.com ([192.55.52.136]:44377 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725756AbeKOHHL (ORCPT ); Thu, 15 Nov 2018 02:07:11 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 13:02:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,233,1539673200"; d="scan'208";a="85854486" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by fmsmga007.fm.intel.com with ESMTP; 14 Nov 2018 13:02:21 -0800 Date: Wed, 14 Nov 2018 13:58:55 -0700 From: Keith Busch To: Alex_Gagniuc@Dellteam.com Cc: helgaas@kernel.org, oohall@gmail.com, gregkh@linuxfoundation.org, mr.nuke.me@gmail.com, linux-pci@vger.kernel.org, Austin.Bolen@dell.com, Shyam.Iyer@dell.com, linux-kernel@vger.kernel.org, jonathan.derrick@intel.com, lukas@wunner.de, ruscur@russell.cc, sbobroff@linux.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2] PCI/MSI: Don't touch MSI bits when the PCI device is disconnected Message-ID: <20181114205855.GF11416@localhost.localdomain> References: <20181108225109.GA3023@kroah.com> <16bf9d14bc5f4a90b2b88dd2eb165186@ausx13mps321.AMER.DELL.COM> <5da8d8aa9f3818af649b1ac547bc4e6062626ddf.camel@gmail.com> <20181113050240.GA182139@google.com> <19136f44cd5c45e79bbef7e78a6bf332@ausx13mps321.AMER.DELL.COM> <20181114055956.GA144931@google.com> <1eb0fa27924f426992715684f5e63346@ausx13mps321.AMER.DELL.COM> <20181114202333.GE11416@localhost.localdomain> <644fd16cf02c4fe5b7e250c226c80f2e@ausx13mps321.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <644fd16cf02c4fe5b7e250c226c80f2e@ausx13mps321.AMER.DELL.COM> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 14, 2018 at 08:52:10PM +0000, Alex_Gagniuc@Dellteam.com wrote: > But it does in portdrv_core.c: > > if (dev->aer_cap && pci_aer_available() && > (pcie_ports_native || host->native_aer)) { > services |= PCIE_PORT_SERVICE_AER; > > That flag later creates a pcie device that allows aerdrv to attach to. Oh, right. I saw negotiate_os_control() just uses a stack variable for the _OSC response, but if I had looked one level deeper, I'd see it cached in a different structure.