Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7196831imu; Wed, 14 Nov 2018 13:19:22 -0800 (PST) X-Google-Smtp-Source: AJdET5eI/B2KlMu9VunqSfwUdH0DGaX4i61HBcBVDDw799uY+IfMxheAXqckcNjg8uQ4t3DAVOAt X-Received: by 2002:a63:78cd:: with SMTP id t196mr3283592pgc.62.1542230362769; Wed, 14 Nov 2018 13:19:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542230362; cv=none; d=google.com; s=arc-20160816; b=hmiBASmlQNtLomlfUdKhG0mEmGAEaDjdwSVcm425aMBb1sI6a15vJOAxJGNjuHQp3I s/5uUXIvGNNfezWAJ2lZ1Xs6XF7iseqwT+az2STnQajT7f1qVitjCjAfgevHmYs9+hxC 2hlSPLMiSfQXVOHO1506l6iPq7nc9HJLrFjn8tfe1bzz5gVqo7KTbdqMvhIhuJgdEIVm 4cfAjhJUrzrPV8KAB+I7uthckZ6hCetqIga6pS87hPcJrI9b8nvF7XvSSRaXCrYXM+V1 5PBDQwcidenN0VhYwUmWpDAHuN0Kp2tYlfNnRHf1mBExa0sChic4theMxy+uJV5a2w0s 0+sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=TJailTWNXQpNDYEy03pHugK1Dve9JS7oIcI0CbKyKdw=; b=jS23Tonlo6RNqKWhZhf2Kmp66wBxwa+vsZE0Cimv1cKHNbToMzRrCOtr6GBb/6yZ5+ En1VD4TZMq4znkjJvDvBm092trKDmu2gFknF/dewyrGpO3xltmowZcYTnPC7o4E24mKH +6IEF6Y7vStEmoQ9XUed4tgekAlr1GwEwhK5QqAVzAwyokN6fUjQh8BSjuJx3oHrPN0z 4MhkqLu+R3tXGikNHLq0UsTm3N8d4Dw6nmLtBWtN8y3CzRFSFtmBMlYi8Dn93ySBa9kz I+EsJDhZe2zsv3XtBz2IfrTw3ZOXYOzXlsSjAiVIDr9NVlErsFgek6Kru9UelvcqkpKR S/Sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si22531492pgl.485.2018.11.14.13.19.07; Wed, 14 Nov 2018 13:19:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733228AbeKOHXE (ORCPT + 99 others); Thu, 15 Nov 2018 02:23:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42758 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbeKOHXD (ORCPT ); Thu, 15 Nov 2018 02:23:03 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 84CCF3154852; Wed, 14 Nov 2018 21:18:11 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-99.ams2.redhat.com [10.36.116.99]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA65B5C8A4; Wed, 14 Nov 2018 21:17:58 +0000 (UTC) From: David Hildenbrand To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devel@linuxdriverproject.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org, xen-devel@lists.xenproject.org, David Hildenbrand , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Kairui Song , Vitaly Kuznetsov , Andrew Morton , Matthew Wilcox , Michal Hocko , "Michael S. Tsirkin" Subject: [PATCH RFC 5/6] hv_balloon: mark inflated pages PG_offline Date: Wed, 14 Nov 2018 22:17:03 +0100 Message-Id: <20181114211704.6381-6-david@redhat.com> In-Reply-To: <20181114211704.6381-1-david@redhat.com> References: <20181114211704.6381-1-david@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 14 Nov 2018 21:18:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark inflated and never onlined pages PG_offline, to tell the world that the content is stale and should not be dumped. Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Cc: Kairui Song Cc: Vitaly Kuznetsov Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- drivers/hv/hv_balloon.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 5728dc470eeb..778b6f879d1c 100644 --- a/drivers/hv/hv_balloon.c +++ b/drivers/hv/hv_balloon.c @@ -681,8 +681,13 @@ static struct notifier_block hv_memory_nb = { /* Check if the particular page is backed and can be onlined and online it. */ static void hv_page_online_one(struct hv_hotadd_state *has, struct page *pg) { - if (!has_pfn_is_backed(has, page_to_pfn(pg))) + if (!has_pfn_is_backed(has, page_to_pfn(pg))) { + if (!PageOffline(pg)) + __SetPageOffline(pg); return; + } + if (PageOffline(pg)) + __ClearPageOffline(pg); /* This frame is currently backed; online the page. */ __online_page_set_limits(pg); @@ -1200,6 +1205,7 @@ static void free_balloon_pages(struct hv_dynmem_device *dm, for (i = 0; i < num_pages; i++) { pg = pfn_to_page(i + start_frame); + __ClearPageOffline(pg); __free_page(pg); dm->num_pages_ballooned--; } @@ -1212,7 +1218,7 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm, struct dm_balloon_response *bl_resp, int alloc_unit) { - unsigned int i = 0; + unsigned int i, j; struct page *pg; if (num_pages < alloc_unit) @@ -1244,6 +1250,10 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm, if (alloc_unit != 1) split_page(pg, get_order(alloc_unit << PAGE_SHIFT)); + /* mark all pages offline */ + for (j = 0; j < (1 << get_order(alloc_unit << PAGE_SHIFT)); j++) + __SetPageOffline(pg + j); + bl_resp->range_count++; bl_resp->range_array[i].finfo.start_page = page_to_pfn(pg); -- 2.17.2