Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7385926imu;
        Wed, 14 Nov 2018 16:46:52 -0800 (PST)
X-Google-Smtp-Source: AJdET5cnOcTb0S6u9oLqc7EXCHwTwzMoB94G5Qx8NwRJxjHZEQEI5NKhpcCwu8HaWb7waLkZkkI+
X-Received: by 2002:a62:ca12:: with SMTP id n18-v6mr4165085pfg.191.1542242812070;
        Wed, 14 Nov 2018 16:46:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1542242812; cv=none;
        d=google.com; s=arc-20160816;
        b=vtGzHF66f7vg/IBnwF8A6hE6F4e/rpAC31tmaL0vMs32Ld5Kha4Xzryk1GSPUAWEfD
         FM0qc1mJRz+rwSUzvdUYzWKQx348ZXcElOWe9qQe5uzwjp+3VF4DIcuFPf5QIWQDS/Dw
         G0FrKELV60avfPLT3vdtyrWpr3kzF+yUamUAyidiEjhLXieOz50AlCRhlFB0OiTYMQlh
         O5qmmOjXKs2jIlHcUnyztlwxbr7I27ZCG6QbZjqW+QnmeR0wPJBwF4A+MbFOjvviB9ic
         UE17j6Yl87/sk/GS0DrMSyQEflLltf7XHo+9/Dq4Gc9F+leKOOfGOtcJLYU2menbD8+G
         4rSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=U41ZC4geVVvMHx+mM0ibMk8kLN4aKbTJsEDe/zn0p8E=;
        b=KqDlLnJUcyQMScEbtB+VqUkUOF3jmNhKRpaTOuGEy9Iuul+wo/WDWZsGgGS0hPfCgK
         TJ0VsV1pvPaDHmRaCkNZez8ppg7acGfa+kK9aDnBZaFlP6iBSAOI0ssdqayZ3gg5lipK
         l1jwfuvE73XDR9L2PCmaxxlnQ4/XW1GohFLuMpEMBlEkeb04zZCPkwVWvCy8bEpiqSFh
         JDCLqwIPWDxOR20ZzDvS1KXU9JbJJEG0vXiQLcyiyDmcsJgwvqoLaTD3xio0KTPTbOAF
         dpeuCMPiel9a66PDEPJyesL+DxwUWS+EbkmDT8k5g/xHPBe+DBY3iYJn/q0RNLy6urQD
         GHAw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=GzZBuqL4;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t129-v6si29437741pfb.16.2018.11.14.16.46.36;
        Wed, 14 Nov 2018 16:46:52 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=GzZBuqL4;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726774AbeKOKvf (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Thu, 15 Nov 2018 05:51:35 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:17770 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726169AbeKOKve (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Nov 2018 05:51:34 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5becc1b40001>; Wed, 14 Nov 2018 16:45:40 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Wed, 14 Nov 2018 16:45:59 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Wed, 14 Nov 2018 16:45:59 -0800
Received: from ngvpn01-165-105.dyn.scz.us.nvidia.com (172.20.13.39) by
 HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id
 15.0.1395.4; Thu, 15 Nov 2018 00:45:58 +0000
Subject: Re: [PATCH v2 1/6] mm/gup: finish consolidating error handling
To:     Dan Williams <dan.j.williams@intel.com>,
        Keith Busch <keith.busch@intel.com>
CC:     John Hubbard <john.hubbard@gmail.com>,
        Linux MM <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>
References: <20181110085041.10071-1-jhubbard@nvidia.com>
 <20181110085041.10071-2-jhubbard@nvidia.com>
 <20181112154127.GA8247@localhost.localdomain>
 <CAPcyv4j7nqLOFD5dZEe_nBysHDL2pQ-tRO9Crp9oyTUP7RoDHw@mail.gmail.com>
X-Nvconfidentiality: public
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <da9907a9-3150-15c3-fb4e-460d63fc5a1f@nvidia.com>
Date:   Wed, 14 Nov 2018 16:45:57 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <CAPcyv4j7nqLOFD5dZEe_nBysHDL2pQ-tRO9Crp9oyTUP7RoDHw@mail.gmail.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1542242741; bh=U41ZC4geVVvMHx+mM0ibMk8kLN4aKbTJsEDe/zn0p8E=;
        h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=GzZBuqL4r/IJGkNkt6V/OS+Ux1QM/aTE0rMWXi3EuNiuEtY7nFf4+yd55BDI7NlGR
         HLZ91Tdv7B4Bltq2nkDxTt/IjsYv7XbXDdgi1MGoQjsheAPRxsgjSQbYdninpSjiOZ
         HERSO38iJ26AOsOKYIdxl4aT2evEY3jfd2R7UV1W25Avb6SCxoP6koaPxKArgrEqqC
         YKCzzU+yTF7kdpw2IM6qgGd5aFeBlbvl/Lo8kIs46O9hrMuTBWnC+dzShUPy8ksls+
         drY0oszsCrL1ZdGyLVn33voz2oR7nUAMLOO2acs3OIu16ZNMQGYZvQuP1iLcwvAaW1
         EhELCoeq2wl5A==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/12/18 8:14 AM, Dan Williams wrote:
> On Mon, Nov 12, 2018 at 7:45 AM Keith Busch <keith.busch@intel.com> wrote:
>>
>> On Sat, Nov 10, 2018 at 12:50:36AM -0800, john.hubbard@gmail.com wrote:
>>> From: John Hubbard <jhubbard@nvidia.com>
>>>
>>> An upcoming patch wants to be able to operate on each page that
>>> get_user_pages has retrieved. In order to do that, it's best to
>>> have a common exit point from the routine. Most of this has been
>>> taken care of by commit df06b37ffe5a4 ("mm/gup: cache dev_pagemap while
>>> pinning pages"), but there was one case remaining.
>>>
>>> Also, there was still an unnecessary shadow declaration (with a
>>> different type) of the "ret" variable, which this commit removes.
>>>
>>> Cc: Keith Busch <keith.busch@intel.com>
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>>> Cc: Dave Hansen <dave.hansen@intel.com>
>>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>>> ---
>>>   mm/gup.c | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/mm/gup.c b/mm/gup.c
>>> index f76e77a2d34b..55a41dee0340 100644
>>> --- a/mm/gup.c
>>> +++ b/mm/gup.c
>>> @@ -696,12 +696,11 @@ static long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,
>>>                if (!vma || start >= vma->vm_end) {
>>>                        vma = find_extend_vma(mm, start);
>>>                        if (!vma && in_gate_area(mm, start)) {
>>> -                             int ret;
>>>                                ret = get_gate_page(mm, start & PAGE_MASK,
>>>                                                gup_flags, &vma,
>>>                                                pages ? &pages[i] : NULL);
>>>                                if (ret)
>>> -                                     return i ? : ret;
>>> +                                     goto out;
>>>                                ctx.page_mask = 0;
>>>                                goto next_page;
>>>                        }
>>
>> This also fixes a potentially leaked dev_pagemap reference count if a
>> failure occurs when an iteration crosses a vma boundary. I don't think
>> it's normal to have different vma's on a users mapped zone device memory,
>> but good to fix anyway.
> 
> Does not sound abnormal to me, we should promote this as a fix for the
> current cycle with an updated changelog.
> 

Andrew, should I send this patch separately, or do you have what you 
need already?

thanks,
-- 
John Hubbard
NVIDIA