Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Rafael J. Wysocki" <rjw@rjwysocki.net>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        Doug Smythies <dsmythies@telus.net>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [RFC/RFT][PATCH v5] cpuidle: New timer events oriented governor for tickless systems
Date:   Thu, 15 Nov 2018 03:57:05 +0100
Message-ID: <13917501.YLdTytznDL@aspire.rjw.lan>
In-Reply-To: <20181111152034.GC3021@worktop>
References: <102783770.7hZjAahU8c@aspire.rjw.lan> <20181111152034.GC3021@worktop>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sunday, November 11, 2018 4:20:34 PM CET Peter Zijlstra wrote:
> On Thu, Nov 08, 2018 at 06:25:07PM +0100, Rafael J. Wysocki wrote:
> > +/*
> > + * The SPIKE value is added to metrics when they grow and the DECAY_SHIFT value
> > + * is used for decreasing metrics on a regular basis.
> > + */
> > +#define SPIKE		1024
> > +#define DECAY_SHIFT	3
> 
> > +	if (idx_timer >= 0) {
> > +		unsigned int hits = cpu_data->states[idx_timer].hits;
> > +		unsigned int misses = cpu_data->states[idx_timer].misses;
> > +
> > +		hits -= hits >> DECAY_SHIFT;
> > +		misses -= misses >> DECAY_SHIFT;
> > +
> > +		if (idx_timer > idx_hit) {
> > +			misses += SPIKE;
> > +			if (idx_hit >= 0)
> > +				cpu_data->states[idx_hit].early_hits += SPIKE;
> > +		} else {
> > +			hits += SPIKE;
> > +		}
> > +
> > +		cpu_data->states[idx_timer].misses = misses;
> > +		cpu_data->states[idx_timer].hits = hits;
> > +	}
> 
> That's a pulse-density-modulator, with a signal bound of:
> 
>   1024 == x/8 -> x := 8192
> 
> Anyway; I would suggest s/SPIKE/PULSE/ because of that.

OK