Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8007090imu; Thu, 15 Nov 2018 05:13:56 -0800 (PST) X-Google-Smtp-Source: AJdET5f+0muGQsyf0AVTqOi68t1WipnhrPHH/IuhhRHzJuT1Ee80nEkb0fTTW5WechJZQBr/fQor X-Received: by 2002:a63:89c2:: with SMTP id v185mr5332162pgd.97.1542287636504; Thu, 15 Nov 2018 05:13:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542287636; cv=none; d=google.com; s=arc-20160816; b=Nh4fGX3OAxEW92GofOXvrY7+aWj3LWb/p6XTojOVw2ptmsyIc02v72HoxibtQWal+5 jas4sgs06rMQEXAn7l6l+04ACqkQLZTQQ+NSZ43aOEq3a3VQYjxkONGiwtZQx7oCGLK/ IBq5hhkNZn0BPMYAcE94zkeSgU2iyoXloMKrZ3Q/yEga1k2qyMmDJNKWhFIbmOQKrKco uFIVshobB9OOnNBZ0Zkf0v3sk8ZfsKeUrKIcY1xLOmpCjgubxnPnpEgqMdr+tVY6oOnE 1KKFk2Gs6+B71BbvdTEDW4Aks6dsOrxUcUqEudKis83gYWCN9BpXJiSQS1XBnT3QCT3h 2Lvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=T6xzz+gBqeR8mKqEFX/4clne7ech8PZpksbUMj+Ez18=; b=Ipo5KPgp4noWy9sbiXGTYbb1X5vP+lRKPljnt+QO9psIn/IP3+xoEbVP5h1QCBVv8B BI2b//O56vzfG4IBp6dMTwnH941bbynhZc5p4Wjpv5W5bmSuMOkjp6K5iXiFw+nVZ+ZQ bhuAu/dDeCqt1ECUTX3tDbbMFkrIeLFih2pA2e9ddAoOoF+c3Y4mfx82LO/4FXYqfMoH m7dGs5so628zNJgCa/9W2HPm0ff3ddwvbVm9Mk0XIduTqcDPTu19xo1nKP0yX6kJwWg+ LS4j/C1W7ebtVR2obK3AOFes8NEdn3iM5LU+L1Sw1CnqCDez4t294ip2fwF3ssl8Csg5 s/7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w31-v6si28498569pla.347.2018.11.15.05.13.40; Thu, 15 Nov 2018 05:13:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388261AbeKOXUn (ORCPT + 99 others); Thu, 15 Nov 2018 18:20:43 -0500 Received: from mail.bootlin.com ([62.4.15.54]:40403 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729010AbeKOXUn (ORCPT ); Thu, 15 Nov 2018 18:20:43 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 41A5B20752; Thu, 15 Nov 2018 14:12:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from bbrezillon (aaubervilliers-681-1-13-146.w90-88.abo.wanadoo.fr [90.88.134.146]) by mail.bootlin.com (Postfix) with ESMTPSA id DE8DE20510; Thu, 15 Nov 2018 14:12:52 +0100 (CET) Date: Thu, 15 Nov 2018 14:12:52 +0100 From: Boris Brezillon To: Schrempf Frieder Cc: Yogesh Narayan Gaur , "linux-mtd@lists.infradead.org" , "linux-spi@vger.kernel.org" , Marek Vasut , Mark Brown , Han Xu , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "richard@nod.at" , "miquel.raynal@bootlin.com" , David Wolfe , Fabio Estevam , "Prabhakar Kushwaha" , "shawnguo@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 3/9] spi: Add a driver for the Freescale/NXP QuadSPI controller Message-ID: <20181115141252.52a5b32d@bbrezillon> In-Reply-To: <3e9aa917-cf3a-cf0e-8516-4e73d30eb2a1@kontron.de> References: <1542116782-13118-1-git-send-email-frieder.schrempf@kontron.de> <1542116782-13118-4-git-send-email-frieder.schrempf@kontron.de> <65577d13-b17d-8f69-313c-01d23240d1d9@kontron.de> <3e9aa917-cf3a-cf0e-8516-4e73d30eb2a1@kontron.de> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Nov 2018 11:43:05 +0000 Schrempf Frieder wrote: > On 15.11.18 07:22, Yogesh Narayan Gaur wrote: > > Hi Frieder, > > > > With below patch on top of your v5, Read/Write/Erase on CS1 is working fine for me. > > Ok, are you sure, that AHB read is working too with this patch? > You are removing the memmap_phy offset from SFAR and the SFXXAD register > values. > > I can understand that selection of the CS and IP commands will work like > this, but I can't understand how AHB read should work without the base > address of the mapped memory. > > I'm afraid I still don't fully understand the background of these > things, Same here. Yogesh, can you give us more detail on why you decided to drop the memmap_phy offset? > but still thank you for testing. >