Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   valdis.kletnieks@vt.edu
To:     Pintu Agarwal <pintu.ping@gmail.com>
Cc:     open list <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Russell King - ARM Linux <linux@armlinux.org.uk>,
        kernelnewbies@kernelnewbies.org, jungseoklee85@gmail.com,
        catalin.marinas@arm.com, will.deacon@arm.com,
        takahiro.akashi@linaro.org, mark.rutland@arm.com,
        barami97@gmail.com
Subject: Re: [ARM64] Printing IRQ stack usage information
In-Reply-To: <CAOuPNLiLj9be5iUdpUiLqiTge-xYY_v4_VLs-ah2_PygG7vxdg@mail.gmail.com>
References: <CAOuPNLiLj9be5iUdpUiLqiTge-xYY_v4_VLs-ah2_PygG7vxdg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1542300549_2379P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Thu, 15 Nov 2018 11:49:09 -0500
Message-ID: <28496.1542300549@turing-police.cc.vt.edu>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1542300549_2379P
Content-Type: text/plain; charset=us-ascii

On Thu, 15 Nov 2018 18:52:39 +0530, Pintu Agarwal said:

> Currently, when I tested this (as a proc interface), I got the below output:
> CPU    UNUSED-STACK    ACTUAL-STACK
>  0         16368                     16384

> 3) How should I test it to get the different usage values for unused stack ?
>     Can I get these values by implementing a sample interrupt handler,
> and printing information from there?

Hint 1:  If you're in a state where seq_printf() is legal, how many IRQ's are
on this processor's IRQ stack?

Hint 2:  What are the chances that some other CPU is currently in an IRQ?
(run 'top' and look for what percent of time that's happening)

Hint 3: what are the chances that the value of irq_stack_ptr is already stale
by the time seq_printf() finishes running?

Hint 4: what happens to the validity of your output if you get rescheduled
in the middle of that for_each loop?

(In other words, this code is terribly racy and is probably not going to answer
whatever debugging question you were working on..  If your question is "Did one
of the CPUs blow out its IRQ stack (or come close to doing so)?" there's better
approaches.


--==_Exmh_1542300549_2379P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQEVAwUBW+2jhY0DS38y7CIcAQJbXAf/Tzi661RNRip58FF5Idc+J3pchStOvO5N
wYs3oy48KyG/cR71n8Ypwg6Lt5YKS13l/mrO17as+fwJwTMtTYJ5nZVUQVWQZEkE
ME1vBAMmE/Xs1uBTwuy+Hnxi525xIKXE74iM9qChoRer2+VM9fTo7uCY3KcrGFRq
RzTh2GkosxuzYdLM5w3wLEo1Y46egkCCKYPH+SfohiFdnn1m40LyinF5y+OSH6xZ
ZJw0RUWEbJ0SZu5XHyEKVzeW9xXPluDvv13QC/qaTrUeGgzY6/lu4Gnp56rYDhLy
aiQluwSzLN5Egl45pQlFz3oYa1Qg+ujSay7x7xlWJPKrdgNZWE4Nzw==
=N6Jk
-----END PGP SIGNATURE-----

--==_Exmh_1542300549_2379P--