Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8271107imu; Thu, 15 Nov 2018 09:02:47 -0800 (PST) X-Google-Smtp-Source: AJdET5e6Qjq325HQw7Croykiy95ELFV2k33/bHreK40PikKEpT0XZ8u7Jzuzs1bPaThIz7PAZfyY X-Received: by 2002:a62:2681:: with SMTP id m123-v6mr7147491pfm.131.1542301367721; Thu, 15 Nov 2018 09:02:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542301367; cv=none; d=google.com; s=arc-20160816; b=0ALqlR6TcXp+KHneMOr/oVieCdrbEeqe9VqNbTuKsfDr8JJsjvttbydBzXAbABCkMa xF6y9WcYGTl13RCePqfEUl6mNBoPCeJUhwWhtSss3d8DlQSYA2ymSc3NR/kOgL9aUdHE /jSJzfRIstg/SGyqdlFXE0woY5Z4lhc0IunS7H2Rz7qy01O0XglY5nkFgAfJU/4ZRDAl jnXcSVWFU98iJbn6dI0382cBk6KImW2qa/tqeW/HjzPtiDIbVB0JGwHQTh7sPGaqRGis fFYOxHGtdK1baw94v9wJlsRE3CTWLn/vieFNi1xRvrM0AZwEt8/YbPvqxLaueM6sbw+l 33ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=e3XYaeGbGXkUVPfXmZDIkJa6BQXB6yz56CJfZigHIoM=; b=uPOuztALhBxoj4jnrTz4hxdFqv1mJa0sKkc+K1tHaBQMryDwMQyibYprffo0C9QwqM iP1qVcWX+e8ty9E4eCl3teJwvwOygqIM2wbWMnpWPklvQA01OnRyh/y8oLmwsdeb2zD4 gRMqs/x3dlq3kuYtINc99we51S3jUhNwY3NnfSUdORBfsvlXBOQQ/yWmCkfeEEXBteLJ JsMu7mYlmRbFhZowXrNyOvL68XjqibWYREGplkjJYEpnZ3o/2HUV4rmSD0LUsGPIPH4J ViYiBhVm3ug1EqUFxrbcuklsh0h3DyBuNqH+lfTymaCO95lsrq3CHbwNIHeNjWoAOJ9g ch5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nWCN+e5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h128si10710092pfe.204.2018.11.15.09.02.26; Thu, 15 Nov 2018 09:02:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=nWCN+e5p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388416AbeKPDKU (ORCPT + 99 others); Thu, 15 Nov 2018 22:10:20 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:46652 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbeKPDKT (ORCPT ); Thu, 15 Nov 2018 22:10:19 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wAFH1W9T102147; Thu, 15 Nov 2018 11:01:32 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1542301292; bh=e3XYaeGbGXkUVPfXmZDIkJa6BQXB6yz56CJfZigHIoM=; h=From:To:CC:Subject:Date; b=nWCN+e5pm+W1CJxeAFmkcacxFyCPSQYr4XUr72narpcSlPmU5nsPKq0iC0dubSruv OpuBOtOJOwWuij0LFyc7eXkceaKmti74U00A8h2nK5RVdp9bVb9K+KcclQKfEHUMPZ OzjpLRp5EqvH1CyglyFkES4zV7obljiIHVEyF1/A= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wAFH1WIC016201 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 15 Nov 2018 11:01:32 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 15 Nov 2018 11:01:32 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 15 Nov 2018 11:01:32 -0600 Received: from jiji.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id wAFH1WIt014400; Thu, 15 Nov 2018 11:01:32 -0600 From: Andreas Dannenberg To: Mark Brown CC: Andreas Dannenberg , , , Stephane Le Provost , Andrew F Davis Subject: [PATCH] ASoC: pcm186x: Fix device reset-registers trigger value Date: Thu, 15 Nov 2018 11:01:31 -0600 Message-ID: <20181115170131.1839-1-dannenberg@ti.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the current device datasheet (TI Lit # SLAS831D, revised March 2018) the value written to the device's PAGE register to trigger a complete register reset should be 0xfe, not 0xff. So go ahead and update to the correct value. Reported-by: Stephane Le Provost Tested-by: Stephane Le Provost Signed-off-by: Andreas Dannenberg --- sound/soc/codecs/pcm186x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm186x.h b/sound/soc/codecs/pcm186x.h index 2c6ba55bf394..bb3f0c42a1cd 100644 --- a/sound/soc/codecs/pcm186x.h +++ b/sound/soc/codecs/pcm186x.h @@ -139,7 +139,7 @@ enum pcm186x_type { #define PCM186X_MAX_REGISTER PCM186X_CURR_TRIM_CTRL /* PCM186X_PAGE */ -#define PCM186X_RESET 0xff +#define PCM186X_RESET 0xfe /* PCM186X_ADCX_INPUT_SEL_X */ #define PCM186X_ADC_INPUT_SEL_POL BIT(7) -- 2.15.1