Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8371912imu; Thu, 15 Nov 2018 10:26:45 -0800 (PST) X-Google-Smtp-Source: AJdET5coOpy7JFgCJuem20Abmjq/SevuR45fQoUMybwPqnnFbBh60FW9NUI2iYgoKNq9Ps1TZCni X-Received: by 2002:a62:13c3:: with SMTP id 64mr7543023pft.93.1542306405521; Thu, 15 Nov 2018 10:26:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542306405; cv=none; d=google.com; s=arc-20160816; b=rbcN7CAJ7Rj7OKivW9QrOwsInceTqV1FeiuX1EOH/PFJQRF/z8UkW8ShvZqHGw2/1c CffkRhN/oywpoXqjsha+qTiemFGsWTWaGPRWAAWQo3L094YwaNJ4T04l6tDq8hU+zkN7 gCzhIfvUn9u4wM7n8wh7N1fVktyRtodATGHXMkn2lHvmtPNZ64Bvhnleq6kbH69gRXQ3 fy5d5rKm7dN+R6U5TFZdy6CiFH+HtJiux56rSCbUODZRJnCUOAO+PszRYlsPwha4puiw PEsWqzag3k8DJc2Wt3W1Y5TzYTbbRaWZFgq5zG+YudGVmN/XtR/Oz96AuuHxYmgUisbJ qtjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=SWGsYY2WBAue45wXSHggFPHaeGjGKdWGIkOcDsY+UOY=; b=zMgkNKWsgFN72drM/w/JSaJb6kq4iiLmZcZSHCbApnhmtAI09sgf2anjXuBGmKwEY/ N+yL2wBPo8RyGiMfBDSiuntpd5NPZbDy3+K7Ic+1eLYQAgGzOb2HDXu/JGUaziADS6ya drAalcTtBmuOpZJLlBBqRGxgivMEp3yKA7pi/xlnap7rimmGWMl+l8yd/rCBPBSTydgT yAhxCtLQ3OIIDiUh93CODA+TNSapAI6e2c9Ckv8AggZ1gTgaEEaza+zLXnGPN07Puzhl FTVyyEXqhbNBK5QmMnjCWi12DEVodj9UDDj/K0hhPMTveBwuJyS2M2q0zGeshys3dUhN o0aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T9rslgN2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n10-v6si15238588plk.255.2018.11.15.10.26.30; Thu, 15 Nov 2018 10:26:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T9rslgN2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388816AbeKPEd4 (ORCPT + 99 others); Thu, 15 Nov 2018 23:33:56 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:35843 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387839AbeKPEd4 (ORCPT ); Thu, 15 Nov 2018 23:33:56 -0500 Received: by mail-yb1-f194.google.com with SMTP id g192-v6so8757235ybf.3 for ; Thu, 15 Nov 2018 10:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SWGsYY2WBAue45wXSHggFPHaeGjGKdWGIkOcDsY+UOY=; b=T9rslgN2HwFUWbjSTY+ZqTYxgUQtofr4FviGU6KmUiH6kDl92awST4i7QEiXhtk9dJ hItPPXj/VgMD/5nMT5evd/QqbhdHxUOIvioCQ56ya099sxsTlSHjiuZlfIQKMMyk7chD DPq532u0HS+dv6cDtNYE3eA9txaSl8r0Iuf74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SWGsYY2WBAue45wXSHggFPHaeGjGKdWGIkOcDsY+UOY=; b=HcioOvzxVtWrVtlGA7fdl990xlfDaoapZqyq0z6w4MMmKDT1lnjqYvEOXblTwBoYT8 7cFcfh+3HGm6BZ1cnBQUmOFzzs4I0JoBFJXUN0aroOV8j02dxzSHcTrLDTnbAqZRpiZP Xqxh4v+kkw1eO4/UvaiPGj4CBJKSrjsFm3wyj5hNA20XBqsjMJHbDfjW+s/UkQBiilUv prYM30rdf28hKodONlwk540nBgYy7IOXAOlxGKylnRd451UGIBoSYCu/24nCUP4/kJlM A7RHJdyJCGo9lXN5iPJ1SQSfQfZDmHm74sn6OOhIOl5msoLFzUE/2CzW9e4iIBwIfcLv YPNA== X-Gm-Message-State: AGRZ1gKJZwm/qJjSd0JP1M9uWow4vfLFt9LudUzM3PwECs8YVcfiK8/B XB3wLA4OTXQpEzxva9Xri7GIa4wo1ebEdA== X-Received: by 2002:a25:c695:: with SMTP id k143-v6mr6750908ybf.171.1542306301736; Thu, 15 Nov 2018 10:25:01 -0800 (PST) Received: from mail-yw1-f50.google.com (mail-yw1-f50.google.com. [209.85.161.50]) by smtp.gmail.com with ESMTPSA id n66-v6sm1259232ywe.37.2018.11.15.10.25.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 10:25:00 -0800 (PST) Received: by mail-yw1-f50.google.com with SMTP id h32so2975896ywk.2 for ; Thu, 15 Nov 2018 10:25:00 -0800 (PST) X-Received: by 2002:a0d:e984:: with SMTP id s126-v6mr6879709ywe.47.1542306299729; Thu, 15 Nov 2018 10:24:59 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:b906:0:0:0:0:0 with HTTP; Thu, 15 Nov 2018 10:24:58 -0800 (PST) In-Reply-To: <20181109151520.GD3645@cisco> References: <20181102201822.12518-1-tycho@tycho.ws> <20181107222042.GA24927@redhat.com> <20181109151520.GD3645@cisco> From: Kees Cook Date: Thu, 15 Nov 2018 12:24:58 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] dlm: fix various incorrect behaviors To: Tycho Andersen Cc: David Teigland , Christine Caulfield , cluster-devel@redhat.com, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 9, 2018 at 9:15 AM, Tycho Andersen wrote: > On Wed, Nov 07, 2018 at 04:20:42PM -0600, David Teigland wrote: >> On Fri, Nov 02, 2018 at 02:18:19PM -0600, Tycho Andersen wrote: >> > Hi, >> > >> > here's a series to fix some bugs I noticed in the DLM. The third patch >> > in the series and maybe the first should probably go to stable, assuming >> > everyone agrees they're indeed bugs. >> > >> > Thanks, >> > >> > Tycho >> > >> > Tycho Andersen (3): >> > dlm: fix invalid free >> > dlm: don't allow zero length names >> > dlm: don't leak kernel pointer to userspace >> > >> > fs/dlm/lockspace.c | 2 +- >> > fs/dlm/member.c | 5 +++-- >> > fs/dlm/user.c | 2 +- >> > 3 files changed, 5 insertions(+), 4 deletions(-) >> >> I've pushed these to linux-dlm next. > > Great, thanks! Should we send 1 and 3 to stable? Yes please! :) -- Kees Cook