Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8408030imu; Thu, 15 Nov 2018 11:02:56 -0800 (PST) X-Google-Smtp-Source: AJdET5eEEXYa31AO4TGcGw0MEQR2l0CiquFz1+548jIOE6xRgS+4Us95q5qbiBH1tnS0uuDKvAKa X-Received: by 2002:a62:32c4:: with SMTP id y187-v6mr7733704pfy.4.1542308576401; Thu, 15 Nov 2018 11:02:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542308576; cv=none; d=google.com; s=arc-20160816; b=kV9AJ8WjBAS52P6oXiOhbc+p/cn6+CwZL+VBVHUtK4sV5t1/8qL03ZoHKKHzfycRQn HklQvShCayC73XLAI8usU4VNv+5+txi8M9d353zZynROZtg+ySa158+hvhWByNnYdLr4 w96ABYUeZnnnJZX/5xLefAmx1wkmvjXtgbSA98Yww8y6hSuJbOmVEMZPdaDYqve/uDUW Qp30H4TrdauYHRTYooKeiInbtON4aoYZlGwlOHjETgfUJwHq1BrGDl80dozjTwTrD5sP 2F+7BOCmUfL7Rfff/iNFtY9zUT56Qd4jgNcmZ+vPf2KNaUW9bzmz/39KDmwyUqgtRfJr 7f/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=K6WZpiUYv9rFHLmkHBSt7RPUX1fwmBZ0AyUVzyIsf4I=; b=fSghjaN9lNXy6IVTL5bKoykOHtPNWTOmhfZZNxhWykMeiEnPxzBAQvKyoLAVYb2Yof hg6cEeWc7ow+7sU49BMiRMnHV9mU9kS5Sx5goG4nwgrR1PzCKUnrJ/kHWdk/kzbnpINY Y0hI9IqLFr/vqFSKKBVCZgOsTrdeH5MEhA7Cygk+5gvLLN2pbeX5/k22Pcft9gPndM69 92ScKwroypVpwfjOScQ/OcVDdvhtBkgx9aKn9E6bwHoH8mtVWEqhNEmZtsSDyWoCRYWg lFJ2skGMkxlr7xgaCjikOBsWXZAx6FhFYFbzjUwyq3RxHHVTiePGWLeTmF5z8zZZXICq NscA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r29si27770628pga.477.2018.11.15.11.02.40; Thu, 15 Nov 2018 11:02:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbeKPFKA (ORCPT + 99 others); Fri, 16 Nov 2018 00:10:00 -0500 Received: from mga01.intel.com ([192.55.52.88]:28335 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbeKPFKA (ORCPT ); Fri, 16 Nov 2018 00:10:00 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 11:01:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,237,1539673200"; d="scan'208";a="106597779" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga004.fm.intel.com with SMTP; 15 Nov 2018 11:00:55 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 15 Nov 2018 21:00:54 +0200 Date: Thu, 15 Nov 2018 21:00:54 +0200 From: Mika Westerberg To: Lorenzo Pieralisi Cc: Lukas Wunner , iommu@lists.linux-foundation.org, Joerg Roedel , David Woodhouse , Lu Baolu , Ashok Raj , Bjorn Helgaas , "Rafael J. Wysocki" , Jacob jun Pan , Andreas Noever , Michael Jamet , Yehezkel Bernat , Christian Kellner , Mario.Limonciello@dell.com, Anthony Wong , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices Message-ID: <20181115190054.GD4179@lahna.fi.intel.com> References: <20181112180203.lx72gjfplb6xlur7@wunner.de> <20181113105636.GB11202@e107981-ln.cambridge.arm.com> <20181113112700.GT2500@lahna.fi.intel.com> <20181113114527.GA12821@e107981-ln.cambridge.arm.com> <20181115102239.GU2500@lahna.fi.intel.com> <20181115111356.GA599@e107981-ln.cambridge.arm.com> <20181115113737.GW2500@lahna.fi.intel.com> <20181115120736.pscly6zwd3k2tvd2@wunner.de> <20181115121627.GA2500@lahna.fi.intel.com> <20181115174608.GA17691@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181115174608.GA17691@e107981-ln.cambridge.arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 15, 2018 at 05:46:08PM +0000, Lorenzo Pieralisi wrote: > Do you really need to parse it if the dev->is_thunderbolt check is enough ? Yes, we need to parse it one way or another. dev->is_thunderbolt is based on heuristics which do not apply anymore when the thing gets integrated in the SoC. The _DSD is there already (on existing systems) and is being used by Windows so I don't understand why we cannot take advantage of it? Every new system with Thunderbolt ports will have it.