Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8408619imu; Thu, 15 Nov 2018 11:03:24 -0800 (PST) X-Google-Smtp-Source: AJdET5dccSWN4uQMwGW7Xc33DOJyw7f2Wv3RGu4cI01UC0wdvxF4olJwZ+LOoxPehj/3k6yCeRwn X-Received: by 2002:a63:d005:: with SMTP id z5mr6911468pgf.64.1542308604202; Thu, 15 Nov 2018 11:03:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542308604; cv=none; d=google.com; s=arc-20160816; b=GVxtsoB0Uq6SD8h3dzg5pI5LUACJ7BxEa4+YDhD1SKuJxpfIfNNEFy/lmRmLFqRY3T uLPe06E0WdlTwms2aJctM4nWBM9SWCj2KwoQEARVdh0spI01Vr/S/1Z9Y5asSw9Dk1df 7Mw3v39stapcH0quoacCaMWMEw6W0Ir5QYuj3GlGZfcY4eR42caGXTS/XpPeoHNoWnMl ACV06lsNZbRJG0lrItIRCaXSL0bZhwZP2YZa63WBVvGmPjwJr07suD6WvRBMlRteXHfZ mmnokfslckL5g3QYAPyZkPYK7Mt3ePGqo0QY+c7GChjlNM87a9PGLcCZcgllCBN9Hwop DZMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=b1UW3Mf37ktbl+CEMq32Zvlh+kZIlDoldTyNzJUVgHg=; b=sAzw7o9TgYvbZ4UEMPou7UlRlHNXw5jmvZvMBbHPYpJlU2CBMFRLZiM69XhAfOhGJ3 KItM+ny7ZNOVwHwRMwDadlg9k6b60+UEMTHP1AM7kJA7criqJMsfdC8p43dX00Okt6wA Tf3avuN5OdRM4uiGInTNvAqj7HrSWt7w8jgnks6guRgFWWaYd+QvNz6dShrLnC0E0el5 Ay1TkSLFQxvFoUDi9zs1gSuokyQqkuXoO+Arhl2JXgSxBM0YRHXlRP7Zk+5uX7Q2ifCK iREPMq3/rF1lFhn4CHLp9Ctzr+Iyj4MW9+rv4tKIu5PUv2p5tifn0pb/2wvwqyjaJvKK U3Vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1-v6si28093432pld.378.2018.11.15.11.03.09; Thu, 15 Nov 2018 11:03:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726300AbeKPFJ1 (ORCPT + 99 others); Fri, 16 Nov 2018 00:09:27 -0500 Received: from mga11.intel.com ([192.55.52.93]:2451 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725742AbeKPFJ1 (ORCPT ); Fri, 16 Nov 2018 00:09:27 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2018 11:00:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,237,1539673200"; d="scan'208";a="104839861" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.126]) by fmsmga002.fm.intel.com with ESMTP; 15 Nov 2018 11:00:28 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 65D3830853D; Thu, 15 Nov 2018 11:00:28 -0800 (PST) From: Andi Kleen To: Milian Wolff Cc: Travis Downs , jolsa@redhat.com, linux-kernel@vger.kernel.org, jolsa@kernel.org, namhyung@kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org Subject: Re: PEBS level 2/3 breaks dwarf unwinding! [WAS: Re: Broken dwarf unwinding - wrong stack pointer register value?] References: <2335309.gnWok9HYb4@agathebauer> <31474933.dcNFsqGoRn@agathebauer> <6310843.N4ooJGWzKY@agathebauer> Date: Thu, 15 Nov 2018 11:00:28 -0800 In-Reply-To: <6310843.N4ooJGWzKY@agathebauer> (Milian Wolff's message of "Thu, 15 Nov 2018 10:10:13 +0100") Message-ID: <8736s2xj1v.fsf@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Milian Wolff writes: > > I agree. I personally like your suggested approach - only add an indication > when the IP differs so much that it points to a different function. What do > others say to this? Yes that's fine. -Andi