Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8609604imu; Thu, 15 Nov 2018 14:30:54 -0800 (PST) X-Google-Smtp-Source: AJdET5eqooz8xCg4a4Ahwp6YF+a0RsdP0j6zg6OHdKimpe+f1dv+2+jAsdooE7VrKojq8ZUaKHT6 X-Received: by 2002:a17:902:f24:: with SMTP id 33-v6mr8403674ply.228.1542321054104; Thu, 15 Nov 2018 14:30:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542321054; cv=none; d=google.com; s=arc-20160816; b=Q7fj815kP3jWb70b7g+dkEhvPlMGvm4hJVg2Tvez2WRrXr2mZ3IMBdxwrGAFUC7Bi0 oj3Hsp2bep8NIjikf6hXOJ0anCh12c8TPxf2XURmMGIMb9+6hlYeDMABNznDKeuTJwRs qLxiVru4X2HExU5QxTvvOmiGxh5DdgXYYy6SdeKFG91+aiEE53DJfc6SnV5WFFPXn6x+ 63j4mpR9fMgzmRp0wbeDF9cpTTfIrlq2crsLGklz97YQyd1mXPM0PhZMOMOKD2XGhsNO 39ReZIim9fO6hPkdhFd3LSMTWPhqObt1PEgPh3YWBbmF8LxFSkuE/GtvQIKU8yrAuxLS +Xng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ATLSfOn+sBvmpn/qNhLOYJgpSdOgcyhajMrbHNpHinM=; b=fXEPdMeijBgoA0rswUCzOXSvKqmyQ2jHdaBKu91djcyTe3fMjxLb7CESi8HAylnf2I nunXjbUxazdAVbAE1ZqhW63Sga0w7Oi747PwEV9D58u0+FUwLi4M2irolQ0m8YFAMg3Y h34DNwKpr8QpZ4ST+YytHjASUIzXnk5iTeS8+sp6CFk+yLfbXxkJesFKAgKjPusseeUc r6tRfNy9iHJ2IAaqHGj0y8vkBHAACMBAWi6/okC8CNsmQ5Q7LYT+T3tm4wpToUFQ5Tpa SdXYkgg0zkGi0pTwnMTD0vJRgfnO0COQXTIgI6HeFVPFc+w8C4BOubAx6as3Q6d8vzkY g3Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17-v6si10233759pfa.227.2018.11.15.14.30.39; Thu, 15 Nov 2018 14:30:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726407AbeKPIjn (ORCPT + 99 others); Fri, 16 Nov 2018 03:39:43 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42602 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbeKPIjn (ORCPT ); Fri, 16 Nov 2018 03:39:43 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 821A1949; Thu, 15 Nov 2018 22:30:00 +0000 (UTC) Date: Thu, 15 Nov 2018 14:29:59 -0800 From: Andrew Morton To: Jan Kara Cc: Pavel Tikhomirov , Vasily Averin , Andrey Ryabinin , Konstantin Khorenko , Johannes Weiner , Mel Gorman , Matthew Wilcox , Andi Kleen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: cleancache: fix corruption on missed inode invalidation Message-Id: <20181115142959.89ecdb6b4f24a1427062d861@linux-foundation.org> In-Reply-To: <20181112113153.GC7175@quack2.suse.cz> References: <20181112095734.17979-1-ptikhomirov@virtuozzo.com> <20181112113153.GC7175@quack2.suse.cz> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Nov 2018 12:31:53 +0100 Jan Kara wrote: > > mm/truncate.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > The patch looks good but can you add a short comment before the > truncate_inode_pages() call explaining why it needs to be called always? > Something like: > > /* > * Cleancache needs notification even if there are no pages or > * shadow entries... > */ --- a/mm/truncate.c~mm-cleancache-fix-corruption-on-missed-inode-invalidation-fix +++ a/mm/truncate.c @@ -519,6 +519,10 @@ void truncate_inode_pages_final(struct a xa_unlock_irq(&mapping->i_pages); } + /* + * Cleancache needs notification even if there are no pages or shadow + * entries. + */ truncate_inode_pages(mapping, 0); } EXPORT_SYMBOL(truncate_inode_pages_final); _