Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp69752imu; Thu, 15 Nov 2018 22:17:13 -0800 (PST) X-Google-Smtp-Source: AJdET5eUga4W3XSSxeZe77xj7O7xHa9l8+GdSxuy/q3fZAYrgGXoCPmVhW/ZustxdkZNIikD3hMh X-Received: by 2002:a17:902:b90c:: with SMTP id bf12-v6mr8976584plb.1.1542349032875; Thu, 15 Nov 2018 22:17:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542349032; cv=none; d=google.com; s=arc-20160816; b=MJKVSt8oRiAknOqhgge8DVpFRDB6NF0qhO7erASSCJQD1QfrbaPxlH40v/oubhgiiK d/CxRQprn5tAA9gYKhWKro+xPVnmLQpTKX3oEjQuPsludoNs0fRiXwlQIx3IXcnqHGuG q4zih4flw+S+gaPCy6qQiDYjpNs6u0SxUpCRW7IKsCV2jcO5T4gByeIFwl9mKYrw/52i yPLMMN6cl5L4g1rJvhWRiqtOo5oV3kE5oeWT20M0C/4cZTyHPByE7/hD4bIVIOt1w6aK 3q68OnsFHJet77JECdSwJj8MN+py8JKOWP75r+LqKGTP8NsPMN4qYCFiXPxiaoztOVlE pGfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rhOfyQuu1XbIty5RBCBY463t+gpxvoR8447X2szScrQ=; b=yfChr8SJox9TV6nvvQvvc7mgHD4K6Zy8yMm8uKeLTw8wBW4XmDUHBUr+3rH+DoRzmg P5tIiCOhizZenf8ihS8hyG6/Snxrkk4w0/rdJGVwyi3ncH9rXOkKbvT6dgtdL9T7OiY4 Pdf6nGImnBcQRV6sn4Y+8HHnArmMt83omNonCxIoBSm9DptFzOKW6YvCFLnv6W+JuOIn O87knRMXtSNyvfRLB3n7RIMvX17wA/v8U8UDknZ7dJFeiGJPV5CVnsvfvNDtTK1m/G8e xXGHSQUzdQ/XN08/bC5JGfnqHoUz9j3Y1B8HgNlcaqWRKN6K1gdiwABVJQsnOk3vSJRs XRAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n4si9658533pgd.10.2018.11.15.22.16.57; Thu, 15 Nov 2018 22:17:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389267AbeKPQ1J (ORCPT + 99 others); Fri, 16 Nov 2018 11:27:09 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:37572 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeKPQ1J (ORCPT ); Fri, 16 Nov 2018 11:27:09 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gNXQC-0004vZ-OT; Fri, 16 Nov 2018 14:16:04 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gNXQ9-0001xY-Sn; Fri, 16 Nov 2018 14:16:01 +0800 Date: Fri, 16 Nov 2018 14:16:01 +0800 From: Herbert Xu To: Vitaly Chikunov Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: ecc - check for invalid values in the key verification test Message-ID: <20181116061601.zagzxvsoc6why5ep@gondor.apana.org.au> References: <20181105083618.29102-1-vt@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181105083618.29102-1-vt@altlinux.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 05, 2018 at 11:36:18AM +0300, Vitaly Chikunov wrote: > Currently used scalar multiplication algorithm (Matthieu Rivain, 2011) > have invalid values for scalar == 1, n-1, and for regularized version > n-2, which was previously not checked. Verify that they are not used as > private keys. > > Signed-off-by: Vitaly Chikunov > --- > crypto/ecc.c | 42 ++++++++++++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 16 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt