Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp71534imu; Thu, 15 Nov 2018 22:19:26 -0800 (PST) X-Google-Smtp-Source: AJdET5fUmvdNtWryUUxU6os+m0jRkebiAB13pfcDpU94ZqZ0dYUXBKzg+T/PxCl+RB27BIr9mWL0 X-Received: by 2002:a63:5e43:: with SMTP id s64mr8834740pgb.101.1542349166185; Thu, 15 Nov 2018 22:19:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542349166; cv=none; d=google.com; s=arc-20160816; b=dlH9N1tZ7g2KhpZ/5GhStllnDJK2N843I1/7e5NveM0EaZ1d0N9wWzXyL6ZAQa8Chj HHuAOTL1YUu9i+y9tuwUeKIbw+UGpEVrthHlvKooVi4fuKIm6eq/QBM+JPA6MUPHZVcs HpEIdAEb3o8x4A3K4mrJyoQAc178ICoUSTLd97rKF/tfPibd26Tdp/EC8nYv8p9tWzin axtjA1op3k50JtFkFUZM+br/kIFZI1NzAU0/jrRKTEp1ZR5HvI0OxZFT0pTUOp0rFGVy 1GgQGLxJ9BmobSXQBnBy7VnBBwkZ085wpy+oER6hvbbTCAyBaOAcGSEMdinC3Yk0vFz2 ytMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=FoL0rRYJUPwoTUElVYtUBnjh1ii9riXVjQYkTvgpaZs=; b=FKrKm1ZjFEGAb0mBgslv1X6f7KSX7D9YihoZb/iZzouGxGCaAOWgc+Rw7dmoqLY60w PDjIdOKM58af5R4+8+5COAwOXa3pvzaRw0u1tRz6SwNNOD1oUYcUCrDZcv4NqrZL/4sp 5B3PK5eQAcyDFMXgEJdHW6PLo5Sp4Kally5IVBuIi149ZfycUcGgFpRr+5ZnT15h9gRf eEXPOa8fCOGVawa5n114NDsNnJiDa79mbInMW79Pq6+GXPoMfJnqkK1PWQt4PfQMof6x g9mF+H5nm+jt8GAqGXpvUDe0T4wkekYFWQvju5kpwSzKSWOvmYiBjG6/uitczWAI6BJK 1uhg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16-v6si29349555pgd.555.2018.11.15.22.19.12; Thu, 15 Nov 2018 22:19:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389214AbeKPQ3U (ORCPT + 99 others); Fri, 16 Nov 2018 11:29:20 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:37590 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeKPQ3U (ORCPT ); Fri, 16 Nov 2018 11:29:20 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gNXSJ-0004xo-IK; Fri, 16 Nov 2018 14:18:15 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gNXSG-0001zC-Nz; Fri, 16 Nov 2018 14:18:12 +0800 Date: Fri, 16 Nov 2018 14:18:12 +0800 From: Herbert Xu To: Florian Fainelli Cc: Raveendra Padasalagi , "David S. Miller" , Eric Biggers , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Agner , bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH] crypto: bcm: fix normal/non key hash algorithm failure Message-ID: <20181116061812.5lhfyriycqz2sc3v@gondor.apana.org.au> References: <1541492938-29261-1-git-send-email-raveendra.padasalagi@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 06, 2018 at 10:02:47AM -0800, Florian Fainelli wrote: > On 11/6/18 12:28 AM, Raveendra Padasalagi wrote: > > Remove setkey() callback handler for normal/non key > > hash algorithms and keep it for AES-CBC/CMAC which needs key. > > > > Signed-off-by: Raveendra Padasalagi > > Should this have the following Fixes tag? > > Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver") I added it when applying. > > drivers/crypto/bcm/cipher.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt