Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp178121imu; Fri, 16 Nov 2018 00:30:00 -0800 (PST) X-Google-Smtp-Source: AJdET5d8BeYVIlIlkqg95npwt+fGRpoTtQEENtXNELIXpgJDwh0G5PVc27cpPZa+WLXP8Az76Ly1 X-Received: by 2002:a63:2d82:: with SMTP id t124mr9011642pgt.260.1542357000635; Fri, 16 Nov 2018 00:30:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542357000; cv=none; d=google.com; s=arc-20160816; b=FhT429833q7xYnYCRCHnvuD32z65LsDhw8NDZJPML0GJLqa7Fuzymd5jxvnWpSUGCD JqYGhMF46VTLk93XY0UffoukmMeLeEu7uAoylcuZDHIFhPuKwPwJD6rEsgu8KAGmncZJ gE3Xe+/U3uKlNy00pTZSJt2MGVr2bagJpsT6Qqs5ZKZUJZq0aSNJRUZjHgYSEi9lvDKo d+z4fjmny7reIw4VQpYdoWs8UB54xbr7ItzZ+rGSQrlRggTHNbzvHm4c8QxJ6Yz0CLRj ydWIhW0fpJWuiPup7+1UwvEFKs6vmVPKdapvZx1JQ/RPK/DuvMjx5MR6F6tmb7SYLyI3 Lq5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=0d/wQ/YI/Q8gHVauOdfO8r3BKO0Crk89TaM2T+f1yRA=; b=tLyQdiizIUDgpc84o/WXrOEUFivGqqibCfi4ysQmeAvRQGYnKnWm4QTR7mH6QHo+BL tm+uw58awOY9xrZ2sgjL5tzICfwlD21XI9zPGm9SlkkyQJrkFgpnQtXtAyGgLT8H5KtN bPoD1Pgsd64/bgL9jxc/IBX9J60roMgUAKZBcG95t13JiCmeeFOa6iFdFwgqAb025dnB irKb95Si/D4i6h/ZGEMUZwKv8Itw+iB576Td+d1h9Do3R8mekaRy9o9Bvg6ewmAvNn7F 1EPAg2q3q7fXf2CsLIUdYXC6iKeUNU/rV7yPo9aEMAazDUTa7g+ZUuWoSqHz/L0TJ4LF pFOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si12461347plr.306.2018.11.16.00.29.45; Fri, 16 Nov 2018 00:30:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727602AbeKPSk2 (ORCPT + 99 others); Fri, 16 Nov 2018 13:40:28 -0500 Received: from mail-sz2.amlogic.com ([211.162.65.114]:56017 "EHLO mail-sz2.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbeKPSk1 (ORCPT ); Fri, 16 Nov 2018 13:40:27 -0500 Received: from [10.28.18.44] (10.28.18.44) by mail-sz2.amlogic.com (10.28.11.6) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Fri, 16 Nov 2018 16:29:07 +0800 Subject: Re: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller To: Boris Brezillon , Miquel Raynal CC: Rob Herring , Hanjie Lin , Victor Wan , Jianxin Pan , Neil Armstrong , Martin Blumenstingl , Richard Weinberger , Yixun Lan , , Marek Vasut , Jian Hu , , Kevin Hilman , Carlo Caione , , Brian Norris , David Woodhouse , , Jerome Brunet , Wolfram Sang References: <1541090542-19618-1-git-send-email-jianxin.pan@amlogic.com> <1541090542-19618-3-git-send-email-jianxin.pan@amlogic.com> <20181105165321.7ea2b45f@bbrezillon> <20181106102851.61deb97a@bbrezillon> <20181106112206.65a70a81@bbrezillon> <20181112171351.4ac3506b@xps13> <20181112175416.247e3203@bbrezillon> <20181112184518.6c02ac6d@bbrezillon> <27769252-ac5e-e787-6792-d6a06e7af0e4@amlogic.com> <20181115140400.3934effe@xps13> <20181115140905.40011b4b@bbrezillon> From: Liang Yang Message-ID: <7e36bf4c-69a1-a570-f086-75f8ad53d518@amlogic.com> Date: Fri, 16 Nov 2018 16:29:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181115140905.40011b4b@bbrezillon> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.18.44] X-ClientProxiedBy: mail-sz2.amlogic.com (10.28.11.6) To mail-sz2.amlogic.com (10.28.11.6) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris and Miquel, understand. i will move helpers into nfc driver to avoid some errors when sending the patch. On 2018/11/15 21:09, Boris Brezillon wrote: > On Thu, 15 Nov 2018 14:04:00 +0100 > Miquel Raynal wrote: > >> Hi Liang, >> >> Liang Yang wrote on Thu, 15 Nov 2018 19:25:07 >> +0800: >> >>> Hi Boris, >>> >>> I have implemented dma access base on these helpers you provided below. >>> we prepare to send v7 version now, so when will these helpers be pushed? >> >> Thanks for your work. You can send the v7 so we will have a look at the >> overall driver; but since we raised the DMA buffers issue we had a >> discussion with Boris about how to handle them and I think we are going >> to adopt the same solution as Wolfram in the I2C subsystem: manual >> flagging. Sadly, this is probably the best we can do to ensure proper >> DMA support. >> >> There is nothing set is stone yet but I started a small rework to >> handle MTD operations differently (and add a DMA_SAFE flag), you can >> have a look there [1]. Don't base your work on it for now as it is just >> a preliminary version, subject to big changes. > > In order to not block the driver, I'd suggest that you move the helper > I proposed directly into your driver and prefix them with 'meson_'. > > . >