Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp179984imu; Fri, 16 Nov 2018 00:31:46 -0800 (PST) X-Google-Smtp-Source: AJdET5cAWTnlpyjmk3lq9K51/D5tEvuF91seITt+NBgEPEzXc0/c/d4q7eANvmEtv6TXhnU9e6dG X-Received: by 2002:a63:396:: with SMTP id 144mr9196234pgd.68.1542357106917; Fri, 16 Nov 2018 00:31:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542357106; cv=none; d=google.com; s=arc-20160816; b=tJWkMni/GRBYsn8UCLNEOkPVXVjc8x0nzUhKw4tHzprv6MyVMEw+5CKhcONrSAAPDA d0XBX6kEafuhChIUalRQGMAyVtWFI0zurbslMpVfjVduFqP3YnaVKTE4dv7SV7VWSspk cLnPa5ef2wKC8bHHWt4NaZzM6Z7L/oo5QKnf9nQeD7Nl/y/5NmMxtjO+FdXPiq0rI4MD aIfi/1PuSrocor5l953alCSDTCJn7oTu5pbrVL46pIv0LAF3UKP9VVihsqWynxxegEMt PB0UYTJCxQWdIhsyGg/CI+MkCQXEiAVrhQ4gl599fGkzFow5XD9NZKRZkvX+lMde41Da ETEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=k4D3ilvRNbEdywbamB4FAtEIm3b4AWw0D1l/xvNW28A=; b=rVZkZTnRSpBpdS0jy7cd6B3sEQFzqmOHIkNYRc6tvFqXO+wxORSa+YnJd4VSR99avN 6mJq84eqiWCSYbM9gmKWt4n9TeT6fs8y/7oljVz2dVYSKuwb5xbQURgCm+MhzbSlz2vP WDCy1iWpQNS2j4TOmtqnGRFi7oqDfJNFX6BAPNuQ5VJWvCl7ha5GcaO1tIdp2zd3UKHK PeUKmvfunwZmkn3Ib1eDMEjPwnbs8bFStmi4vgKZTtAVlYDWqBPpf+u+7uP8D5HzAcxr RwmR7G6R0xBvQrb03AQFgvt8jNsnsM+XqpC4Z/mk0eHZ01a+L888hynPSn5ocYO/YGPo Xj2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi6si13439623plb.279.2018.11.16.00.31.32; Fri, 16 Nov 2018 00:31:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389431AbeKPSl6 (ORCPT + 99 others); Fri, 16 Nov 2018 13:41:58 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:39272 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389359AbeKPSl5 (ORCPT ); Fri, 16 Nov 2018 13:41:57 -0500 Received: by mail-ed1-f68.google.com with SMTP id b14so16406864edt.6 for ; Fri, 16 Nov 2018 00:30:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k4D3ilvRNbEdywbamB4FAtEIm3b4AWw0D1l/xvNW28A=; b=lIw1KkeP1x61MMwqiPlDfE4rARdgELiaK1l+ZMMSUWYHjj+UdYFFcIWoT6aQIxwVtH 1vs9HG+kEogpTMSfWAUO1Rwk0CbHCFHpnWsFlQbqUW1zPGgg9zneIOP3dPNE2BV6ww0G RgT/AmjefKXhnmwTIiGCc6i0yWnFzDy7rAgG6zm+ljXcxTuMulJaF02b2UWhDxTNNxbW XxUXRQrXee1JLviqnSYQ+Yu2Am93FtXAZ774mM8WMfz9rlgiGB/nBJocx24a1VuS/sfx 5Mo93ZOeUOPWrZWnw1NwoYJ8nLsjCOgtUqPz2L6OSn87AGV8tpRfU+jctNaQ2dQBdWHy 6sMw== X-Gm-Message-State: AGRZ1gIGcd/WxU4HzLxaYbuG5eY9DXaaR6JdNyxmBK8BOcp/+UOda7N3 O2GaAs0iGgU6aUOzne0pJ64= X-Received: by 2002:a17:906:f6cb:: with SMTP id jo11-v6mr1444856ejb.80.1542357036521; Fri, 16 Nov 2018 00:30:36 -0800 (PST) Received: from tiehlicka.suse.cz (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id m13sm5305393edd.2.2018.11.16.00.30.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Nov 2018 00:30:35 -0800 (PST) From: Michal Hocko To: Andrew Morton Cc: Oscar Salvador , Baoquan He , Anshuman Khandual , , LKML , Michal Hocko Subject: [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Date: Fri, 16 Nov 2018 09:30:18 +0100 Message-Id: <20181116083020.20260-4-mhocko@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181116083020.20260-1-mhocko@kernel.org> References: <20181116083020.20260-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko This function is never called from a context which would provide misaligned pfn range so drop the pointless check. Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 2b2b3ccbbfb5..a92b1b8f6218 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1554,12 +1554,6 @@ static int __ref __offline_pages(unsigned long start_pfn, struct zone *zone; struct memory_notify arg; - /* at least, alignment against pageblock is necessary */ - if (!IS_ALIGNED(start_pfn, pageblock_nr_pages)) - return -EINVAL; - if (!IS_ALIGNED(end_pfn, pageblock_nr_pages)) - return -EINVAL; - mem_hotplug_begin(); /* This makes hotplug much easier...and readable. -- 2.19.1