Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp274527imu; Fri, 16 Nov 2018 02:18:48 -0800 (PST) X-Google-Smtp-Source: AJdET5ch1jrl3pmvTTKRPOkKuKW8/fLBKQc5oKFwaW5DDis9RmkznuXT7WxirVC0XkGF3I9PBVJ/ X-Received: by 2002:a63:6506:: with SMTP id z6-v6mr7784082pgb.219.1542363528163; Fri, 16 Nov 2018 02:18:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542363528; cv=none; d=google.com; s=arc-20160816; b=tXbFD08ktFDuflGp80NZjaff0AFbs8fy/B418+FDWcKVa+/n557e+QT1z4ABH2krPL fjt+7s2ye3Cu5/ZzvcH2ubYxfu+GqpUNQHpPVIPbOBoBoXgBxtO0WWylDc5YizUfobFI PcAGZXRz/rL7HsjBnryp1dSRd73sFW19bbYvQTaYF5McerFTLRiWkYHdggwun4iFAU6K CYvq3ytNGDzTu2rZYx4nUbKg6HvlVTs2x0m3XXupAKbtwLiOYZGnTTz1iTLwInvaWxiJ cH18n7CsJmHXf/6m8bIvlFS+0lrorrxbItvs9ce8vR29700w81SKo9dhAePIPhGKCv0B csdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=D5cordEYTpHB0KSWZFZNm9UkBfk7mcHFSIPhlPUfYCE=; b=SgcRamUPnfTuBB+ixuLRsp/BstKZExiYR5i7yw4Ei+LFjOwUY5uKpoAMe8sA7TNETj qq9P8+16G+9+XhPs68ueqb0DkxeJutIh8UjdwoqmIkOOPH/PJ/4dV5PIUOv98U5ttqxg YPpC6ZVT2k/VxTawv8+3+1CsSijPoqSWb6tqYh1vIfI69Opq9wnKUWrVqwwbGrVHw9Bq jiIehypqu3OTBQUfaaRs4lgU4LKaF6ek2AwTYmyrlg1u2FkmSwW0lueLx3KVmKj2qtMa PHVFRz452s4ZjzIa1VGYTuwRkcqkA9YM3XpmoL53CQunU+KNuKetrOtVeMmFSPllY3RK dZ9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s9si30334700pgv.397.2018.11.16.02.18.33; Fri, 16 Nov 2018 02:18:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbeKPU3f (ORCPT + 99 others); Fri, 16 Nov 2018 15:29:35 -0500 Received: from verein.lst.de ([213.95.11.211]:48611 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727454AbeKPU3f (ORCPT ); Fri, 16 Nov 2018 15:29:35 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id F3A1668D60; Fri, 16 Nov 2018 11:17:52 +0100 (CET) Date: Fri, 16 Nov 2018 11:17:52 +0100 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Mike Snitzer , linux-nvme@lists.infradead.org, Keith Busch , Sagi Grimberg , axboe@kernel.dk, Martin Wilck , lijie , xose.vazquez@gmail.com, chengjike.cheng@huawei.com, shenhong09@huawei.com, dm-devel@redhat.com, wangzhoumengjian@huawei.com, christophe.varoqui@opensvc.com, bmarzins@redhat.com, sschremm@netapp.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: allow ANA support to be independent of native multipathing Message-ID: <20181116101752.GA21531@lst.de> References: <20181113180008.GA12513@redhat.com> <20181114053837.GA15086@redhat.com> <30cf7af7-8826-55bd-e39a-4f81ed032f6d@suse.de> <20181114174746.GA18526@redhat.com> <87c931e5-4ac9-1795-8d40-cc5541d3ebcf@suse.de> <20181115174605.GA19782@redhat.com> <20181116091458.GA17267@lst.de> <37098edd-4dea-b58f-bca6-3be9af8ec4ee@suse.de> <20181116094947.GA19296@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 16, 2018 at 11:06:32AM +0100, Hannes Reinecke wrote: > Ok, so would you be happy with making ANA support configurable? I've looked a bit over the whole situation, and what I think we need to do is: a) warn if we see a ANA capable device without multipath support so people know it is not going to work properly. b) deprecate the multipath module option. It was only intended as a migration for any pre-existing PCIe multipath user if there were any, not to support any new functionality. So for 4.20 put in a patch that prints a clear warning when it is used, including a link to the nvme list, and then for 4.25 or so remove it entirely unless something unexpected come up. This whole drama of optional multipath use has wasted way too much of everyones time already.