Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp289136imu; Fri, 16 Nov 2018 02:35:31 -0800 (PST) X-Google-Smtp-Source: AJdET5dsBWV03VwMXDOpUnRBVvEPPxxmtZrMcJFXWHIxRebQRbpWSxY8b6fZTK9F8pidWq0padz8 X-Received: by 2002:aa7:804e:: with SMTP id y14-v6mr10271746pfm.73.1542364531550; Fri, 16 Nov 2018 02:35:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542364531; cv=none; d=google.com; s=arc-20160816; b=p3bjqkhFl0GGxnmwDaPyCbmZ3+cGzQpJXOzO2+WKKAsunRNeOuW0OpLQCVpT0Ctg45 M1T+hKezBdcMCObnEC58EPPE3FrrKMq/K+p0IyAVAbs+XvVgevqyE1txjhbh8xsFmrhD Jno7DTlwAhGtdDQ5ENpk9Iy70Bzg7Jj43uJmeTg170c5g5mS5LLWpwp6LjMJXQaws8nX 6Gf7qCxe4tBWHE4QaC2pP8yTIKboqTFWajPDJ2YLaeLq7MTvx6+T2TziNkWMaHnZ4XaN kz+JWB5CtSqqqJReq1NLu4fS2vBqCI3yqdiO3pdUBWMt6SQLXuLdpKo8DNsSQ9qXFf1t p3vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id; bh=0Z5/tZhFY8LsQH5RCjnA/p17kpdOLyecqjhbSWHDIAs=; b=E7olX/0+2eCR1FEf6llg7JitHfOSTTwCkF4zqgN9ngC9nFU4Ok9bzi5T5cuTHfpUAN Vme2TM7P+QCKh/sRyFED8lpc/oyG2j6oVDTXeIG0pazVDUHcqL93sM67mVCtkZriRmcE TbOGmsX6Crc2RdcfPIr+3UtkS5XmKOuObmqTfvo5/lis9OR/9Ic2lw/cOd49CUFzCtlX GYO9+5fycquLOLkNGX0Cam27AsWbPoqdf5g68dDgQUUQtB02Emgsaxf+XjmXtNyDVQGW hnp9q+Q91quwyfloXoucVP5F2sejKHuB+MuSFM5a5XUufQTvIztb4YJKhYlzzE1KFwp6 slCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si28238364pgg.162.2018.11.16.02.35.16; Fri, 16 Nov 2018 02:35:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727764AbeKPUqX (ORCPT + 99 others); Fri, 16 Nov 2018 15:46:23 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:40182 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727493AbeKPUqX (ORCPT ); Fri, 16 Nov 2018 15:46:23 -0500 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 16 Nov 2018 11:34:37 +0100 Received: from [149.44.172.157] (nwb-a10-snat.microfocus.com [10.120.13.202]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Fri, 16 Nov 2018 10:34:20 +0000 Message-ID: <1542364443.3020.3.camel@suse.com> Subject: Re: [PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages From: osalvador To: Michal Hocko , Andrew Morton Cc: Baoquan He , Anshuman Khandual , linux-mm@kvack.org, LKML , Michal Hocko Date: Fri, 16 Nov 2018 11:34:03 +0100 In-Reply-To: <20181116083020.20260-4-mhocko@kernel.org> References: <20181116083020.20260-1-mhocko@kernel.org> <20181116083020.20260-4-mhocko@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-11-16 at 09:30 +0100, Michal Hocko wrote: > From: Michal Hocko > > This function is never called from a context which would provide > misaligned pfn range so drop the pointless check. > > Signed-off-by: Michal Hocko I vaguely remember that someone reported a problem about misaligned range on powerpc. Not sure at which stage was (online/offline). Although I am not sure if that was valid at all. Reviewed-by: Oscar Salvador