Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp310511imu; Fri, 16 Nov 2018 02:58:15 -0800 (PST) X-Google-Smtp-Source: AJdET5dyb7ksvY91ttGcVt3OrtP+Uw5aoxfY1BRcx1G26/wzNkjZZCzYZUxua2gpuX6oHbjrHj0a X-Received: by 2002:a63:104d:: with SMTP id 13mr9461933pgq.303.1542365895112; Fri, 16 Nov 2018 02:58:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542365895; cv=none; d=google.com; s=arc-20160816; b=kyhPtjOlUwsJnPaMenIDmSxi9+UTQJThDvhmnLcJ7kyV4lqx6ZBO4mK9YVfjQ63q+U Wam+JmeCGQCSPLveGGc2aK7zBFYHG/1wqWMafgjDSVR5PlI994G6h60QbPXom+XCsPHw mJrdcEAZ1V4o4iLnkl/n5Tbz+j2dvDVl25EE6B1NI2x/h4DYLUzIv+nPsweFt934dSPK WXUZKDxDACXfrnlym/op9+wkDBu/fDV/CQk39VxpBCxvpfTLPtxQan7dNd1r8Lgjwqf2 0SoZ+ZiWv9RccVM138bx6vs0XEFBIfE8qcZ7dvvuC0r0FTw6zu9gIE5AjNOKgOH7apXc P5iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=iGSUvRLI8+aGBk903w1wsSho+606I8IUKOvB4+uw3Ng=; b=rRoWnDLyWpXLVOqyMprAANtzVvLVlf5TTQcZTQkPes4Qxyp2+9biVeqQ/gBxqTskzg 2DxQ370KwZ4gjNnZW6Kn0sKZc/gy9VZsY7DjEOsI3KdDNwv5Ug9WeCEr5q+8Pet2IBnc sVkxTDh8FMBlFEI2K/nB1q2yYA9DOW03/RHe1vyP+FUeVzWJnwx1JVX5/LTbIu2VVlyT nNxPzEpSMtZUDJ5a+JodIf2l7o/aFeJOoj2ONC7XILS4ymwcVZVns4ywgiJ7tky80wh8 0eB+yME+M2lOBBCBOTnJywUsN/50uxHnVCba3X9azDDRWS31omaj40wALXsrqn0A+bIJ F0cQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10si3367974pgp.348.2018.11.16.02.57.59; Fri, 16 Nov 2018 02:58:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbeKPVJK (ORCPT + 99 others); Fri, 16 Nov 2018 16:09:10 -0500 Received: from foss.arm.com ([217.140.101.70]:49536 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727454AbeKPVJJ (ORCPT ); Fri, 16 Nov 2018 16:09:09 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACAAD80D; Fri, 16 Nov 2018 02:57:19 -0800 (PST) Received: from red-moon (red-moon.cambridge.arm.com [10.1.197.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 946F73F5BD; Fri, 16 Nov 2018 02:57:16 -0800 (PST) Date: Fri, 16 Nov 2018 10:57:38 +0000 From: Lorenzo Pieralisi To: Mario.Limonciello@dell.com Cc: mika.westerberg@linux.intel.com, lukas@wunner.de, iommu@lists.linux-foundation.org, joro@8bytes.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, ashok.raj@intel.com, bhelgaas@google.com, rjw@rjwysocki.net, jacob.jun.pan@intel.com, andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, ckellner@redhat.com, anthony.wong@canonical.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices Message-ID: <20181116105738.GA21277@red-moon> References: <20181113112700.GT2500@lahna.fi.intel.com> <20181113114527.GA12821@e107981-ln.cambridge.arm.com> <20181115102239.GU2500@lahna.fi.intel.com> <20181115111356.GA599@e107981-ln.cambridge.arm.com> <20181115113737.GW2500@lahna.fi.intel.com> <20181115120736.pscly6zwd3k2tvd2@wunner.de> <20181115121627.GA2500@lahna.fi.intel.com> <20181115174608.GA17691@e107981-ln.cambridge.arm.com> <20181115190054.GD4179@lahna.fi.intel.com> <372db397d5384efd8e7264ba8e1b9cbd@ausx13mpc120.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <372db397d5384efd8e7264ba8e1b9cbd@ausx13mpc120.AMER.DELL.COM> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 15, 2018 at 07:33:54PM +0000, Mario.Limonciello@dell.com wrote: > > > > -----Original Message----- > > From: Mika Westerberg > > Sent: Thursday, November 15, 2018 1:01 PM > > To: Lorenzo Pieralisi > > Cc: Lukas Wunner; iommu@lists.linux-foundation.org; Joerg Roedel; David > > Woodhouse; Lu Baolu; Ashok Raj; Bjorn Helgaas; Rafael J. Wysocki; Jacob jun Pan; > > Andreas Noever; Michael Jamet; Yehezkel Bernat; Christian Kellner; Limonciello, > > Mario; Anthony Wong; linux-acpi@vger.kernel.org; linux-pci@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices > > > > > > [EXTERNAL EMAIL] > > > > On Thu, Nov 15, 2018 at 05:46:08PM +0000, Lorenzo Pieralisi wrote: > > > Do you really need to parse it if the dev->is_thunderbolt check is enough ? > > > > Yes, we need to parse it one way or another. dev->is_thunderbolt is > > based on heuristics which do not apply anymore when the thing gets > > integrated in the SoC. > > > > The _DSD is there already (on existing systems) and is being used by > > Windows so I don't understand why we cannot take advantage of it? Every > > new system with Thunderbolt ports will have it. We have different opinions on this, there is no point in me reiterating it over and over, I am against the approach taken to solve this problem first in defining the bindings outside the ACPI specifications and second by acquiescing to what has been done so that it will be done over and over again. I will raise the point in the appropriate forum, it is up to Bjorn and Rafael to decide on this patch. Lorenzo