Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp316870imu; Fri, 16 Nov 2018 03:04:15 -0800 (PST) X-Google-Smtp-Source: AJdET5f5njdvqohHMKegLLhT7/cOn9cMOIxdiUcYon5S3hdZrZSoRrJOcIxpf5nwxUKCsfFBN9DM X-Received: by 2002:a63:ec4b:: with SMTP id r11mr9246475pgj.44.1542366255213; Fri, 16 Nov 2018 03:04:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542366255; cv=none; d=google.com; s=arc-20160816; b=tZIvAS98t8iXhISVNTbpHc8RQ5L3uTD2kqMYzdH9sEfGyjD4A+N/4fzfP94ofu9e3p CMb2dJCu+rzSZH9yE4P5Q5q6Zg6r9PsY8uwA6Zk2wPJ3wGfEAfrNSFB5s/kMhtVaHq2e 13AnF/Rx0Ayy69meFZmtzB++NKb8OM/N0LE/gMb5kJCu0MHBN4DjKYx190m0x2SR7Y0Z e1ggjoY3fyg/3NpocOGaBoEJtKm+DkdhIrIWjI7W3Fiih/aGe/YhME48WkZnONquL7GO nYtOt2Gt6lJKsCpO7qbX/RV96HsRhEyhsNOo3y2ZzRfiv+fbDgA/dJaVvZPqLK2DYZc8 9mrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=kjILBW+oYlZDwN+Mafil6jVFVdCQM5HvTtGdDh+DTJk=; b=fsh4FkYxCPII+6n9Tpgfq+ezpGOGcH27z66q0zDDsbriVOVEIu7CyI9pE3l66K/OLs KGvokOTuqjGq8FHDthzIHYfIHP7KoWHf9lTuZrus2vNIxFlI8E7r1pOBG3iCW9AdtH/s cpS2dMkHsBZAJ0J3YG6HvUIkLkj6rQfkExMEAWCKnNpsXaO17xBFJ784BDkqMpEP7cvT 2YqqBZgRUrJQeFCDdByTI35VAGradFmLBz2YSz8SCw9ekK4416LLfgPfVt6nvyoy3rHR vtPJaX1rNXUfqxNZ6qziNBmSSvIMI0g3pu0mzO+IF+K9r9fARPmROa+vU+Yz7rK1Xa98 L4vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2-v6si29132821plo.259.2018.11.16.03.03.59; Fri, 16 Nov 2018 03:04:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389582AbeKPVPC (ORCPT + 99 others); Fri, 16 Nov 2018 16:15:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:15111 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727534AbeKPVPC (ORCPT ); Fri, 16 Nov 2018 16:15:02 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8C18AE62B7327; Fri, 16 Nov 2018 19:03:07 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.408.0; Fri, 16 Nov 2018 19:03:01 +0800 From: YueHaibing To: , , CC: , , , YueHaibing Subject: [PATCH -next] video: fbdev: pxafb: Fix "WARNING: invalid free of devm_ allocated data" Date: Fri, 16 Nov 2018 19:02:55 +0800 Message-ID: <20181116110255.19736-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display. This gives this error message: ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data Signed-off-by: YueHaibing --- drivers/video/fbdev/pxafb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index bbed039..d59c8a5 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2234,10 +2234,8 @@ static struct pxafb_mach_info *of_pxafb_of_mach_info(struct device *dev) if (!info) return ERR_PTR(-ENOMEM); ret = of_get_pxafb_mode_info(dev, info); - if (ret) { - kfree(info->modes); + if (ret) return ERR_PTR(ret); - } /* * On purpose, neither lccrX registers nor video memory size can be -- 2.7.0