Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Elvira Khabirova <lineprinter@altlinux.org>,
        benh@kernel.crashing.org, paulus@samba.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        leitao@debian.org, oleg@redhat.com, luto@kernel.org,
        ldv@altlinux.org, esyr@redhat.com
Subject: Re: [PATCH v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
In-Reply-To: <20181116121701.14359da0@akathisia>
References: <20181116121701.14359da0@akathisia>
Date:   Fri, 16 Nov 2018 23:42:24 +1100
Message-ID: <87ftw12nyn.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Elvira Khabirova <lineprinter@altlinux.org> writes:

> Arch code should use tracehook_*() helpers, as documented
> in include/linux/tracehook.h.

Thanks.

It probably also should have a comment explaining why we're ignoring the
return value and why that's OK.

cheers

> Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")
> Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org>
> ---
>  arch/powerpc/kernel/ptrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> index afb819f4ca68..d79d907f9acc 100644
> --- a/arch/powerpc/kernel/ptrace.c
> +++ b/arch/powerpc/kernel/ptrace.c
> @@ -3266,7 +3266,7 @@ long do_syscall_trace_enter(struct pt_regs *regs)
>  	user_exit();
>  
>  	if (test_thread_flag(TIF_SYSCALL_EMU)) {
> -		ptrace_report_syscall(regs);
> +		(void) tracehook_report_syscall_entry(regs);
>  		/*
>  		 * Returning -1 will skip the syscall execution. We want to
>  		 * avoid clobbering any register also, thus, not 'gotoing'
> -- 
> 2.19.1