Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp420367imu; Fri, 16 Nov 2018 04:45:40 -0800 (PST) X-Google-Smtp-Source: AJdET5cs+4km4Dth3mgVbMgEhqFkT67i4A9hLwjw1IBf4szVG5IGF2ImpIqdgiy0qrAD/75GkepW X-Received: by 2002:a17:902:d806:: with SMTP id a6mr10298258plz.172.1542372340364; Fri, 16 Nov 2018 04:45:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542372340; cv=none; d=google.com; s=arc-20160816; b=sHqQmJw9iIZXB8tfUvAXJF5U/QcZxzVOTCLv3XDx/XqDNrCVq5aZIfMqwgUsLnz+up 2MktUM2BlJK1H5PN+F/pmEiGjNgdy+rCVKkuRSccgvCC90BwxJnu8uVM72Q4qxftY+9A C+pd9CC+7s3hgVciFLh1DAdvalE9B7zSXfo/nwHRZgo5ZxkdH+Yam9de3ondn0LHlazH xKodgmzkpgBmSgOCAnrgYsQDkd0PjkFCishG3WjPg6bLDGRacMs4NK/OUZWrOas2bOJY juXyD9EJh+RvKyeQ41QZ1wHFFOhIiV5bOhVN69uHheXGjtFFzXJ1gEx/hmXJqooGM6cY KwTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from; bh=3qQa53ZXAasU1vJzjZfjvmfbpWw3oMD9+oshwb0xnFY=; b=0/mcqOYthPxtSMuzchHJb1R7miImNIYTVmhtUXQ/smJ/Ey+eawI4ezxiynM/9uBagQ XRrQczPNFQkGgF4LI1FGe57KO1Wro69GPBRzrEy1MpGl/j4NkpsaG5/n7lbyy/L/JTyu YhHHRnBwQ0plylMUxzO2DLGNcXgTkZz2UlgA8/pY31EYvIYumner6WihJHKyd4wwfzzo 0KsYEMT3oAtke+2ThagD+uF1BI5s7h08O4kazU5lw9RIKAKLASE5w9YW4PeU03fgmQw1 nactyi6blxvMORM2Zb2N5wChC3oOvtw8ACbq22053ZFM26O29BOJFfsC8yV93hgBd64K +J3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1-v6si18611835pln.368.2018.11.16.04.45.24; Fri, 16 Nov 2018 04:45:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389728AbeKPWzs (ORCPT + 99 others); Fri, 16 Nov 2018 17:55:48 -0500 Received: from mga04.intel.com ([192.55.52.120]:63354 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbeKPWzs (ORCPT ); Fri, 16 Nov 2018 17:55:48 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2018 04:43:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,240,1539673200"; d="scan'208";a="108686430" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 16 Nov 2018 04:43:31 -0800 From: Jani Nikula To: Julia Lawall , Geert Uytterhoeven Cc: ksummit-discuss@lists.linuxfoundation.org, "linux-nvdimm\@lists.01.org" , vishal.l.verma@intel.com, Linux Kernel Mailing List , Dmitry Vyukov , Greg KH , Mauro Carvalho Chehab , stfrench@microsoft.com, "Tobin C. Harding" Subject: Re: [Ksummit-discuss] [RFC PATCH 2/3] MAINTAINERS, Handbook: Subsystem Profile In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <154225759358.2499188.15268218778137905050.stgit@dwillia2-desk3.amr.corp.intel.com> <154225760492.2499188.14152986544451112930.stgit@dwillia2-desk3.amr.corp.intel.com> Date: Fri, 16 Nov 2018 14:44:07 +0200 Message-ID: <878t1tgpk8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Nov 2018, Julia Lawall wrote: > On Thu, 15 Nov 2018, Geert Uytterhoeven wrote: > >> Hi Julia, >> >> On Thu, Nov 15, 2018 at 6:48 AM Julia Lawall wrote: >> > How about patch subject lines? What is the formula that should be used to >> > transform the name(s) of the affected file(s) into an appropriate suject >> > line? >> >> Automating that may be difficult. >> I always use "git log --oneline", and try to derive something sane >> from its output. > > Yes, I do likewise. But there may be some subsystems for which it would > be possible to come up with a more specific policy. The advantage of what > is proposed here is that it is not necessary to come up with a single > formula that works everywhere. Even a description in English could be > helpful. I quickly cooked up this script to produce the top-5 commit prefixes for the given files over the arbitrary last 200 commits. It'll give you a pretty good idea if you're even close. --- #!/bin/sh # usage: subject-prefix FILE [...] # show top 5 subject prefixes for FILEs git log --format=%s -n 200 -- "$@" |\ grep -v "^Merge " |\ sed 's/\(.*\):.*/\1/' |\ sort | uniq -c | sort -nr | sed 's/ *[0-9]\+ //' |\ head -n 5 --- Someone who knows perl could turn that into a checkpatch check: See if the patch subject prefix is one of the top-5 for all files changed by the patch, and ask the user to double check if it isn't. Or some heuristics thereof. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center